Linux-Bluetooth Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH RESEND] obex: report notification status on incoming message
@ 2020-02-07  5:08 Matt Ranostay
  2020-02-11 21:01 ` Luiz Augusto von Dentz
  0 siblings, 1 reply; 3+ messages in thread
From: Matt Ranostay @ 2020-02-07  5:08 UTC (permalink / raw)
  To: linux-bluetooth; +Cc: Matt Ranostay

To match doc/obex.txt on incoming message notification the respective
Status field should be set.
---
 obexd/client/map.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/obexd/client/map.c b/obexd/client/map.c
index 550c5afb4..23be2d6b2 100644
--- a/obexd/client/map.c
+++ b/obexd/client/map.c
@@ -1914,6 +1914,7 @@ static void map_handle_notification(struct map_event *event, void *user_data)
 	switch (event->type) {
 	case MAP_ET_NEW_MESSAGE:
 		map_handle_new_message(map, event);
+		map_handle_status_changed(map, event, "notification");
 		break;
 	case MAP_ET_DELIVERY_SUCCESS:
 		map_handle_status_changed(map, event, "delivery-success");
-- 
2.20.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH RESEND] obex: report notification status on incoming message
  2020-02-07  5:08 [PATCH RESEND] obex: report notification status on incoming message Matt Ranostay
@ 2020-02-11 21:01 ` Luiz Augusto von Dentz
  0 siblings, 0 replies; 3+ messages in thread
From: Luiz Augusto von Dentz @ 2020-02-11 21:01 UTC (permalink / raw)
  To: Matt Ranostay; +Cc: linux-bluetooth

Hi Matt.

On Thu, Feb 6, 2020 at 9:12 PM Matt Ranostay <matt.ranostay@konsulko.com> wrote:
>
> To match doc/obex.txt on incoming message notification the respective
> Status field should be set.
> ---
>  obexd/client/map.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/obexd/client/map.c b/obexd/client/map.c
> index 550c5afb4..23be2d6b2 100644
> --- a/obexd/client/map.c
> +++ b/obexd/client/map.c
> @@ -1914,6 +1914,7 @@ static void map_handle_notification(struct map_event *event, void *user_data)
>         switch (event->type) {
>         case MAP_ET_NEW_MESSAGE:
>                 map_handle_new_message(map, event);
> +               map_handle_status_changed(map, event, "notification");
>                 break;
>         case MAP_ET_DELIVERY_SUCCESS:
>                 map_handle_status_changed(map, event, "delivery-success");
> --
> 2.20.1

Applied, thanks.

-- 
Luiz Augusto von Dentz

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH RESEND] obex: report notification status on incoming message
@ 2019-08-29 19:38 Matt Ranostay
  0 siblings, 0 replies; 3+ messages in thread
From: Matt Ranostay @ 2019-08-29 19:38 UTC (permalink / raw)
  To: linux-bluetooth; +Cc: Matt Ranostay

To match doc/obex.txt on incoming message notification the respective
Status field should be set.
---
 obexd/client/map.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/obexd/client/map.c b/obexd/client/map.c
index 550c5afb4..23be2d6b2 100644
--- a/obexd/client/map.c
+++ b/obexd/client/map.c
@@ -1914,6 +1914,7 @@ static void map_handle_notification(struct map_event *event, void *user_data)
 	switch (event->type) {
 	case MAP_ET_NEW_MESSAGE:
 		map_handle_new_message(map, event);
+		map_handle_status_changed(map, event, "notification");
 		break;
 	case MAP_ET_DELIVERY_SUCCESS:
 		map_handle_status_changed(map, event, "delivery-success");
-- 
2.20.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-07  5:08 [PATCH RESEND] obex: report notification status on incoming message Matt Ranostay
2020-02-11 21:01 ` Luiz Augusto von Dentz
  -- strict thread matches above, loose matches on Subject: below --
2019-08-29 19:38 Matt Ranostay

Linux-Bluetooth Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-bluetooth/0 linux-bluetooth/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-bluetooth linux-bluetooth/ https://lore.kernel.org/linux-bluetooth \
		linux-bluetooth@vger.kernel.org
	public-inbox-index linux-bluetooth

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-bluetooth


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git