Linux-Bluetooth Archive on lore.kernel.org
 help / color / Atom feed
From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
To: "Gix, Brian" <brian.gix@intel.com>
Cc: "linux-bluetooth@vger.kernel.org"
	<linux-bluetooth@vger.kernel.org>,
	"Stotland, Inga" <inga.stotland@intel.com>
Subject: Re: [PATCH BlueZ v2] unit: Add Mesh Crypto tests from Mesh Profile Spec
Date: Fri, 11 Oct 2019 16:07:18 +0300
Message-ID: <CABBYNZJXWe12oFUB+AXkDELFSDSLq9Dof1TJ-RYqjzEw3mVKzQ@mail.gmail.com> (raw)
In-Reply-To: <eccd2dff7fa5e04605a3b0302315060f99c80e53.camel@intel.com>

Hi Brian,

On Wed, Oct 9, 2019 at 7:01 PM Gix, Brian <brian.gix@intel.com> wrote:
>
> Hi Luiz,
>
> On Wed, 2019-10-09 at 17:59 +0300, Luiz Augusto von Dentz wrote:
> > On Thu, 2019-10-03 at 13:44 -0700, Brian Gix wrote:
> > > > This unit test will be grown over time to include tests formed from the
> > > > sample data in the Bluetooth Mesh Profile specification (Currently at
> > > > version v1.0.1).
> > > >
> > > > Currently it includes test cases for the following sets of sample data:
> > > > Sections 8.1.1-6
> > > > Sections 8.2.1-6
> > > > Sections 8.3.1-11
> > > > Section 8.4.3
> > > > Section 8.6.2
> > > > ---
> > > >  Makefile.am             |   10 +
> > > >  unit/test-mesh-crypto.c | 2000 +++++++++++++++++++++++++++++++++++++++
> > > >  2 files changed, 2010 insertions(+)
> > > >  create mode 100644 unit/test-mesh-crypto.c
> > > >
> >
> > make test is failing on this one:
>
> What platform/command line are you getting to see this?  or are you running it under a static analysis tool of
> some sort?
>
> I am getting no errors on F30, bith 32 and 64 bit...
>
> But I will check out the check_id_beacon() function...

I think you might not have valgrind installed or the build is not able
to detect, anyway you can run the test manually like this:

valgrind --trace-children=yes --leak-check=full --show-reachable=no
unit/test-mesh-crypto

> >
> > ==25559== 8 bytes in 1 blocks are definitely lost in loss record 1 of 4
> > ==25559==    at 0x483880B: malloc (vg_replace_malloc.c:309)
> > ==25559==    by 0x11FB25: l_malloc (util.c:62)
> > ==25559==    by 0x120232: l_util_from_hexstring (util.c:427)
> > ==25559==    by 0x118069: check_id_beacon (test-mesh-crypto.c:1709)
> > ==25559==    by 0x118069: main (test-mesh-crypto.c:1997)
> >
> > Btw usually the test are using the tester framework and it should be
> > possible to integrate with that but that probably need some work to
> > make you able to run with ell mainloop.
> >
> >
> >
> >
> > --
> > Luiz Augusto von Dentz



-- 
Luiz Augusto von Dentz

      reply index

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-03 20:44 Brian Gix
2019-10-05 16:12 ` Gix, Brian
2019-10-09 14:59   ` Luiz Augusto von Dentz
2019-10-09 16:01     ` Gix, Brian
2019-10-11 13:07       ` Luiz Augusto von Dentz [this message]

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CABBYNZJXWe12oFUB+AXkDELFSDSLq9Dof1TJ-RYqjzEw3mVKzQ@mail.gmail.com \
    --to=luiz.dentz@gmail.com \
    --cc=brian.gix@intel.com \
    --cc=inga.stotland@intel.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Bluetooth Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-bluetooth/0 linux-bluetooth/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-bluetooth linux-bluetooth/ https://lore.kernel.org/linux-bluetooth \
		linux-bluetooth@vger.kernel.org linux-bluetooth@archiver.kernel.org
	public-inbox-index linux-bluetooth

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-bluetooth


AGPL code for this site: git clone https://public-inbox.org/ public-inbox