Linux-Bluetooth Archive on lore.kernel.org
 help / color / Atom feed
From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
To: "Pali Rohár" <pali.rohar@gmail.com>
Cc: "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
Subject: Re: [PATCH] avinfo: Fix parsing capabilities
Date: Thu, 31 Jan 2019 12:49:40 +0200
Message-ID: <CABBYNZK2WzHXvmBZXyLqB_xHR13XRxUCnT38ZPY3sDOs=utdFg@mail.gmail.com> (raw)
In-Reply-To: <20190126102415.23786-1-pali.rohar@gmail.com>

Hi Pali,
On Sat, Jan 26, 2019 at 12:25 PM Pali Rohár <pali.rohar@gmail.com> wrote:
>
> Function print_caps() expects capabilities buffer without AVDTP header.
> Previously avinfo somehow worked, because AVDTP header looks like
> capability header with unknown category which was skipped.
> ---
>  tools/avinfo.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/avinfo.c b/tools/avinfo.c
> index 02fc1f233..a3298e8c8 100644
> --- a/tools/avinfo.c
> +++ b/tools/avinfo.c
> @@ -809,7 +809,7 @@ static ssize_t avdtp_get_caps(int sk, int seid)
>                 return -1;
>         }
>
> -       print_caps(caps, ret);
> +       print_caps(caps->caps, ret - sizeof(struct getcap_resp));
>
>         return 0;
>  }
> --
> 2.11.0

Applied, thanks.

-- 
Luiz Augusto von Dentz

      reply index

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-26 10:24 Pali Rohár
2019-01-31 10:49 ` Luiz Augusto von Dentz [this message]

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CABBYNZK2WzHXvmBZXyLqB_xHR13XRxUCnT38ZPY3sDOs=utdFg@mail.gmail.com' \
    --to=luiz.dentz@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=pali.rohar@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Bluetooth Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-bluetooth/0 linux-bluetooth/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-bluetooth linux-bluetooth/ https://lore.kernel.org/linux-bluetooth \
		linux-bluetooth@vger.kernel.org linux-bluetooth@archiver.kernel.org
	public-inbox-index linux-bluetooth


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-bluetooth


AGPL code for this site: git clone https://public-inbox.org/ public-inbox