linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
To: "Jonas Dreßler" <verdre@v0yd.nl>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH BlueZ 2/4] mgmt-tester: Adjust a test for recent kernel changes
Date: Mon, 29 Jan 2024 08:41:48 -0500	[thread overview]
Message-ID: <CABBYNZKEYUgf0kvsKVMnQio6-eVm3ziCFmPYTGMrzew9qxjiGA@mail.gmail.com> (raw)
In-Reply-To: <20240129114900.92919-3-verdre@v0yd.nl>

Hi Jonas,

On Mon, Jan 29, 2024 at 6:49 AM Jonas Dreßler <verdre@v0yd.nl> wrote:
>
> With the changes in the kernel to move to hci_sync for connecting ACL
> devices (see kernel commit "Bluetooth: hci_conn: Only do ACL connections
> sequentially", https://lore.kernel.org/linux-bluetooth/20240108224614.56900-1-verdre@v0yd.nl/),
> the "ETIMEDOUT" error path for the "HCI Create Connection" command was
> changed, sending a "HCI Create Connection Cancel" after the timeout.
>
> This leads to the returned error in the "Pair Device - Power off 1"
> test to change from NOT_POWERED to DISCONNECTED, so adjust for that.
> ---
>  tools/mgmt-tester.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/mgmt-tester.c b/tools/mgmt-tester.c
> index ee12ed7d5..7c9e63cbb 100644
> --- a/tools/mgmt-tester.c
> +++ b/tools/mgmt-tester.c
> @@ -3216,7 +3216,7 @@ static const struct generic_data pair_device_power_off_test_1 = {
>         .send_opcode = MGMT_OP_PAIR_DEVICE,
>         .send_func = pair_device_send_param_func,
>         .force_power_off = true,
> -       .expect_status = MGMT_STATUS_NOT_POWERED,
> +       .expect_status = MGMT_STATUS_DISCONNECTED,
>         .expect_func = pair_device_expect_param_func,
>  };
>
> --
> 2.43.0

We haven't applied all the changes from that set though, are you
planning to resend them?

-- 
Luiz Augusto von Dentz

  reply	other threads:[~2024-01-29 13:42 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-29 11:48 [PATCH BlueZ 0/4] Adjust tests for sequential conn establishing Jonas Dreßler
2024-01-29 11:48 ` [PATCH BlueZ 1/4] mgmt-tester: Add a 0-opcode to expect_hci_list lists Jonas Dreßler
2024-01-29 13:40   ` Luiz Augusto von Dentz
2024-02-06 10:26     ` Jonas Dreßler
2024-01-29 13:52   ` Adjust tests for sequential conn establishing bluez.test.bot
2024-01-29 11:48 ` [PATCH BlueZ 2/4] mgmt-tester: Adjust a test for recent kernel changes Jonas Dreßler
2024-01-29 13:41   ` Luiz Augusto von Dentz [this message]
2024-01-29 11:48 ` [PATCH BlueZ 3/4] emulator/btdev: Send page timeout after 2 secs delay Jonas Dreßler
2024-01-29 13:58   ` Luiz Augusto von Dentz
2024-01-29 11:49 ` [PATCH BlueZ 4/4] mgmt-tester: Add a test for connecting sequentially Jonas Dreßler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CABBYNZKEYUgf0kvsKVMnQio6-eVm3ziCFmPYTGMrzew9qxjiGA@mail.gmail.com \
    --to=luiz.dentz@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=verdre@v0yd.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).