From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
To: Yun-hao Chung <howardchung@google.com>
Cc: "linux-bluetooth@vger.kernel.org"
<linux-bluetooth@vger.kernel.org>,
Yun-Hao Chung <howardchung@chromium.org>,
Archie Pusaka <apusaka@chromium.org>
Subject: Re: [Bluez PATCH v1] gatt-db: fix service in range check
Date: Tue, 27 Jul 2021 20:53:49 -0700 [thread overview]
Message-ID: <CABBYNZKme8gTytB6=CBqv636t5hFy637DhaqipCRDRCei+t_Ag@mail.gmail.com> (raw)
In-Reply-To: <CAPHZWUc0wHLVTSFGzEYWjE-3f4JyKyXtYem+wBm11K3kxn3pQw@mail.gmail.com>
Hi Howard,
On Tue, Jul 27, 2021 at 7:51 PM Yun-hao Chung <howardchung@google.com> wrote:
>
> > > > if (svc_start < foreach_data->start ||
> > > > svc_start > foreach_data->end)
> > > > return;
> After discussing with Archie, if we understand you correctly, we think
> this early return can be removed.
> Let's say the searched range is 5-9 and the service is 1-14, then we
> should consider the service is in range.
> If we want to keep the early return, svc_start > foreach_data->end is
> already checked a few lines before, so this check is redundant.
Yep, that seems we have already had the same check so Im fine dropping
the check.
--
Luiz Augusto von Dentz
prev parent reply other threads:[~2021-07-28 3:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-27 11:51 [Bluez PATCH v1] gatt-db: fix service in range check Howard Chung
2021-07-27 12:52 ` [Bluez,v1] " bluez.test.bot
2021-07-27 22:17 ` [Bluez PATCH v1] " Luiz Augusto von Dentz
2021-07-28 2:19 ` Yun-hao Chung
2021-07-28 2:51 ` Yun-hao Chung
2021-07-28 3:53 ` Luiz Augusto von Dentz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABBYNZKme8gTytB6=CBqv636t5hFy637DhaqipCRDRCei+t_Ag@mail.gmail.com' \
--to=luiz.dentz@gmail.com \
--cc=apusaka@chromium.org \
--cc=howardchung@chromium.org \
--cc=howardchung@google.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).