From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 919BFC77B7A for ; Wed, 17 May 2023 21:50:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229464AbjEQVu6 (ORCPT ); Wed, 17 May 2023 17:50:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49396 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229445AbjEQVu4 (ORCPT ); Wed, 17 May 2023 17:50:56 -0400 Received: from mail-lj1-x22e.google.com (mail-lj1-x22e.google.com [IPv6:2a00:1450:4864:20::22e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D9CB972AA for ; Wed, 17 May 2023 14:50:54 -0700 (PDT) Received: by mail-lj1-x22e.google.com with SMTP id 38308e7fff4ca-2ac81d2bfbcso13067431fa.3 for ; Wed, 17 May 2023 14:50:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684360253; x=1686952253; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=3grk5dpFI6zWvE7jxS83hTJqN6Hc7+EC2+iE2Ia8Eqw=; b=d7nu6dNBxScbNmPBN1Ov7RV4I1N8cTrj649iepacKFuQ1f8M2UbgdvClRGpGZ287JE uGuBrYdM3g60PIVKSonjBZNuwh0FzyIKqzCjx1tFE3coEYVe1mJQFx/YGrTcDjzdU1ug 5HAKOcf79/jIfHftkdB65qzxek87NLmUmXGp+TSTr4vOY9rLKK80xbE1ijPsPEMXuW0B kOTdof+TRjj5CXtAfWIEyZ94EX743yhVCe8tb7oYhWTFNmM5bNYF0Jtl8ejWXO8U8MDt TmDS2QhZUNLPYV3orGMXYMldibonNnl8yDlNJb2f8bUaSvCc7TpcjkDm11D9IqHAasdP q69Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684360253; x=1686952253; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3grk5dpFI6zWvE7jxS83hTJqN6Hc7+EC2+iE2Ia8Eqw=; b=aIhPhXHP44/Bclh/UKj1cZbNlZgPVC3ZgF8WDCIPMnEex9A6HzRutKxP/rvb0/ow6j 1dPPW2EalhE5WF09kHI5gmryOWwA4r8N20GCXieP30+AIPjkx7l5FZ1fgMsEyJxcPdDM GybEKLNAqRFLYlvIIoaBIGjQUVHuhLiAZ3t+E2vkfqT7whDmgpZOQgtZ2MZN32wssg2V lc1icodK8Dk4MfiJ8zsFFdCy8gP/8gDPXjcJ+FsHDG5rgGc1VZgbZgU3E72N3UO0M9xI 3/CSS6M8l5bLzjOybqAPDP1eSyeiIGiCQ22a7xI4aPY+EO7wlfKn/h/kxI/jAEHeKI+7 sCXQ== X-Gm-Message-State: AC+VfDxwriOBlsMP6cQ4hyT+XFODAKOqm3bssZWU/soWhDSqEs++ev2i wrhu2NC4R736Rct3o65YH7woc+mZV9y56MPiysE= X-Google-Smtp-Source: ACHHUZ65ASsbR47DLrtRwl9yg53cVMeLp3/EQitfWxVQZB0/r8l943KTWmgFHt/HIcm465/KcBsOQ7GIqdxmZH060Rs= X-Received: by 2002:a2e:8809:0:b0:2a7:7b8e:5888 with SMTP id x9-20020a2e8809000000b002a77b8e5888mr10892092ljh.27.1684360252729; Wed, 17 May 2023 14:50:52 -0700 (PDT) MIME-Version: 1.0 References: <645fc6ce.630a0220.1799b.9542@mx.google.com> <87eda7c7bdb8479f6233b6709e5c21de0535fdfc.camel@iki.fi> <25523ad612ce4491281743bc8d5a6ccf7673aa76.camel@iki.fi> <8991642e1279b0d7548482a6102e5c75306d6009.camel@iki.fi> <17725c9488b0d5eb5e39404bcff873d58a1e3edb.camel@iki.fi> In-Reply-To: <17725c9488b0d5eb5e39404bcff873d58a1e3edb.camel@iki.fi> From: Luiz Augusto von Dentz Date: Wed, 17 May 2023 14:50:40 -0700 Message-ID: Subject: Re: [BlueZ,v3,1/2] test-runner: revert udevd and audio support To: Pauli Virtanen Cc: linux-bluetooth@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org Hi Pauli, On Wed, May 17, 2023 at 2:43=E2=80=AFPM Pauli Virtanen wrote: > > ke, 2023-05-17 kello 14:25 -0700, Luiz Augusto von Dentz kirjoitti: > > Hi Pauli, > > > > On Wed, May 17, 2023 at 2:16=E2=80=AFPM Pauli Virtanen wro= te: > > > > > > Hi Luiz, > > > > > > ke, 2023-05-17 kello 13:53 -0700, Luiz Augusto von Dentz kirjoitti: > > > > Hi Pauli, > > > > > > > > On Wed, May 17, 2023 at 1:30=E2=80=AFPM Pauli Virtanen = wrote: > > > > > > > > > > Hi Luiz, > > > > > > > > > > ke, 2023-05-17 kello 12:34 -0700, Luiz Augusto von Dentz kirjoitt= i: > > > > > > Hi Pauli, > > > > > > > > > > > > On Mon, May 15, 2023 at 1:30=E2=80=AFPM Pauli Virtanen wrote: > > > > > > > > > > > > > > Hi Luiz, > > > > > > > > > > > > > > ma, 2023-05-15 kello 13:01 -0700, Luiz Augusto von Dentz kirj= oitti: > > > > > > > > Hi Pauli, > > > > > > > > > > > > > > > > On Sat, May 13, 2023 at 10:41=E2=80=AFAM wrote: > > > > > > > > > > > > > > > > > > This is automated email and please do not reply to this e= mail! > > > > > > > > > > > > > > > > > > Dear submitter, > > > > > > > > > > > > > > > > > > Thank you for submitting the patches to the linux bluetoo= th mailing list. > > > > > > > > > This is a CI test results with your patch series: > > > > > > > > > PW Link:https://patchwork.kernel.org/project/bluetooth/li= st/?series=3D747273 > > > > > > > > > > > > > > > > > > ---Test result--- > > > > > > > > > > > > > > > > > > Test Summary: > > > > > > > > > CheckPatch FAIL 1.14 seconds > > > > > > > > > GitLint PASS 0.52 seconds > > > > > > > > > BuildEll PASS 26.21 seconds > > > > > > > > > BluezMake PASS 745.32 seconds > > > > > > > > > MakeCheck PASS 11.04 seconds > > > > > > > > > MakeDistcheck PASS 151.18 seconds > > > > > > > > > CheckValgrind PASS 243.86 seconds > > > > > > > > > CheckSmatch PASS 326.99 seconds > > > > > > > > > bluezmakeextell PASS 98.83 seconds > > > > > > > > > IncrementalBuild PASS 1262.88 seconds > > > > > > > > > ScanBuild WARNING 964.73 seconds > > > > > > > > > > > > > > > > > > Details > > > > > > > > > ############################## > > > > > > > > > Test: CheckPatch - FAIL > > > > > > > > > Desc: Run checkpatch.pl script > > > > > > > > > Output: > > > > > > > > > [BlueZ,v3,1/2] test-runner: revert udevd and audio suppor= t > > > > > > > > > WARNING:UNKNOWN_COMMIT_ID: Unknown commit id '91a48af52ef= b0751fab396b2b9026c9186b10b88', maybe rebased or not pulled? > > > > > > > > > #49: > > > > > > > > > This reverts commit 91a48af52efb0751fab396b2b9026c9186b10= b88 > > > > > > > > > > > > > > > > > > WARNING:UNKNOWN_COMMIT_ID: Unknown commit id 'e20e7e0b05c= 7edb74255c9b092916ac5bb99c97f', maybe rebased or not pulled? > > > > > > > > > #50: > > > > > > > > > This reverts commit e20e7e0b05c7edb74255c9b092916ac5bb99c= 97f > > > > > > > > > > > > > > > > > > /github/workspace/src/src/13240258.patch total: 0 errors,= 2 warnings, 193 lines checked > > > > > > > > > > > > > > > > > > NOTE: For some of the reported defects, checkpatch may be= able to > > > > > > > > > mechanically convert to the typical style using --f= ix or --fix-inplace. > > > > > > > > > > > > > > > > > > /github/workspace/src/src/13240258.patch has style proble= ms, please review. > > > > > > > > > > > > > > > > > > NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO= CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE= _TAG SPLIT_STRING SSCANF_TO_KSTRTO > > > > > > > > > > > > > > > > > > NOTE: If any of the errors are false positives, please re= port > > > > > > > > > them to the maintainer, see CHECKPATCH in MAINTAINE= RS. > > > > > > > > > > > > > > > > > > > > > > > > > > > ############################## > > > > > > > > > Test: ScanBuild - WARNING > > > > > > > > > Desc: Run Scan Build > > > > > > > > > Output: > > > > > > > > > tools/test-runner.c:924:2: warning: 2nd function call arg= ument is an uninitialized value > > > > > > > > > printf("Running command %s\n", cmdname ? cmdname = : argv[0]); > > > > > > > > > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~= ~~~~~~~~~~ > > > > > > > > > 1 warning generated. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > --- > > > > > > > > > Regards, > > > > > > > > > Linux Bluetooth > > > > > > > > > > > > > > > > I tried running on fedora but it looks like something is mi= ssing in my setup: > > > > > > > > > > > > > > > > [E][00003.767959] spa.dbus | [ dbus.c: 329 > > > > > > > > impl_connection_get()] Failed to connect to session bus: Un= able to > > > > > > > > autolaun1 > > > > > > > > [E][00003.769967] mod.portal | [ module-portal.c: 326 > > > > > > > > pipewire__module_init()] Failed to connect to session bus: > > > > > > > > Input/output error > > > > > > > > > > > > > > I have those two "errors" too, they should be harmless as the= xdg- > > > > > > > desktop-portal module is optional. With `test-runner -d -l -A= ` you > > > > > > > should get the Bluetooth endpoints to appear. > > > > > > > > > > > > > > Removing the mod.portal from the configuration can't be done = with drop- > > > > > > > in config files currently, and I didn't want to include a ful= l config > > > > > > > file here as it has some tens of lines of mandatory boilerpla= te. > > > > > > > > > > > > Ok, looks like it configuring the endpoints: > > > > > > > > > > > > https://gist.github.com/Vudentz/0d8851e719affd9f2dc1f4081ce32fb= 7 > > > > > > > > > > > > That said I probably need to compile pipewire from source in or= der to > > > > > > have the LE Audio endpoints registered, btw do you have any > > > > > > instructions on how to build it, do I need to build wireplumber= as > > > > > > well? > > > > > > > > > > Should be along these lines to install under $PWD/install and ena= ble > > > > > BAP parts: > > > > > > > > > > git clone https://gitlab.freedesktop.org/pipewire/pipewire.git > > > > > cd pipewire > > > > > LDFLAGS=3D"-Wl,-rpath=3D$PWD/install/lib64" \ > > > > > meson setup builddir --prefix=3D$PWD/install \ > > > > > -Dsystemd-user-service=3Ddisabled \ > > > > > -Dudevrulesdir=3D$PWD/install/lib/udev/rules.d \ > > > > > -Dbluez5-codec-lc3=3Denabled > > > > > meson install -C builddir > > > > > > > > > > Meson will clone and install Wireplumber too. Turning experimenta= l on > > > > > in src/main.conf and it should give > > > > > > > > > > $ ./tools/test-runner -d -l --audio=3D/home/pauli/tmp/pipewire/in= stall/bin/pipewire -k../linux/arch/x86_64/boot/bzImage sleep 5 > > > > > ... > > > > > bluetoothd[29]: profiles/audio/media.c:endpoint_init_pac() PAC :1= .1:/MediaEndpointLE/BAPSource/lc3 registered > > > > > bluetoothd[29]: Endpoint registered: sender=3D:1.1 path=3D/MediaE= ndpointLE/BAPSource/lc3 > > > > > bluetoothd[29]: profiles/audio/media.c:client_ready_cb() Media ap= plication registered: :1.1:/MediaEndpointLE > > > > > ... > > > > > > > > Thanks, something is not quite right for me since I don't see any > > > > objects on MediaEndpointLE: > > > > > > > > https://gist.github.com/Vudentz/242e4e2bfb8907acfdfdf18b458eec1d > > > > > > It gets "No object received" when trying to register the BAP > > > application, so probably the LC3 codec is missing somehow. > > > > > > meson setup should have reported > > > "Bluetooth audio codecs ... LC3 : YES". > > > > Yep, that shows as enabled. > > > > > `ldd install/bin/pipewire` should link to libpipewire-0.3.so.0 under > > > the install/ prefix and not to system lib. If not, the rpath in > > > compilation accordingly should be adjusted accordingly, or set > > > LD_LIBRARY_PATH there. > > > > libpipewire-0.3.so.0 =3D> > > /home/vudentz/git/pipewire/install/lib64/libpipewire-0.3.so.0 > > (0x00007f3b8e947000) > > > > > Also the codec plugin > > > install/lib64/spa-0.2/bluez5/libspa-codec-bluez5-lc3.so should exist. > > > > -rwxr-xr-x. 1 **** **** 166592 May 17 13:39 > > install/lib64/spa-0.2/bluez5/libspa-codec-bluez5-lc3.so > > Does `ldd libspa-codec-bluez5-lc3.so` show it finds liblc3.so? I guess we found the problem: liblc3.so.1 =3D> not found > > Perhaps we need to enable more debugs for pipewire to sort this out? > > ./tools/test-runner -d -l --audio=3D/home/pauli/tmp/pipewire/install/bin/= pipewire -k../linux/arch/x86_64/boot/bzImage -- /bin/bash > ... inside vm: ... > pkill wireplumber > export XDG_CONFIG_HOME=3D/run/conf > export XDG_STATE_HOME=3D/run > export XDG_RUNTIME_DIR=3D/run > export WIREPLUMBER_DEBUG=3D4 > /home/pauli/tmp/pipewire/install/bin/wireplumber > > should spit out what it tried to do. Yep, here is the full trace: https://gist.github.com/Vudentz/36f9acdc62b623c85e978883ea29c2d3 But I think the problem is with the linking of liblc3, are you running with the latest from git? Perhaps I need to install it also in the same path? --=20 Luiz Augusto von Dentz