From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72515C4338F for ; Thu, 5 Aug 2021 18:59:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3FAA160EE9 for ; Thu, 5 Aug 2021 18:59:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241703AbhHES7o (ORCPT ); Thu, 5 Aug 2021 14:59:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48640 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233152AbhHES7o (ORCPT ); Thu, 5 Aug 2021 14:59:44 -0400 Received: from mail-yb1-xb34.google.com (mail-yb1-xb34.google.com [IPv6:2607:f8b0:4864:20::b34]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E97DBC061765 for ; Thu, 5 Aug 2021 11:59:28 -0700 (PDT) Received: by mail-yb1-xb34.google.com with SMTP id z18so10697623ybg.8 for ; Thu, 05 Aug 2021 11:59:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=HX+fCs1ChmCe5rrg/UHyLAPlfDvZLlkS69G8xb69ZX8=; b=qx4+IONOOAQPQE7Jjr/qohPAOJYWNhuMq2/IxKOcfzAELZ5H+Kho611jtyggElX3qy oKfH1U0Vn7GiZgpoI/6TqgR/l0TktAG7GX7HETZM4KXR/45eAe1sDWVA2JxR3kFj6Rj9 rZsWw42qn09EKkOekdWvIW32gPzo3OdC9DnoPVRdq9IV478EXYcoDqlDI8rP6K7P4qPO SgWOMHeGZ90uaZRvrL+fICw1LZp9V41+1XuSpZGx1Uto9ufzLZ82owZpQAT/LbLDnT8R HQeAeCR/xKQs3AnduNue/lIG2qDlZvHl9JLwwtDvHJEO810EFGyorOMDiCtepb5+rILg DiMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HX+fCs1ChmCe5rrg/UHyLAPlfDvZLlkS69G8xb69ZX8=; b=Xr75YJ9nef+CVbZx0H7DVNHrgVzXMxeiOHNCwFpZsKKI8G33HYtWMIX9OtKpqJEWqV fxZpKz0o+5YxYvToRjJNcG619kf1SI1GW8HLaXECsHnC77ZaQFmbX6MzFyQRiKPFh5Zx G2WMKJxGU2FE68WFIsXoRnnLU+iOsP9Dl/8TbwnAdaNuzZ5j4iVKesD8lDwsx/hoqhVv ZsVX5+5qr/GDpkfyktaX8gKxYG6q2zX34Niy+IdZN4sUZK5zlSjKlZrwNC/6/alxgUFT zKYtFKrgQv/KpPoPxgviQqikE4fGSKHkdTA7Kztcjauph8vtWYTooahw3MGOEmWMozKf 66Ag== X-Gm-Message-State: AOAM531yXBINWswesj7d/9tcWc4+8PkrrHLlbqFiO0T/pHMQ7m/MZ6qm 9Ijz2cv4zcoO+kDt5nNRMnMLqvBraSZXntXt3aE= X-Google-Smtp-Source: ABdhPJyZZHdyZ0MAE1KBs6napnFAASJO0eAl4ygiLTRdQpR8aZwv2XEIf7DLY0LUBU3QzdF2vh7CW644lqrLMhrtaK8= X-Received: by 2002:a25:bd89:: with SMTP id f9mr978225ybh.222.1628189968078; Thu, 05 Aug 2021 11:59:28 -0700 (PDT) MIME-Version: 1.0 References: <290fe7c7-c14f-8685-af09-419faa0e4d1f@i-love.sakura.ne.jp> In-Reply-To: From: Luiz Augusto von Dentz Date: Thu, 5 Aug 2021 11:59:17 -0700 Message-ID: Subject: Re: [PATCH v4] Bluetooth: defer cleanup of resources in hci_unregister_dev() To: Linus Torvalds Cc: Tetsuo Handa , Johan Hedberg , Marcel Holtmann , linux-bluetooth , LinMa Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org Hi Linus, On Thu, Aug 5, 2021 at 11:45 AM Linus Torvalds wrote: > > On Thu, Aug 5, 2021 at 11:19 AM Luiz Augusto von Dentz > wrote: > > > > It doesn't apply to bluetooth-next, could you please rebase it. > > If you're ok with the patch, I think it should go into 5.14 - and be > marked for stable. > > The locking right now is very wrong, and causes syzbot warnings and > probably keeps people from finding other things. > > And we can't just revert the incorrect locking change, because it was > a security issue. > > So this should go in the current release cycle. I agree it's a bit > scary - not because I think the patch is all that complicated, but > because this area has clearly had issues and is subtle - but I'd > rather do it asap and get reports on it early than delay it further. Alright so we are skipping bluetooth-next then, I thought of using bluetooth-next for further testing these changes but I agree this should go into 5.14 so Im fine if you take it straight to your tree: Signed-off-by: Luiz Augusto von Dentz -- Luiz Augusto von Dentz