From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4AE4BC7618B for ; Wed, 24 Jul 2019 10:45:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F3C7D229ED for ; Wed, 24 Jul 2019 10:45:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MDplCd4E" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726960AbfGXKpL (ORCPT ); Wed, 24 Jul 2019 06:45:11 -0400 Received: from mail-ot1-f49.google.com ([209.85.210.49]:33991 "EHLO mail-ot1-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726070AbfGXKpL (ORCPT ); Wed, 24 Jul 2019 06:45:11 -0400 Received: by mail-ot1-f49.google.com with SMTP id n5so47405677otk.1 for ; Wed, 24 Jul 2019 03:45:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Ysfgv9eJns2Iy2zuW19H11UwG6Kws+1PSKhWpGVdiXc=; b=MDplCd4Ecm+hP+NFvrJhqyLhQUmzpYJ9JHmv/YFXec2lqdGbWctyHFV5MtkZ9dXO13 kqv+t1+4HHEtdO9cAysP1+V9JArKukpBoJR/gTCwJ/Wj23B4wNFx4U/gBKdN54FO3Dii PmBQEtNV7dOSusT5Xo/nG/XM8pSNTZgrqcxqJIzYwpeU2Kz80lcz98SReJc5GJex/0dI BA86x9a5eA8l9sAm1dU+i1V6ks4vWPk2j23wb+kJFU9layYkYroeI/493eTUw0cLb9MA 8t9kFLbtywwOx1C1mvcg5N1ucsOqZ1koyDXBf1xwQNTUOJjNhLIfFcllEw/03/LsHZRe hB5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Ysfgv9eJns2Iy2zuW19H11UwG6Kws+1PSKhWpGVdiXc=; b=OezEFOZJyCTMQUgnb39aU0DVZwYqHXA2KW6K/W0hAo5h07IrIRMxk0z/OpcPfqUfzm xdXh9/ag7fL30iFUjkWvM7LWT/BALJnhlq0iyCJgNqXxAuIfM8VK4ARdg+NTI+jmbOpf 4Szbla9x30e+i0Ei91Q5bywSa/OCDrWWBVwFngPKIbF90DE8oUDEfyD0bTPuZw0HwxPI yNzta7XNeR0Suzg6CX1UVZhXlrAfqXeowj/m7CqpDYDS8qddi8qsR0ET0mi1NzB6abuc LBxVQD49MUB1A38/DLPIDostAcVhIAN9bftiPTyce7ENjOFdF1EyanmK7lnhXaE+GG+T Fp0g== X-Gm-Message-State: APjAAAU2xxwGmOxnEd1VkTjFZBaNGEhpiK19VcwfWHWCeHEmk7nAGOQe S92OheoHwjxL8Oj0vg/ViMQNJgJ4H26SAXTmaTvoPYcG X-Google-Smtp-Source: APXvYqw5FSwFD3q9LlUbk7xFSBJVwzuHKDuQ+QwdLq1m2d5xROiL2u/N7eFhcNLV/FBbXPYv9kMTdnL5DaPlo/dWBb0= X-Received: by 2002:a05:6830:199:: with SMTP id q25mr61473501ota.79.1563965108691; Wed, 24 Jul 2019 03:45:08 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Luiz Augusto von Dentz Date: Wed, 24 Jul 2019 13:44:57 +0300 Message-ID: Subject: Re: DBus LEAdvertisement and Python To: Barry Byford <31baz66@gmail.com> Cc: Bluez mailing list Content-Type: text/plain; charset="UTF-8" Sender: linux-bluetooth-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org Hi Barry, On Wed, Jul 24, 2019 at 12:41 PM Barry Byford <31baz66@gmail.com> wrote: > > I have exhausted my ideas for debugging this issue. Using d-feet and > various other utilities the creation of the beacon using python-dbus > and pydbus looks identical. However, BlueZ doesn't seem to be able to > parse the properties from LEAdvertisement1 when it is created with > pydbus. > > It would be great if anyone has any ideas for what else to try. > Have people had similar issues using DBus libraries in other languages? > > For reference, I have installed pydbus with "sudo pip3 install pydbus" > I am running with BlueZ 5.50. > > The test code I am using is: > > > import pydbus > from gi.repository import GLib > > > class Advertisement: > """ > > > > value="true"/> > > name="org.freedesktop.DBus.Properties.PropertiesChanged" > value="const"/> > > > Type here is wrong, it should be a{qv} see: https://git.kernel.org/pub/scm/bluetooth/bluez.git/tree/client/advertising.c#n464 Im surprised the daemon don't generate report an error? Or it does register but it still doesn't advertise? > > > > > > """ > LE_ADVERTISEMENT_IFACE = 'org.bluez.LEAdvertisement1' > > def Release(self): > pass > > @property > def Type(self): > return 'broadcast' > > @property > def SolicitUUIDs(self): > return [] Don't include if empty. > @property > def ServiceUUIDs(self): > return ['FEAA'] > > @property > def ServiceData(self): > return {'FEAA': GLib.Variant('ay', [0x10, 0x08, 0x03, 0x75, > 0x6B, 0x42, 0x61, > 0x7A, 0x2e, 0x67, 0x69, 0x74, 0x68, 0x75, > 0x62, 0x2E, 0x69, 0x6F])} > > @property > def IncludeTxPower(self): > return False > > @property > def ManufacturerData(self): > return [] Same here, don't include it empty. > > class LEAdvertisement: > def __init__(self, service, object_path): > bus = pydbus.SystemBus() > bname = bus.request_name(service) > reg1 = bus.register_object(object_path, Advertisement(), None) > > > class LEAdvertisingManager: > def __init__(self, object_path): > lea_iface = 'org.bluez.LEAdvertisingManager1' > bus = pydbus.SystemBus() > ad_manager = bus.get('org.bluez', '/org/bluez/hci0')[lea_iface] > ad_manager.RegisterAdvertisement(object_path, {}) > > > if __name__ == '__main__': > app_name = 'ukBaz.bluezero' > app_path = '/ukBaz/bluezero/advertisement0099' > LEAdvertisement(app_name, app_path) > LEAdvertisingManager(app_path) > > loop = GLib.MainLoop() > try: > loop.run() > except KeyboardInterrupt: > print("\nStopping ...") > loop.quit() > > > > I have the following config to open the permissions up for this service name: > > $ more /etc/dbus-1/system.d/ukBaz.bluezero.conf > > Configuration 1.0//EN" > "http://www.freedesktop.org/standards/dbus/1.0/busconfig.dtd"> > > > > > > > send_interface="org.freedesktop.DBus.Introspectable"/> > > > > > > > > Feedback welcome. > > Cheers, > Barry > > > On Sat, 20 Jul 2019 at 17:44, Barry Byford <31baz66@gmail.com> wrote: > > > > Hello, > > > > I have done a little more investigation on this. The difference in > > behaviour between the working library and the failing library comes > > down to this line in the BlueZ source. > > https://git.kernel.org/pub/scm/bluetooth/bluez.git/tree/gdbus/client.c#n720 > > which is called from: > > https://git.kernel.org/pub/scm/bluetooth/bluez.git/tree/src/advertising.c#n1020 > > It appears g_hash_table_lookup is returning NULL. > > I am not familiar with C and have been doing this investigation with > > fprintf statements. I don't know how to get the values of > > "proxy->prop_list" and "name". Does anyone know how I can print these > > values out? > > Even better would be, if someone could point me at to what this > > relates to in the Python LE Advertisement setup through DBus. > > I've looked up the g_hash_table_lookup command: > > https://developer.gnome.org/glib/stable/glib-Hash-Tables.html#g-hash-table-lookup > > but this hasn't helped me. > > > > Thanks, > > Barry > > > > On Thu, 18 Jul 2019 at 22:04, Barry Byford <31baz66@gmail.com> wrote: > > > > > > Hello Luiz, > > > > > > Thanks for the prompt response. Below are some updates following your input. > > > > > > On Thu, 18 Jul 2019 at 09:26, Luiz Augusto von Dentz > > > wrote: > > > > > > > > Hi Barry, > > > > > > > > On Thu, Jul 18, 2019 at 10:03 AM Barry Byford <31baz66@gmail.com> wrote: > > > > > > > > > > Hello, > > > > > > > > > > The Python examples provided in the test directory of the BlueZ > > > > > repository use the python-dbus library. Looking at the documentation > > > > > of that library it does start by raising concerns and offering > > > > > alternatives. I have been looking at some of the alternatives and am > > > > > having difficultly getting them to work with BlueZ. I have been > > > > > focusing on the org.bluez.LEAdvertisement1 interface. > > > > > > > > > > Looking at the documentation, it says the service, interface and > > > > > object details are: > > > > > Service org.bluez > > > > > Interface org.bluez.LEAdvertisement1 > > > > > Object path freely definable > > > > > > > > > > I am not being successful at publishing to the org.bluez service. It > > > > > is also not where the current examples publish to. > > > > > Looking at the GattProfile1 documentation, it has service and object > > > > > as application dependant. > > > > > Service > > > > > Interface org.bluez.GattProfile1 > > > > > Object path > > > > > Should the documentation of Service on LEAdvertisement1 be freely > > > > > definable also? > > > > > > > > Yep, the bus name is up to the application which usually don't > > > > register a friendly name if you try to register with 'org.bluez' it > > > > would probably conflict with the daemon itself so you wouldn't be able > > > > to register that name anyway. > > > > > > > > > I have created the LEAdvertisement1 interface so that it has an > > > > > ObjectManager and is introspectable. When I pass the object to > > > > > RegisterAdvertisement on the org.bluez.LEAdvertisingManager1 interface > > > > > it accepts it (does not give an error) but does not register the data > > > > > and I see no advertisement appear. Is there somewhere I can find a > > > > > more detailed description of what needs to be on the > > > > > org.bluez.LEAdvertisement1 interface that will work with > > > > > RegisterAdvertisement? > > > > > > > > Do you have the bluetoothd output when you register, I get the > > > > following when using bluetoothctl: > > > > > > > > bluetooth]# power on > > > > Changing power on succeeded > > > > [bluetooth]# advertise on > > > > [CHG] Controller B8:8A:60:D8:17:D7 SupportedInstances: 0x04 > > > > [CHG] Controller B8:8A:60:D8:17:D7 ActiveInstances: 0x01 > > > > Advertising object registered > > > > Tx Power: off > > > > Name: off > > > > Apperance: off > > > > Discoverable: off > > > > [bluetooth]# > > > > > > Using the new dbus library I get: > > > Log from bluetoothctl: > > > [CHG] Controller FC:F8:AE:8F:0C:A4 SupportedInstances: 0x04 > > > [CHG] Controller FC:F8:AE:8F:0C:A4 ActiveInstances: 0x01 > > > > > > From the bluetoothd log: > > > bluetoothd[2856]: src/advertising.c:register_advertisement() > > > RegisterAdvertisement > > > bluetoothd[2856]: src/advertising.c:client_create() Adding proxy for > > > /ukBaz/bluezero/advertisement1 > > > bluetoothd[2856]: src/advertising.c:register_advertisement() > > > Registered advertisement at path /ukBaz/bluezero/advertisement1 > > > bluetoothd[2856]: src/advertising.c:refresh_adv() Refreshing > > > advertisement: /ukBaz/bluezero/advertisement1 > > > bluetoothd[2856]: src/advertising.c:add_adv_callback() Advertisement > > > registered: /ukBaz/bluezero/advertisement1 > > > > > > > > > With the old pyton-dbus library (that is working) I get: > > > log from bluetoothctl: > > > [CHG] Controller FC:F8:AE:8F:0C:A4 SupportedInstances: 0x04 > > > [CHG] Controller FC:F8:AE:8F:0C:A4 ActiveInstances: 0x01 > > > > > > From the bluetoothd log: > > > bluetoothd[2856]: src/advertising.c:register_advertisement() > > > RegisterAdvertisement > > > bluetoothd[2856]: src/advertising.c:client_create() Adding proxy for > > > /ukBaz/bluezero/advertisement0001 > > > bluetoothd[2856]: src/advertising.c:register_advertisement() > > > Registered advertisement at path /ukBaz/bluezero/advertisement0001 > > > bluetoothd[2856]: src/advertising.c:parse_service_uuids() Adding > > > ServiceUUID: FEAA > > > bluetoothd[2856]: src/advertising.c:parse_service_data() Adding > > > ServiceData for FEAA > > > bluetoothd[2856]: src/advertising.c:refresh_adv() Refreshing > > > advertisement: /ukBaz/bluezero/advertisement0001 > > > bluetoothd[2856]: src/advertising.c:add_adv_callback() Advertisement > > > registered: /ukBaz/bluezero/advertisement0001 > > > > > > > > > > > > > > bluetoothd[6103]: src/advertising.c:client_create() Adding proxy for > > > > /org/bluez/advertising > > > > bluetoothd[6103]: src/advertising.c:register_advertisement() > > > > Registered advertisement at path /org/bluez/advertising > > > > bluetoothd[6103]: src/advertising.c:refresh_adv() Refreshing > > > > advertisement: /org/bluez/advertising > > > > bluetoothd[6103]: src/advertising.c:add_adv_callback() Advertisement > > > > registered: /org/bluez/advertising > > > > > > > > > > > > > For reference, I have put below what I am currently putting on the > > > > > org.bluez.LEAdvertisement1 interface. > > > > > > > > > > Thanks, > > > > > Barry > > > > > > > > > > > > > > > $ busctl call ukBaz.bluezero /ukBaz/bluezero/advertisement1 > > > > > org.freedesktop.DBus.ObjectManager GetManagedObjects > > > > > a{oa{sa{sv}}} 1 "/ukBaz/bluezero/advertisement1" 5 > > > > > "org.freedesktop.DBus.Properties" 0 > > > > > "org.freedesktop.DBus.Introspectable" 0 "org.freedesktop.DBus.Peer" 0 > > > > > "org.freedesktop.DBus.ObjectManager" 0 "org.bluez.LEAdvertisement1" 6 > > > > > "Type" s "broadcast" "ServiceUUIDs" as 0 "ManufacturerData" a{sv} 0 > > > > > "SolicitUUIDs" as 0 "ServiceData" a{sv} 1 "FEAA" ay 18 16 8 3 117 107 > > > > > 66 97 122 46 103 105 116 104 117 98 46 105 111 "IncludeTxPower" b > > > > > false > > > > > > > > Not sure if that is the problem but usually ObjectManager is suppose > > > > to be on the '/' (root) path. > > > > > > Good point. It is not clear (to me anyway) exactly what the > > > requirement is from reading the spec > > > https://dbus.freedesktop.org/doc/dbus-specification.html#standard-interfaces-objectmanager > > > I have moved the object manager to the root (/) but this does not seem > > > to have changed anything. > > > > > > $ busctl call ukBaz.bluezero / org.freedesktop.DBus.ObjectManager > > > GetManagedObjects > > > a{oa{sa{sv}}} 1 "/ukBaz/bluezero/advertisement1" 4 > > > "org.freedesktop.DBus.Properties" 0 > > > "org.freedesktop.DBus.Introspectable" 0 "org.freedesktop.DBus.Peer" 0 > > > "org.bluez.LEAdvertisement1" 6 "Type" s "broadcast" "ServiceUUIDs" as > > > 0 "ManufacturerData" a{sv} 0 "SolicitUUIDs" as 0 "ServiceData" a{sv} 1 > > > "FEAA" ay 18 16 8 3 117 107 66 97 122 46 103 105 116 104 117 98 46 105 > > > 111 "IncludeTxPower" b false > > > > > > > > > > > > > > > $ busctl call ukBaz.bluezero /ukBaz/bluezero/advertisement1 > > > > > org.freedesktop.DBus.Properties GetAll s org.bluez.LEAdvertisement1 > > > > > a{sv} 6 "Type" s "broadcast" "ServiceUUIDs" as 0 "ManufacturerData" > > > > > a{sv} 0 "SolicitUUIDs" as 0 "ServiceData" a{sv} 1 "FEAA" ay 18 16 8 3 > > > > > 117 107 66 97 122 46 103 105 116 104 117 98 46 105 111 > > > > > "IncludeTxPower" b false > > > > > > > > > > > Using the d-feet application I did a GetAll on the advertisements and > > > the data looks identical for both > > > Using the new DBus library: > > > {'IncludeTxPower': False, > > > 'ManufacturerData': {}, > > > 'ServiceData': {'FEAA': [16, > > > 8, > > > 3, > > > 117, > > > 107, > > > 66, > > > 97, > > > 122, > > > 46, > > > 103, > > > 105, > > > 116, > > > 104, > > > 117, > > > 98, > > > 46, > > > 105, > > > 111]}, > > > 'ServiceUUIDs': ['FEAA'], > > > 'SolicitUUIDs': [], > > > 'Type': 'broadcast'} > > > > > > Using the old Python-dbus library: > > > {'IncludeTxPower': False, > > > 'ServiceData': {'FEAA': [16, > > > 8, > > > 3, > > > 117, > > > 107, > > > 66, > > > 97, > > > 122, > > > 46, > > > 103, > > > 105, > > > 116, > > > 104, > > > 117, > > > 98, > > > 46, > > > 105, > > > 111]}, > > > 'ServiceUUIDs': ['FEAA'], > > > 'Type': 'broadcast'} > > > > > > > > $ busctl call ukBaz.bluezero /ukBaz/bluezero/advertisement1 > > > > > org.freedesktop.DBus.Introspectable Introspect > > > > > s " > > > > Introspection 1.0//EN\"\n > > > > > \"http://www.freedesktop.org/standards/dbus/1.0/introspect.dtd\">\n\n\n > > > > name=\"org.freedesktop.DBus.Properties\">\n \n > > > > > \n > > > > > \n > > > > type=\"v\" name=\"value\" direction=\"out\"/>\n \n > > > > > \n > > > > name=\"interface_name\" direction=\"in\"/>\n > > > > name=\"properties\" direction=\"out\"/>\n \n > > > > name=\"Set\">\n > > > > direction=\"in\"/>\n > > > > direction=\"in\"/>\n > > > > direction=\"in\"/>\n \n > > > > name=\"PropertiesChanged\">\n > > > > name=\"interface_name\"/>\n > > > > name=\"changed_properties\"/>\n > > > > name=\"invalidated_properties\"/>\n \n \n > > > > > \n > > > > name=\"Introspect\">\n > > > > direction=\"out\"/>\n \n \n > > > > name=\"org.freedesktop.DBus.Peer\">\n \n > > > > > \n > > > > name=\"machine_uuid\" direction=\"out\"/>\n \n > > > > > \n > > > > name=\"org.freedesktop.DBus.ObjectManager\">\n > > > > name=\"GetManagedObjects\">\n > > > > name=\"object_paths_interfaces_and_properties\" direction=\"out\">\n > > > > > \n \n \n > > > > > \n \n > > > > type=\"a{sa{sv}}\" name=\"interfaces_and_properties\">\n \n > > > > > \n \n > > > > type=\"o\" name=\"object_path\">\n \n > > > > name=\"interfaces\">\n \n \n \n > > > > > \n > > > > name=\"org.freedesktop.DBus.Properties.PropertiesChanged\" > > > > > value=\"const\">\n \n \n > > > > > > > > > value=\"true\">\n \n \n > > > > type=\"s\" name=\"Type\" access=\"read\">\n \n > > > > > \n > > > > > \n > > > > access=\"read\">\n \n > > > > name=\"SolicitUUIDs\" access=\"read\">\n \n > > > > type=\"a{sv}\" name=\"ServiceData\" access=\"read\">\n > > > > > \n > > > > access=\"read\">\n \n \n\n" > > > > > > > > > > > > > > > > -- > > > > Luiz Augusto von Dentz -- Luiz Augusto von Dentz