From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
To: "Singh, AmitX K" <amitx.k.singh@intel.com>
Cc: "linux-bluetooth@vger.kernel.org"
<linux-bluetooth@vger.kernel.org>,
"Panda, Bharat B" <bharat.b.panda@intel.com>
Subject: Re: [PATCH 1/2] bluez:load Generic access service
Date: Thu, 16 Jul 2020 09:22:52 -0700 [thread overview]
Message-ID: <CABBYNZL7h5vVs_31FuM5GWRCDPyk3gJm30aLCT4xropac4kDqw@mail.gmail.com> (raw)
In-Reply-To: <DM6PR11MB3369DA18BE2A012A64A8637BB67F0@DM6PR11MB3369.namprd11.prod.outlook.com>
Hi Amit,
On Thu, Jul 16, 2020 at 1:40 AM Singh, AmitX K <amitx.k.singh@intel.com> wrote:
>
> Hi Luiz,
>
> > -----Original Message-----
> > From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
> > Sent: Friday, June 5, 2020 10:34 PM
> > To: Singh, AmitX K <amitx.k.singh@intel.com>
> > Cc: linux-bluetooth@vger.kernel.org
> > Subject: Re: [PATCH 1/2] bluez:load Generic access service
> >
> > Hi Amit,
> >
> > On Fri, Jun 5, 2020 at 7:31 AM Amitsi5x <amitx.k.singh@intel.com> wrote:
> > >
> > > From: “AmitSingh” <amitx.k.singh@intel.com>
> > >
> > > It allow to load generic access service to database
> > >
> > > Signed-off-by: “AmitSingh” <amitx.k.singh@intel.com>
> > > ---
> > > src/gatt-client.c | 3 ---
> > > 1 file changed, 3 deletions(-)
> > >
> > > diff --git a/src/gatt-client.c b/src/gatt-client.c index
> > > 20c3fbec2..2ae258da0 100644
> > > --- a/src/gatt-client.c
> > > +++ b/src/gatt-client.c
> > > @@ -2009,9 +2009,6 @@ static void export_service(struct
> > gatt_db_attribute *attr, void *user_data)
> > > struct btd_gatt_client *client = user_data;
> > > struct service *service;
> > >
> > > - if (gatt_db_service_get_claimed(attr))
> > > - return;
> > > -
> >
> > This is actually done on purpose in order to avoid extra traffic since the
> > daemon already exposes this information in other interfaces.
> >
>
> GAP service is not getting stored is hash database .To verify the PTS test case GATT/CL/GAD/BV-02-C which is GAP service discovery with '1800' UUID, verdicts as "INCONCLUSIVE" as it does not find the GAP UUID in place
BlueZ does perform the so-called discover all service procedure,
perhaps you need to select the procedure correctly in order to pass
this test.
> > > service = service_create(attr, client);
> > > if (!service)
> > > return;
> > > --
> > > 2.17.1
> >
> > --
> > Luiz Augusto von Dentz
--
Luiz Augusto von Dentz
next prev parent reply other threads:[~2020-07-16 16:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-05 14:25 [PATCH] bluetoothctl: Add support for discover characteristic by uuid Amitsi5x
2020-06-05 14:25 ` [PATCH] bluetoothctl:Add support for discover service " Amitsi5x
2020-06-05 14:25 ` [PATCH] bluetoothctl:Add support for read characteristics value Amitsi5x
2020-06-05 17:02 ` Luiz Augusto von Dentz
2020-07-16 8:40 ` Singh, AmitX K
2020-06-05 14:25 ` [PATCH 1/2] bluez:load Generic access service Amitsi5x
2020-06-05 17:03 ` Luiz Augusto von Dentz
2020-07-16 8:39 ` Singh, AmitX K
2020-07-16 16:22 ` Luiz Augusto von Dentz [this message]
2020-06-05 14:25 ` [PATCH] bluez:update handle for large database Amitsi5x
2020-06-05 14:36 ` bluez.test.bot
2020-06-05 17:16 ` [PATCH] " Luiz Augusto von Dentz
2020-07-16 8:40 ` Singh, AmitX K
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABBYNZL7h5vVs_31FuM5GWRCDPyk3gJm30aLCT4xropac4kDqw@mail.gmail.com \
--to=luiz.dentz@gmail.com \
--cc=amitx.k.singh@intel.com \
--cc=bharat.b.panda@intel.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).