From: Jon Nettleton <jon@solid-run.com>
To: Andreas Kemnade <andreas@kemnade.info>
Cc: Marcel Holtmann <marcel@holtmann.org>,
Rob Herring <robh@kernel.org>,
Sebastian Reichel <sebastian.reichel@collabora.com>,
"H . Nikolaus Schaller" <hns@goldelico.com>,
devicetree <devicetree@vger.kernel.org>,
Johan Hedberg <johan.hedberg@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-bluetooth@vger.kernel.org, letux-kernel@openphoenux.org
Subject: Re: [Letux-kernel] [PATCH RFC] bluetooth: add uart h4 devices via serdev/devicetree
Date: Sat, 12 Jan 2019 12:16:49 +0100 [thread overview]
Message-ID: <CABdtJHuHrp6iPEWaCJ1_dMg0reED8ScKTjnW9aRa2JvMnHtH_A@mail.gmail.com> (raw)
In-Reply-To: <20190104205600.3e6b31c9@aktux>
On Fri, Jan 4, 2019 at 8:57 PM Andreas Kemnade <andreas@kemnade.info> wrote:
>
> Hi Marcel,
>
> On Fri, 4 Jan 2019 10:07:34 +0100
> Marcel Holtmann <marcel@holtmann.org> wrote:
>
> > Hi Andreas,
> >
> > >>>> Btw. I see nothing standing in the way of merging btuart.c driver and then go from there. Either I dig this out and submit or someone else does.
> > >>>>
> > >>> Do you mean this?
> > >>> https://patchwork.kernel.org/patch/10490651/
> > >>
> > >> yes, that one.
> > >>
> > > Hmm, there seemed to be nothing in the pull requests regarding btuart.
> > > Did you change plans?
> >
> > because I only submitted it as RFC. We can easily merge that one upstream since it is rather trivial. The main problem is how you want to do the device matching. Do you have a DT entry for your really simple devices?
> >
> Hmm, in that link it is non-rfc. So someone picked you rfc patch up and
> submitted it?
>
> You might see what we are already doing here:
> http://git.goldelico.com/?p=letux-kernel.git;a=blobdiff;f=arch/arm/boot/dts/omap3-gta04.dtsi;h=4d2bac4293938de4a15a59979616909cf8842524;hp=bfced960d63ec40cf9db4901374b331737a9a168;hb=f78bf51754e35010de40518b9a8a148d0269bbc8;hpb=b6805813a9ab5b0d66b44cc54a0059eca4dd0a98
>
> We are using compatible = "wi2wi,w2cbw003-bluetooth"
>
> But I think we should also add a generic device string like
> bluetooth,h4
> So if people dig out older hardware, they can just add that to their
> device trees and have bluetooth
>
> The full patchset we are currently using is here:
> http://git.goldelico.com/?p=letux-kernel.git;a=shortlog;h=refs/heads/letux/bluetooth-h4-serdev
>
> Regards,
> Andreas
Good timing for this thread. I have just integrated the mynewt blehci
firmware for the nina-b1 chip integrated onto our SOM. This is
exactly the functionality I need in the kernel to make the
initialization seamless. A generic device string is exactly what
would be needed for most devices that are running in this
configuration. We may also want to have a generic reset_gpio handler.
-Jon
next prev parent reply other threads:[~2019-01-12 11:20 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-10 23:20 [PATCH RFC] bluetooth: add uart h4 devices via serdev/devicetree Andreas Kemnade
2018-11-11 2:46 ` Sebastian Reichel
2018-11-12 20:59 ` Andreas Kemnade
2018-11-12 21:19 ` [Letux-kernel] " H. Nikolaus Schaller
2018-11-12 22:27 ` Sebastian Reichel
2018-11-13 0:17 ` Rob Herring
2018-11-13 16:01 ` Andreas Kemnade
2018-11-14 7:51 ` Marcel Holtmann
2018-11-14 11:13 ` Andreas Kemnade
2018-11-16 19:46 ` Andreas Kemnade
2018-11-16 19:58 ` Marcel Holtmann
2019-01-04 5:44 ` Andreas Kemnade
2019-01-04 9:07 ` Marcel Holtmann
2019-01-04 19:57 ` Andreas Kemnade
2019-01-12 11:16 ` Jon Nettleton [this message]
2019-01-12 12:15 ` H. Nikolaus Schaller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABdtJHuHrp6iPEWaCJ1_dMg0reED8ScKTjnW9aRa2JvMnHtH_A@mail.gmail.com \
--to=jon@solid-run.com \
--cc=andreas@kemnade.info \
--cc=devicetree@vger.kernel.org \
--cc=hns@goldelico.com \
--cc=johan.hedberg@gmail.com \
--cc=letux-kernel@openphoenux.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=robh@kernel.org \
--cc=sebastian.reichel@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).