From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38837C433EF for ; Tue, 10 May 2022 03:17:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235290AbiEJDV1 (ORCPT ); Mon, 9 May 2022 23:21:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36216 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235283AbiEJDVY (ORCPT ); Mon, 9 May 2022 23:21:24 -0400 Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com [IPv6:2a00:1450:4864:20::129]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BD57615828 for ; Mon, 9 May 2022 20:17:26 -0700 (PDT) Received: by mail-lf1-x129.google.com with SMTP id w19so27013964lfu.11 for ; Mon, 09 May 2022 20:17:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=Ls/SMjFj6heZoySKcqmoqFtaszIPQaljVTG5Re0rH9M=; b=EB1ROIutBjcQZmj6LJr9SUFDRILRUz/dzhbYK+KW34P/HGB5VYjQOYia914IABPKHm ZB2rJYgCDwhzeTK1YSlNZCVpAtHmbUntOvkPoj0MeZhIc5THiAljwEScvUbZU5unm1E0 78ioKS9u3eFHR3yEy1e3LjpgEBGiS3yUMMS3M= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Ls/SMjFj6heZoySKcqmoqFtaszIPQaljVTG5Re0rH9M=; b=zGUzzxB8TLwV37xJNWjkFIgJTH9VVCFMzeBwGFgtstsVLS5fXwkZVohSgbYopjNx3N dEGGZeoaDrFD6UvRr3JAS25AG20tOmCGR6QHOkVPQo3yKkcNd267V28dgpwKw37mUOL3 zhMiLtngGK9DmZuNr8KfMuWvPhrp1le9dQ87mt0ynw9zSyjYpmzpNzIbsJri2yVMl+SG DMEalUX/aQq/8lWdcrmtDfc319InP7wMioEuIqjQug4hQeLAPPCueMNYI5/eu8YeTMiS 6HRhO0luYGhcL6eQtkrXJ+VquD7EjThesnyInF3fkGe6eYQms6WtBDvvzMjbPVhmTPsW gXhQ== X-Gm-Message-State: AOAM5301umYDSuG0THMPHW9bQzmAyVGV/AJi9OHH9luen6XvbzWqKMFI wBtfatme8K+atOgEvN4paZRzWzR3iS3g4JhOChZstg== X-Google-Smtp-Source: ABdhPJw1K7QAlE5QAiZCLMLRs+tK1ZtQMIflSjgCESXPl/YsTyscWXUV+ShFFygPmv2BiT+hQUxJJ2+IPMYpxQps+Qk= X-Received: by 2002:a05:6512:3f86:b0:44a:f5bf:ec9a with SMTP id x6-20020a0565123f8600b0044af5bfec9amr15376918lfa.490.1652152645011; Mon, 09 May 2022 20:17:25 -0700 (PDT) MIME-Version: 1.0 References: <1651228073-1999-1-git-send-email-quic_bgodavar@quicinc.com> <1651228073-1999-4-git-send-email-quic_bgodavar@quicinc.com> <0D3D8346-0F64-4CAF-8BED-940F189A3E97@holtmann.org> In-Reply-To: From: Miao-chen Chou Date: Mon, 9 May 2022 20:17:13 -0700 Message-ID: Subject: Re: [PATCH v1 3/3] Bluetooth: hci_qca: WAR to handle WCN6750 HW issue To: "Balakrishna Godavarthi (QUIC)" Cc: Marcel Holtmann , Andy Gross , "robh+dt@kernel.org" , "bjorn.andersson@linaro.org" , "linux-arm-msm@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Johan Hedberg , "mka@chromium.org" , "linux-bluetooth@vger.kernel.org" , "Hemant Gupta (QUIC)" , "Sai Teja Aluvala (Temp) (QUIC)" , quic_rjliao , Alain Michaud , Abhishek Pandit-Subedi Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org Hi Bala, When is the estimated start date and timeline of the driver development? Thanks, Miao On Fri, Apr 29, 2022 at 8:09 PM Balakrishna Godavarthi (QUIC) wrote: > > Hi Marcel, > > -----Original Message----- > From: Marcel Holtmann > Sent: Friday, April 29, 2022 8:24 PM > To: Balakrishna Godavarthi (QUIC) > Cc: Andy Gross ; robh+dt@kernel.org; bjorn.andersson@l= inaro.org; linux-arm-msm@vger.kernel.org; devicetree@vger.kernel.org; linux= -kernel@vger.kernel.org; Johan Hedberg ; mka@chrom= ium.org; linux-bluetooth@vger.kernel.org; Hemant Gupta (QUIC) ; Sai Teja Aluvala (Temp) (QUIC) ; = quic_rjliao ; mcchou@chromium.org > Subject: Re: [PATCH v1 3/3] Bluetooth: hci_qca: WAR to handle WCN6750 HW = issue > > Hi Balakrishna, > > > The patch is workaround for hardware issue on WCN6750. > > On WCN6750 sometimes observed AON power source takes 100ms time to > > fully discharge voltage during OFF. As WCN6750 is combo chip for WLAN > > and BT. If any of the tech area ON is triggered during discharge > > phase, it fails to turn ON. > > To overcome this hardware issue, During BT ON, driver check for > > WLAN_EN pin status. If it high, it will pull BT_EN to high immediately > > else it will wait for 100ms assuming WLAN was just powered OFF and > > then BT_EN will be pulled to high. > > > > Fixes: d8f97da1b92d2 ("Bluetooth: hci_qca: Add support for QTI > > Bluetooth chip wcn6750") > > Reviewed-by: Miao-chen Chou > > Signed-off-by: Sai Teja Aluvala > > Signed-off-by: Balakrishna Godavarthi > > --- > > drivers/bluetooth/hci_qca.c | 30 ++++++++++++++++++++++++------ > > 1 file changed, 24 insertions(+), 6 deletions(-) > > > > diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c > > index eab34e2..c3862d1 100644 > > --- a/drivers/bluetooth/hci_qca.c > > +++ b/drivers/bluetooth/hci_qca.c > > @@ -219,6 +219,7 @@ struct qca_serdev { > > struct hci_uart serdev_hu; > > struct gpio_desc *bt_en; > > struct gpio_desc *sw_ctrl; > > + struct gpio_desc *wlan_en; > > struct clk *susclk; > > enum qca_btsoc_type btsoc_type; > > struct qca_power *bt_power; > > I am really against these intermixing of Bluetooth and WiFi details. Ther= e is work ongoing to do some sequence power procedure. Maybe that is someth= ing you should look into. This is a mess. > > And again, we are still hacking around hci_qca.c instead of writing a cle= an serdev only driver for this hardware. I have the feeling that nobody lis= tens to review comments these days. It is just hacking patches together to = get hardware enabled somehow and then disappear. > > [Bala]: We are working on serdev like driver for our QCA platform. We ar= e in initial stages of discussion, and soon we will start the driver develo= pment work. > In mean to stop stability or functional issues we are trying to add these= HACKs in QCA driver. > > Regards > > Marcel >