From: Dmitry Vyukov <dvyukov@google.com>
To: Stefano Brivio <sbrivio@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
syzbot <syzbot+660883c56e2fa65d4497@syzkaller.appspotmail.com>,
David Miller <davem@davemloft.net>,
Johan Hedberg <johan.hedberg@gmail.com>,
linux-bluetooth <linux-bluetooth@vger.kernel.org>,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
Linux List Kernel Mailing <linux-kernel@vger.kernel.org>,
Marcel Holtmann <marcel@holtmann.org>,
Michal Marek <mmarek@suse.com>, Netdev <netdev@vger.kernel.org>,
syzkaller-bugs <syzkaller-bugs@googlegroups.com>
Subject: Re: KASAN: slab-out-of-bounds Read in bacpy
Date: Mon, 18 Mar 2019 14:00:05 +0100 [thread overview]
Message-ID: <CACT4Y+bo1PC_fBHy1wtkfhtaY1Au9CwLtQphbsHDA24Xx7o+-g@mail.gmail.com> (raw)
In-Reply-To: <20190317202455.32a334d1@elisabeth>
On Sun, Mar 17, 2019 at 8:25 PM Stefano Brivio <sbrivio@redhat.com> wrote:
>
> On Sun, 17 Mar 2019 18:11:49 +0100
> Dmitry Vyukov <dvyukov@google.com> wrote:
>
> > And in this case it seems to be working as intended bisecting it to a
> > release tag.
>
> I guess what went wrong here is that it had to skip quite a few
> commits, and the result isn't relevant anymore. Maybe you could improve
> this by handling a:
>
> all runs: boot failed: can't ssh into the instance
>
> case as bad revision? And, also, if scp times out (as it did on
> 912964eacb11), keep retrying instead of marking the revision as good?
Skipping revisions does not make the result wrong. In the worst case
git bisect will point to a range of commits.
But marking non-building/booting revisions as bad can actually diverge
bisection in the wrong direction and will result in pointing to
completely irrelevant commits. git skip is meant exactly for such
cases.
And in this case, skipping did not affect the process, it just needed
to do few more additional steps.
next prev parent reply other threads:[~2019-03-18 13:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-07 13:31 KASAN: slab-out-of-bounds Read in bacpy syzbot
2019-03-17 10:43 ` syzbot
2019-03-17 16:35 ` Linus Torvalds
2019-03-17 17:11 ` Dmitry Vyukov
2019-03-17 19:24 ` Stefano Brivio
2019-03-18 13:00 ` Dmitry Vyukov [this message]
2019-03-17 20:41 ` Linus Torvalds
2019-03-19 13:27 ` Dmitry Vyukov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACT4Y+bo1PC_fBHy1wtkfhtaY1Au9CwLtQphbsHDA24Xx7o+-g@mail.gmail.com \
--to=dvyukov@google.com \
--cc=davem@davemloft.net \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=mmarek@suse.com \
--cc=netdev@vger.kernel.org \
--cc=sbrivio@redhat.com \
--cc=syzbot+660883c56e2fa65d4497@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).