linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Missing error handling in the RegisterAdvertisement
@ 2019-08-14  5:07 Rafał Miłecki
  0 siblings, 0 replies; only message in thread
From: Rafał Miłecki @ 2019-08-14  5:07 UTC (permalink / raw)
  To: linux-bluetooth; +Cc: Szymon Janc

I noticed that RegisterAdvertisement calls may succeed while internally failing.

Example of *logged* error:
daemon.err bluetoothd[1104]: Failed to add advertisement: Busy (0x0a)
(I'm still debugging that).

Forward-trace to consider:
register_advertisement()
client_create()
client_proxy_added()
parse_advertisement()
add_adv_callback()
add_client_complete()

Explanation:
add_client_complete() may fail and:
1) It doesn't propagate error up
2) Its reply sent using g_dbus_send_message doesn't reach caller

Could someone look at this problem and see if/how it can be fixed,
please? I don't have required BlueZ knowledge & experience to fix
this.

-- 
Rafał

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2019-08-14  5:07 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-14  5:07 Missing error handling in the RegisterAdvertisement Rafał Miłecki

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).