From: "Von Dentz, Luiz" <luiz.von.dentz@intel.com>
To: Arnaud Mouiche <arnaud.mouiche@invoxia.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: Bug: no PropertiesChanged signal for org.bluez.Device1.AdvertisingData
Date: Tue, 8 Jan 2019 13:12:21 -0300 [thread overview]
Message-ID: <CACumGOJrN1LFBb6uuH1T92eirzQyUMuai1qQ8SeipzJb=bvHUg@mail.gmail.com> (raw)
In-Reply-To: <c23a8986-5654-275c-26a8-9f9a4bf5d005@invoxia.com>
Hi Arnaud,
On Tue, Jan 8, 2019 at 1:03 PM Arnaud Mouiche
<arnaud.mouiche@invoxia.com> wrote:
>
> Hello Luiz,
>
> I was playing with latest sources (git) and experimental features
> enabled in order to:
> - perform a BLE scan
> - find AdvertisingData (in particularly the BT_AD_INDOOR_POSITIONING (0x25))
>
> I found that:
> - once scanning is done org.bluez.Device1.AdvertisingData is correctly
> set to the expected value (the one advertised)
> - yet, there was no PropertiesChanged signal corresponding to this
> AdvertisingData property update (despite I received PropertiesChanged
> for RSSI)
Is the Data changing? If you want to get informed of each
advertisement regardless if it has changed you should set
DuplicateData filter:
https://git.kernel.org/pub/scm/bluetooth/bluez.git/tree/doc/adapter-api.txt#n107
If that doesn't work then perhaps we have a bug somewhere.
>
> Indeed src/device.c:: add_data() performs a particular filtering to only
> signal EIR_TRANSPORT_DISCOVERY data.
>
> > static void add_data(void *data, void *user_data)
> > {
> > struct eir_ad *ad = data;
> > struct btd_device *dev = user_data;
> >
> > if (!bt_ad_add_data(dev->ad, ad->type, ad->data, ad->len))
> > return;
> >
> > if (ad->type == EIR_TRANSPORT_DISCOVERY)
> > g_dbus_emit_property_changed(dbus_conn, dev->path,
> > DEVICE_INTERFACE,
> > "AdvertisingData");
> > }
>
> Is there a particular reason for this behavior ?
If I recall this is not to spam the bus if we are not actively discovery.
> Regards,
> Arnaud
>
next prev parent reply other threads:[~2019-01-08 16:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-08 16:03 Bug: no PropertiesChanged signal for org.bluez.Device1.AdvertisingData Arnaud Mouiche
2019-01-08 16:12 ` Von Dentz, Luiz [this message]
2019-01-08 19:00 ` Arnaud Mouiche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACumGOJrN1LFBb6uuH1T92eirzQyUMuai1qQ8SeipzJb=bvHUg@mail.gmail.com' \
--to=luiz.von.dentz@intel.com \
--cc=arnaud.mouiche@invoxia.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).