From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2B92C004C9 for ; Tue, 7 May 2019 18:34:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BFAA520656 for ; Tue, 7 May 2019 18:34:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pjoBF6a4" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726998AbfEGSeN (ORCPT ); Tue, 7 May 2019 14:34:13 -0400 Received: from mail-it1-f195.google.com ([209.85.166.195]:36778 "EHLO mail-it1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726321AbfEGSeN (ORCPT ); Tue, 7 May 2019 14:34:13 -0400 Received: by mail-it1-f195.google.com with SMTP id o190so10273655itc.1; Tue, 07 May 2019 11:34:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=QIrhxyWiqFLlv04t3f7X/mtQ4tf6UfeG2TYcF2JwlXY=; b=pjoBF6a4Q6Ub8JMvdzsZrQyoFcTlZ0QnL9qCEGTfKb2i8V3btiyJEXvGfHAmGIRqjF OVYF0VxXOP1cUEcPcfUMOX/I+imGnibEKAi9IMNiOKhIlCute8IP982Lc1MVTAUC2vLT jScGNrrMXpqDXp+QSrYMGD+fjNTXBEP0+RPMoVoZ/iKtLmETRxyQu5SbKEe5HmrMFp/Z KbOg8pN+HAsZloOefydXm8rP+ZzlUTXw9Tlpj9y6uYTRTD6Z7FSUYC0fDR0Atj3LrZ4T oybbolrBb/F4acxi7zXlAFuxFm9dR0Dtc6rCsM6u46ChCGPIC9F5XFV7Rfr8ButzA44f S8cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=QIrhxyWiqFLlv04t3f7X/mtQ4tf6UfeG2TYcF2JwlXY=; b=T/AzFMyAmjb5yd2nKgoRRcqTf/4hX4kZwF/DhT+hKCFIQ6xSO4mJfUXf0HSj0y1KwM 6hZnoDgtVvdraTiUsRfon0dlyKzfNRoJzml57t5n+s2IVC18vxmqmlHyYJ7lFh3FWWUM NOhSbykWpXn8ptBxGLPm4mMLv0+XZ1VUHGh+XHeueKXq+Ep8GDDCFGw4qS3czHAze1Ox po2F36djt+HH+2qhFG0SZ5w65iycgWqj2QHso4iKOwA3qMYUr/EUKkdfuoPkt2QoqFEr iT4TO+ZEl9X9D1/EiPfkU2SX6iExvixEB/yITDu/W2aits4VtgkFPx9Hk4GbNy5Dh3an l/uQ== X-Gm-Message-State: APjAAAVgiFTbHElPUuDqAHsE7Np4LXi0dQIQh848OEY3kspSpNSRSi6Y oaqJ0CaUZ2mo6c2ZU/tFWnIuL56PLsPwc6D4/X0= X-Google-Smtp-Source: APXvYqy7s3OKaplH/meVfz6njNmIOHc+o+Y6Nqnu4mDw+TdEAlz+JpycLdgqDiTQ3/xgs6huAKOSQkHPH+jyQFyQLuc= X-Received: by 2002:a24:c455:: with SMTP id v82mr25395058itf.143.1557254051755; Tue, 07 May 2019 11:34:11 -0700 (PDT) MIME-Version: 1.0 References: <20181221011752.25627-1-sre@kernel.org> <4f47f7f2-3abb-856c-4db5-675caf8057c7@xs4all.nl> <20190319133154.7tbfafy7pguzw2tk@earth.universe> In-Reply-To: From: Adam Ford Date: Tue, 7 May 2019 13:34:00 -0500 Message-ID: Subject: Re: [PATCH 00/14] Add support for FM radio in hcill and kill TI_ST To: Sebastian Reichel Cc: Hans Verkuil , Mauro Carvalho Chehab , Marcel Holtmann , Tony Lindgren , Rob Herring , Greg Kroah-Hartman , Pavel Machek , "open list:BLUETOOTH DRIVERS" , linux-media@vger.kernel.org, Linux-OMAP , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-bluetooth-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org On Tue, May 7, 2019 at 12:26 PM Adam Ford wrote: > > On Tue, Mar 19, 2019 at 8:33 AM Sebastian Reichel wrote: > > > > Hi Hans, > > > > On Thu, Mar 14, 2019 at 09:20:10AM +0100, Hans Verkuil wrote: > > > On 12/21/18 2:17 AM, Sebastian Reichel wrote: > > > > This moves all remaining users of the legacy TI_ST driver to hcill (patches > > > > 1-3). Then patches 4-7 convert wl128x-radio driver to a standard platform > > > > device driver with support for multiple instances. Patch 7 will result in > > > > (userless) TI_ST driver no longer supporting radio at runtime. Patch 8-11 do > > > > some cleanups in the wl128x-radio driver. Finally patch 12 removes the TI_ST > > > > specific parts from wl128x-radio and adds the required infrastructure to use it > > > > with the serdev hcill driver instead. The remaining patches 13 and 14 remove > > > > the old TI_ST code. > > > > > > > > The new code has been tested on the Motorola Droid 4. For testing the audio > > > > should be configured to route Ext to Speaker or Headphone. Then you need to > > > > plug headphone, since its cable is used as antenna. For testing there is a > > > > 'radio' utility packages in Debian. When you start the utility you need to > > > > specify a frequency, since initial get_frequency returns an error: > > > > > > What is the status of this series? > > > > > > Based on some of the replies (from Adam Ford in particular) it appears that > > > this isn't ready to be merged, so is a v2 planned? > > > > Yes, a v2 is planned, but I'm super busy at the moment. I don't > > expect to send something for this merge window. Neither LogicPD > > nor IGEP use FM radio, so I can just remove FM support from the > > TI_ST framework. Converting those platforms to hci_ll can be done > > in a different patchset. > > > > If that was the only issue there would be a v2 already. But Marcel > > Holtmann suggested to pass the custom packet data through the BT > > subsystem, which is non-trivial (at least for me) :) > > I am running some tests today on the wl1283-st on the Logic PD Torpedo > board. Tony had suggested a few options, so I'm going to try those. > Looking at those today. If/when you have a V2, please CC me on it. If > it's been posted, can you send me a link? I would really like to see > the st-kim driver go away so I'd like to resolve the issues with the > torpedo board. I have run a bunch of tests on the 5.1 kernel. I am able to get the firmware to load now and the hci0 goes up. I was able to establish a BLE connection to a TI Sensor Tag and read and write data to it with good success on the wl1283. Unfortunately, when I tried to do some more extensive testing over classic Bluetooth, I got an error that repeats itself at seemingly random intervals: Bluetooth: hci0: Frame reassembly failed (-84) I can still scan and pair, but these Frame reassembly failed errors appear to come and go. Do we need to do anything to enable hardware handshaking? In the older st-kim driver, the pdata structure listed flow_cntrl=1. The i.MX boards use "uart-has-rtscts" in their device trees, but I don't see anything like that for the omap3-uart driver. I am not all that familiar with the Bluetooth subsystem, so I am not sure what would cause the Frame reassembly error. adam > > thanks > > adam > > > > -- Sebastian