From: Joseph Hwang <josephsih@google.com>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: linux-bluetooth <linux-bluetooth@vger.kernel.org>,
"Luiz Augusto von Dentz" <luiz.dentz@gmail.com>,
pali@kernel.org, chromeos-bluetooth-upstreaming@chromium.org,
"Miao-chen Chou" <mcchou@chromium.org>,
"Johan Hedberg" <johan.hedberg@gmail.com>,
linux-kernel@vger.kernel.org,
"Mark-YW Chen (陳揚文)" <Mark-YW.Chen@mediatek.com>
Subject: Re: [PATCH v6 3/3] Bluetooth: btusb: enable Mediatek to support AOSP extension
Date: Fri, 29 Oct 2021 16:08:23 +0800 [thread overview]
Message-ID: <CAHFy41_y8LS81gTHNidMdrD9tpeXf0YyvHaTKZJU+jmjuFgYXQ@mail.gmail.com> (raw)
In-Reply-To: <AB7796C2-6543-43CD-8FA3-DAF57AB68767@holtmann.org>
+Mark-YW.Chen@mediatek.com
Some of Mediatek's controllers/firmwares do NOT support AOSP extensions.
Please refer to this Gerrit patch review link for chrome os
(https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/3054233/8/drivers/bluetooth/btusb.c)
which was reviewed by Mark-YW Chen, Mediatek's engineer.
As an example, MediaTek MT7615E does not support the AOSP extensions.
That was why I used a new BTUSB_QUALITY_REPORT flag in the changes v4
and earlier ones.
Please let me know how you would like to proceed with this patch.
Thanks!
Joseph
On Mon, Oct 25, 2021 at 9:26 PM Marcel Holtmann <marcel@holtmann.org> wrote:
>
> Hi Joseph,
>
> > This patch enables Mediatek to support the AOSP extension.
> >
> > Reviewed-by: Miao-chen Chou <mcchou@chromium.org>
> > Signed-off-by: Joseph Hwang <josephsih@chromium.org>
> >
> > ---
> >
> > (no changes since v5)
> >
> > Changes in v5:
> > - Let the vendor command in aosp_do_open() to determine what
> > capabilities are supported.
> >
> > Changes in v4:
> > - Call hci_set_aosp_capable in the driver.
> > - This patch is added in this Series-changes 4.
> >
> > drivers/bluetooth/btusb.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
> > index 87b71740fad8..00311ebd7823 100644
> > --- a/drivers/bluetooth/btusb.c
> > +++ b/drivers/bluetooth/btusb.c
> > @@ -3876,6 +3876,8 @@ static int btusb_probe(struct usb_interface *intf,
> > hdev->set_bdaddr = btusb_set_bdaddr_mtk;
> > set_bit(HCI_QUIRK_NON_PERSISTENT_SETUP, &hdev->quirks);
> > data->recv_acl = btusb_recv_acl_mtk;
> > +
> > + hci_set_aosp_capable(hdev);
>
> can we get an ACK from Mediatek people that all their firmwares support the AOSP extensions.
>
> Regards
>
> Marcel
>
--
Joseph Shyh-In Hwang
Email: josephsih@google.com
next prev parent reply other threads:[~2021-10-29 8:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-21 15:04 [PATCH v6 1/3] Bluetooth: Add struct of reading AOSP vendor capabilities Joseph Hwang
2021-10-21 15:04 ` [PATCH v6 2/3] Bluetooth: aosp: Support AOSP Bluetooth Quality Report Joseph Hwang
2021-10-25 13:24 ` Marcel Holtmann
2021-10-21 15:04 ` [PATCH v6 3/3] Bluetooth: btusb: enable Mediatek to support AOSP extension Joseph Hwang
2021-10-25 13:26 ` Marcel Holtmann
2021-10-29 8:08 ` Joseph Hwang [this message]
2021-10-29 8:21 ` Marcel Holtmann
2021-10-29 14:12 ` Joseph Hwang
2021-10-21 16:43 ` [v6,1/3] Bluetooth: Add struct of reading AOSP vendor capabilities bluez.test.bot
2021-10-25 13:18 ` [PATCH v6 1/3] " Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHFy41_y8LS81gTHNidMdrD9tpeXf0YyvHaTKZJU+jmjuFgYXQ@mail.gmail.com \
--to=josephsih@google.com \
--cc=Mark-YW.Chen@mediatek.com \
--cc=chromeos-bluetooth-upstreaming@chromium.org \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
--cc=mcchou@chromium.org \
--cc=pali@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).