Linux-Bluetooth Archive on lore.kernel.org
 help / color / Atom feed
From: Archie Pusaka <apusaka@google.com>
To: linux-bluetooth <linux-bluetooth@vger.kernel.org>,
	Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Cc: Archie Pusaka <apusaka@chromium.org>
Subject: Re: [Bluez PATCH v1] avdtp: fix delay report valid states
Date: Fri, 27 Mar 2020 10:14:33 +0800
Message-ID: <CAJQfnxENfZnXq4e-kaeKF2ByhJ089JXZumWc9ydBJBWGQgTiGw@mail.gmail.com> (raw)
In-Reply-To: <20200320131356.Bluez.v1.1.Ia3d21e293d18f903fa6e54918856e1dd5ffc904f@changeid>

[re-sending as plain text]
Hi Bluez Maintainers,

Could you take a look at this proposal?

Thank you!


On Fri, 20 Mar 2020 at 13:14, Archie Pusaka <apusaka@google.com> wrote:
>
> From: Archie Pusaka <apusaka@chromium.org>
>
> According to AVDTP specification section 6.19,
> avdtp_delayreport_cmd could also be received when the state of SEP
> is open.
>
> Therefore, updating to accommodate such condition.
> ---
>
>  profiles/audio/avdtp.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/profiles/audio/avdtp.c b/profiles/audio/avdtp.c
> index 0e075f9ff..4b0e63384 100644
> --- a/profiles/audio/avdtp.c
> +++ b/profiles/audio/avdtp.c
> @@ -1936,6 +1936,7 @@ static gboolean avdtp_delayreport_cmd(struct avdtp *session,
>         stream = sep->stream;
>
>         if (sep->state != AVDTP_STATE_CONFIGURED &&
> +                                       sep->state != AVDTP_STATE_OPEN &&
>                                         sep->state != AVDTP_STATE_STREAMING) {
>                 err = AVDTP_BAD_STATE;
>                 goto failed;
> --
> 2.25.1.696.g5e7596f4ac-goog
>

  reply index

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-20  5:14 Archie Pusaka
2020-03-27  2:14 ` Archie Pusaka [this message]
2020-03-27 20:55   ` Luiz Augusto von Dentz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJQfnxENfZnXq4e-kaeKF2ByhJ089JXZumWc9ydBJBWGQgTiGw@mail.gmail.com \
    --to=apusaka@google.com \
    --cc=apusaka@chromium.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=luiz.dentz@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Bluetooth Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-bluetooth/0 linux-bluetooth/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-bluetooth linux-bluetooth/ https://lore.kernel.org/linux-bluetooth \
		linux-bluetooth@vger.kernel.org
	public-inbox-index linux-bluetooth

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-bluetooth


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git