From: Alain Michaud <alainmichaud@google.com>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: Alain Michaud <alainm@chromium.org>,
BlueZ <linux-bluetooth@vger.kernel.org>
Subject: Re: [PATCH v2] sco:Add support for BT_PKT_STATUS CMSG data
Date: Thu, 28 May 2020 09:27:51 -0400 [thread overview]
Message-ID: <CALWDO_XZLjFR1WheNogehz-STe+8wRpi2SSPb3Bscb2eKsPDmw@mail.gmail.com> (raw)
In-Reply-To: <31E0FE7F-34A6-4819-AE06-C9F0B49D7C11@holtmann.org>
On Thu, May 28, 2020 at 4:26 AM Marcel Holtmann <marcel@holtmann.org> wrote:
>
> Hi Alain,
>
> > This change adds support for reporting the BT_PKT_STATUS to the socket
> > CMSG data to allow the implementation of a packet loss correction on
> > erronous data received on the SCO socket.
> >
> > The patch was partially developed by Marcel Holtmann and validated by
> > Hsin-yu Chao
> >
> > Signed-off-by: Alain Michaud <alainm@chromium.org>
> >
> > ---
> >
> > include/net/bluetooth/bluetooth.h | 8 ++++++++
> > include/net/bluetooth/sco.h | 3 +++
> > net/bluetooth/af_bluetooth.c | 3 +++
> > net/bluetooth/hci_core.c | 1 +
> > net/bluetooth/sco.c | 28 ++++++++++++++++++++++++++++
> > 5 files changed, 43 insertions(+)
> >
> > diff --git a/include/net/bluetooth/bluetooth.h b/include/net/bluetooth/bluetooth.h
> > index 3fa7b1e3c5d9..85e6c5754448 100644
> > --- a/include/net/bluetooth/bluetooth.h
> > +++ b/include/net/bluetooth/bluetooth.h
> > @@ -147,6 +147,8 @@ struct bt_voice {
> > #define BT_MODE_LE_FLOWCTL 0x03
> > #define BT_MODE_EXT_FLOWCTL 0x04
> >
> > +#define BT_PKT_STATUS 16
> > +
>
> we need to agree on if this is an int or u8 value. Otherwise this looks good.
Since doing anything beyond a u8 value would require a core spec
change and likely a new definition for what the packet flags are, I
think it is likely safe to keep as u8. Do you have a different
perspective?
>
> Regards
>
> Marcel
>
next prev parent reply other threads:[~2020-05-28 13:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-25 18:43 [PATCH v2] sco:Add support for BT_PKT_STATUS CMSG data Alain Michaud
2020-05-28 8:26 ` Marcel Holtmann
2020-05-28 13:27 ` Alain Michaud [this message]
2020-06-03 14:51 Alain Michaud
2020-06-10 8:25 ` Marcel Holtmann
[not found] ` <CALWDO_VHTT4V5GvPFtSZcW5Xce8oTSaLNdNQ1gNd=hyCaBX-yg@mail.gmail.com>
2020-06-10 13:33 ` Alain Michaud
2020-06-10 14:01 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALWDO_XZLjFR1WheNogehz-STe+8wRpi2SSPb3Bscb2eKsPDmw@mail.gmail.com \
--to=alainmichaud@google.com \
--cc=alainm@chromium.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).