From: Abhishek Pandit-Subedi <abhishekpandit@chromium.org>
To: Marcel Holtmann <marcel@holtmann.org>,
Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Cc: ChromeOS Bluetooth Upstreaming
<chromeos-bluetooth-upstreaming@chromium.org>,
Bluez mailing list <linux-bluetooth@vger.kernel.org>,
Alain Michaud <alainm@chromium.org>,
Miao-chen Chou <mcchou@chromium.org>
Subject: Re: [Bluez PATCH v2] doc: Add Suspend and Resume events
Date: Tue, 21 Jul 2020 20:18:50 -0700 [thread overview]
Message-ID: <CANFp7mWRZWnC6FB3noMq8NBpgT1J7EfYe1-n8_FxpY5LQaSxaA@mail.gmail.com> (raw)
In-Reply-To: <20200714125120.Bluez.v2.1.I9181af521cf0fba8f4315c9b89975848d437d6dd@changeid>
Hi Marcel,
Please take a look at this v2 patch.
Thanks
Abhishek
On Tue, Jul 14, 2020 at 12:51 PM Abhishek Pandit-Subedi
<abhishekpandit@chromium.org> wrote:
>
> Add Controller Suspend Event and Controller Resume Event to identify
> suspend or resume of the Bluetooth stack has occurred.
>
> Also update Device Disconnected Event to indicate a new disconnect
> reason: "Connection terminated by local host for suspend"
>
> Reviewed-by: Alain Michaud <alainm@chromium.org>
> Reviewed-by: Miao-chen Chou <mcchou@chromium.org>
> ---
>
> Changes in v2:
> - Moved Wake_Reason to first value
> - Reduced Wake_Reason to not Bluetooth, unexpected event and remote wake
>
> doc/mgmt-api.txt | 48 ++++++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 48 insertions(+)
>
> diff --git a/doc/mgmt-api.txt b/doc/mgmt-api.txt
> index ca0d38469..e7a713824 100644
> --- a/doc/mgmt-api.txt
> +++ b/doc/mgmt-api.txt
> @@ -3834,6 +3834,7 @@ Device Disconnected Event
> 2 Connection terminated by local host
> 3 Connection terminated by remote host
> 4 Connection terminated due to authentication failure
> + 5 Connection terminated by local host for suspend
>
> Note that the local/remote distinction just determines which side
> terminated the low-level connection, regardless of the
> @@ -4577,3 +4578,50 @@ Advertisement Monitor Removed Event
>
> The event will only be sent to management sockets other than the
> one through which the command was sent.
> +
> +
> +Controller Suspend Event
> +========================
> +
> + Event code: 0x002d
> + Controller Index: <controller_id>
> + Event Parameters: Suspend_State (1 octet)
> +
> + This event indicates that the controller is suspended for host suspend.
> +
> + Possible values for the Suspend_State parameter:
> + 0 Running (not disconnected)
> + 1 Disconnected and not scanning
> + 2 Page scanning and/or passive scanning.
> +
> + The value 0 is used for the running state and may be sent if the
> + controller could not be configured to suspend properly.
> +
> + This event will be sent to all management sockets.
> +
> +
> +Controller Resume Event
> +=======================
> +
> + Event code: 0x002e
> + Controller Index: <controller_id>
> + Event Parameters: Wake_Reason (1 octet)
> + Address (6 octets)
> + Address_Type (1 octet)
> +
> + This event indicates that the controller has resumed from suspend.
> +
> + Possible values for the Wake_Reason parameter:
> + 0 Resume from non-Bluetooth wake source
> + 1 Wake due to unexpected event
> + 2 Remote wake due to peer device connection
> +
> + Currently, we expect that only peer reconnections should wake us from
> + the suspended state. Any other events that occurred while the system
> + should have been suspended results in wake due to unexpected event.
> +
> + If the Wake_Reason is Remote wake due to connection, the address of the
> + peer device that caused the event will be shared in Address and
> + Address_Type. Otherwise, Address and Address_Type will both be zero.
> +
> + This event will be sent to all management sockets.
> --
> 2.27.0.389.gc38d7665816-goog
>
next prev parent reply other threads:[~2020-07-22 3:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-14 19:51 [Bluez PATCH v2] doc: Add Suspend and Resume events Abhishek Pandit-Subedi
2020-07-22 3:18 ` Abhishek Pandit-Subedi [this message]
2020-07-28 7:16 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANFp7mWRZWnC6FB3noMq8NBpgT1J7EfYe1-n8_FxpY5LQaSxaA@mail.gmail.com \
--to=abhishekpandit@chromium.org \
--cc=alainm@chromium.org \
--cc=chromeos-bluetooth-upstreaming@chromium.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
--cc=mcchou@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).