From: Abhishek Pandit-Subedi <abhishekpandit@chromium.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Bluez mailing list <linux-bluetooth@vger.kernel.org>
Subject: Re: [bug report] Bluetooth: hci_qca: Enable WBS support for wcn3991
Date: Wed, 20 May 2020 09:23:28 -0700 [thread overview]
Message-ID: <CANFp7mWsg5suwOPRvz1VCncztikah3VPpj5QEG-Heb_-TVQ6aA@mail.gmail.com> (raw)
In-Reply-To: <20200520120510.GF172354@mwanda>
Thanks for the heads-up Dan. Patch incoming to fix this.
Abhishek
On Wed, May 20, 2020 at 5:07 AM Dan Carpenter <dan.carpenter@oracle.com> wrote:
>
> Hello Abhishek Pandit-Subedi,
>
> The patch a228f7a41029: "Bluetooth: hci_qca: Enable WBS support for
> wcn3991" from May 14, 2020, leads to the following static checker
> warning:
>
> drivers/bluetooth/hci_qca.c:1960 qca_serdev_probe()
> error: uninitialized symbol 'hdev'.
>
> drivers/bluetooth/hci_qca.c
> 1948 }
> 1949
> 1950 if (power_ctrl_enabled) {
> 1951 hdev = qcadev->serdev_hu.hdev;
> ^^^^
> hdev is only initialized here.
>
> 1952 set_bit(HCI_QUIRK_NON_PERSISTENT_SETUP, &hdev->quirks);
> 1953 hdev->shutdown = qca_power_off;
> 1954 }
> 1955
> 1956 /* Wideband speech support must be set per driver since it can't be
> 1957 * queried via hci.
> 1958 */
> 1959 if (data && (data->capabilities & QCA_CAP_WIDEBAND_SPEECH))
> 1960 set_bit(HCI_QUIRK_WIDEBAND_SPEECH_SUPPORTED, &hdev->quirks);
> ^^^^
> Potentially uninitialized here.
>
> 1961
> 1962 return 0;
> 1963 }
>
> regards,
> dan carpenter
prev parent reply other threads:[~2020-05-20 16:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-20 12:05 [bug report] Bluetooth: hci_qca: Enable WBS support for wcn3991 Dan Carpenter
2020-05-20 16:23 ` Abhishek Pandit-Subedi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANFp7mWsg5suwOPRvz1VCncztikah3VPpj5QEG-Heb_-TVQ6aA@mail.gmail.com \
--to=abhishekpandit@chromium.org \
--cc=dan.carpenter@oracle.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).