Linux-Bluetooth Archive on lore.kernel.org
 help / color / Atom feed
From: Sonny Sasaka <sonnysasaka@chromium.org>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: BlueZ <linux-bluetooth@vger.kernel.org>
Subject: Re: [PATCH] build: Add an option to explicitly disable installing hid2hci
Date: Wed, 6 May 2020 10:05:16 -0700
Message-ID: <CAOxioN=XkDSDEE=PcZJf8JoTiDBPMoYpK1zAyRoReEUx9B-Mmg@mail.gmail.com> (raw)
In-Reply-To: <56F32068-E8EC-45DD-B233-DBDAFBFA0187@holtmann.org>

Hi Marcel,

Chrome OS doesn't support HID-HCI switchable controllers so we would
like to remove this from being installed to reduce maintenance burden.
Disabling udev unfortunately also uninstalls sixaxis plugin, which we
still need. Do you have a suggestion how we can achieve this?

On Wed, May 6, 2020 at 4:06 AM Marcel Holtmann <marcel@holtmann.org> wrote:
>
> Hi Sonny,
>
> > ---
> > configure.ac | 5 ++++-
> > 1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/configure.ac b/configure.ac
> > index 1433ace4a..ba9937a16 100644
> > --- a/configure.ac
> > +++ b/configure.ac
> > @@ -218,8 +218,11 @@ if (test "${enable_udev}" != "no" && test -z "${path_udevdir}"); then
> > fi
> > AC_SUBST(UDEV_DIR, [${path_udevdir}])
> >
> > +AC_ARG_ENABLE(hid2hci, AC_HELP_STRING([--disable-hid2hci],
> > +             [disable hid2hci tool]), [enable_hid2hci=${enableval}])
> > AM_CONDITIONAL(HID2HCI, test "${enable_tools}" != "no" &&
> > -                                             test "${enable_udev}" != "no")
> > +                                     test "${enable_udev}" != "no" &&
> > +                                     test "${enable_hid2hci}" != "no")
>
> can you give me a bit of background why you need that. We did have that and I removed it in favor of putting everything behind udev. Mainly since we really don’t need most of these things anymore. Can’t you just disable udev support and get the same result?
>
> Regards
>
> Marcel
>

  reply index

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-06  0:55 Sonny Sasaka
2020-05-06 11:06 ` Marcel Holtmann
2020-05-06 17:05   ` Sonny Sasaka [this message]
2020-05-12 21:19     ` Sonny Sasaka
2020-05-13  8:02 ` Marcel Holtmann
2020-05-13 21:38   ` [PATCH v2] build: Add an option to explicitly enable hid2hci Sonny Sasaka
2020-05-18  7:53     ` Marcel Holtmann
2020-05-13 21:41   ` [PATCH] build: Add an option to explicitly disable installing hid2hci Sonny Sasaka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAOxioN=XkDSDEE=PcZJf8JoTiDBPMoYpK1zAyRoReEUx9B-Mmg@mail.gmail.com' \
    --to=sonnysasaka@chromium.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=marcel@holtmann.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Bluetooth Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-bluetooth/0 linux-bluetooth/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-bluetooth linux-bluetooth/ https://lore.kernel.org/linux-bluetooth \
		linux-bluetooth@vger.kernel.org
	public-inbox-index linux-bluetooth

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-bluetooth


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git