From: Sonny Sasaka <sonnysasaka@chromium.org>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: Bluez mailing list <linux-bluetooth@vger.kernel.org>,
Eric Caruso <ejcaruso@chromium.org>
Subject: Re: [PATCH] device: Add device type property
Date: Tue, 19 May 2020 16:12:48 -0700 [thread overview]
Message-ID: <CAOxioNkw8g90tVwQjqgdpX38__f17JHHTTsqBZwCjEkjME0Zyg@mail.gmail.com> (raw)
In-Reply-To: <68C2E4A8-29E0-44D8-9D2F-F4E2354DE419@holtmann.org>
Hi Marcel,
After giving it more thought, I would like to propose that this
additional property corresponds with Device Type as defined in Generic
Access Profile:
As stated in Bluetooth Core Specification Version 5.2, Vol 3, Part C
(Generic Access Profile):
This profile defines three device types based on the supported Core
Configurations as defined in [Vol 0] Part B, Section 3.1. The device
types are shown in Table 1.1:
* BR/EDR
* LE only
* BR/EDR/LE
Therefore, to be as close to the spec as possible, I propose that the
property be named GAPDeviceType, and the possible values be "br/edr",
"le-only", "br/edr/le".
What do you think? Thanks for reviewing this proposal!
On Thu, Apr 9, 2020 at 11:51 PM Marcel Holtmann <marcel@holtmann.org> wrote:
>
> Hi Sonny,
>
> > Thanks for the feedback, Marcel. Will come back with the modified
> > patches based on your suggestions.
>
> I also meant to write that the name “Bearer” might not be the best either. I am open for suggestions. Also if it is an array, it needs to be plural of course. If we start exposing BR/EDR vs LE or its combination (and we might also consider HS even while not used these days), then we need to be consistent with our terminology across the APIs.
>
> Regards
>
> Marcel
>
next prev parent reply other threads:[~2020-05-19 23:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-01 22:13 [PATCH] device: Add device type property Sonny Sasaka
2020-04-09 18:11 ` Marcel Holtmann
2020-04-09 21:05 ` Sonny Sasaka
2020-04-10 6:51 ` Marcel Holtmann
2020-05-19 23:12 ` Sonny Sasaka [this message]
2020-05-20 6:49 ` Marcel Holtmann
2020-05-21 1:07 ` Sonny Sasaka
2020-05-21 7:01 ` Marcel Holtmann
2020-05-21 16:24 ` Sonny Sasaka
-- strict thread matches above, loose matches on Subject: below --
2017-02-09 1:05 mcchou
2017-02-09 7:37 ` Marcel Holtmann
2017-02-09 8:07 ` Szymon Janc
2017-02-09 9:40 ` Luiz Augusto von Dentz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOxioNkw8g90tVwQjqgdpX38__f17JHHTTsqBZwCjEkjME0Zyg@mail.gmail.com \
--to=sonnysasaka@chromium.org \
--cc=ejcaruso@chromium.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).