From: Sonny Sasaka <sonnysasaka@chromium.org>
To: BlueZ <linux-bluetooth@vger.kernel.org>
Subject: Re: [PATCH BlueZ v2] profile: Add exception to battery profile for external access
Date: Fri, 17 Jul 2020 13:13:44 -0700 [thread overview]
Message-ID: <CAOxioNm_D1E9RY6R6U0F356HfTUJtkGFFhJaa=44hBLevHzTjQ@mail.gmail.com> (raw)
In-Reply-To: <20200715224740.238527-1-sonnysasaka@chromium.org>
Friendly ping on this simple patch.
On Wed, Jul 15, 2020 at 3:47 PM Sonny Sasaka <sonnysasaka@chromium.org> wrote:
>
> This gives exception to battery profile to be shared both internally and
> externally.
>
> ---
> profiles/battery/battery.c | 1 +
> src/profile.h | 4 ++++
> 2 files changed, 5 insertions(+)
>
> diff --git a/profiles/battery/battery.c b/profiles/battery/battery.c
> index 4da4355a1..c9a1af4b9 100644
> --- a/profiles/battery/battery.c
> +++ b/profiles/battery/battery.c
> @@ -354,6 +354,7 @@ static struct btd_profile batt_profile = {
> .device_remove = batt_remove,
> .accept = batt_accept,
> .disconnect = batt_disconnect,
> + .external = true,
> };
>
> static int batt_init(void)
> diff --git a/src/profile.h b/src/profile.h
> index 4448a2a6d..95523e50a 100644
> --- a/src/profile.h
> +++ b/src/profile.h
> @@ -35,6 +35,10 @@ struct btd_profile {
> const char *remote_uuid;
>
> bool auto_connect;
> + /* Some profiles are considered safe to be handled internally and also
> + * be exposed in the GATT API. This flag give such profiles exception
> + * from being claimed internally.
> + */
> bool external;
>
> int (*device_probe) (struct btd_service *service);
> --
> 2.26.2
>
next prev parent reply other threads:[~2020-07-17 20:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-15 22:28 [PATCH BlueZ] profile: Add exception from being claimed internally Sonny Sasaka
2020-07-15 22:39 ` Luiz Augusto von Dentz
2020-07-15 22:47 ` [PATCH BlueZ v2] profile: Add exception to battery profile for external access Sonny Sasaka
2020-07-17 20:13 ` Sonny Sasaka [this message]
2020-07-17 20:33 ` Luiz Augusto von Dentz
2020-07-17 20:38 ` Luiz Augusto von Dentz
2020-07-17 21:36 ` Sonny Sasaka
2020-07-15 22:49 ` [PATCH BlueZ] profile: Add exception from being claimed internally Sonny Sasaka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOxioNm_D1E9RY6R6U0F356HfTUJtkGFFhJaa=44hBLevHzTjQ@mail.gmail.com' \
--to=sonnysasaka@chromium.org \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).