Linux-Bluetooth Archive on lore.kernel.org
 help / color / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: Balakrishna Godavarthi <bgodavar@codeaurora.org>
Cc: Johan Hedberg <johan.hedberg@gmail.com>,
	mka@chromium.org, linux-kernel@vger.kernel.org,
	linux-bluetooth@vger.kernel.org, hemantg@codeaurora.org,
	linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v11 0/3] Bug fixes for Qualcomm BT chip wcn3990
Date: Mon, 18 Feb 2019 11:50:51 +0100
Message-ID: <CB022FBC-122B-41D8-A7C1-DD29276C3A3A@holtmann.org> (raw)
In-Reply-To: <20190204150643.25165-1-bgodavar@codeaurora.org>

Hi Balakrishna,

> The below issues are found in our recent testing.
> 
> 1. Observed device is not going into off state or not responding.
>    As wcn3990 require a power pulses to turn on the irrespctive of
>    igniting regulators, it was observed that power on or power off
>    pulses are not in sync with respective to chip.
>    The below patch will help us to wait until byte is pushed on to wires.          
> 
>    * Bluetooth: hci_qca: use wait_until_sent() for power pulses
> 
> 2. Observed Chip responding when we are in sleep.
>   This is due to turn on flow control during change baudrate request.
>   The below patch will only pull the RTS line high instead of turning off
>   the flow.
> 
>   * Bluetooth: hci_qca: Pull RTS line high for baudrate change command.
> 
> 3. Disable IBS state machine and flush Tx buffer
>   We are disabling IBS and flushing the Tx buffer before turning off the chip.
> 
>   This is due to IBS state machine is active when we turn off the chip.
>   This will stop queuing IBS protocol bytes.
> 
>   * Bluetooth: hci_qca: Disable IBS state machine and flush Tx buffer
> 
> Changes in v11:
> * added correct signatures for the patch.
> 
> Changes in v10:
> * Decreased wait time for power pulse to 100 ms instead of 1second.
> * enabling the flow control back when baudarte change request fails.
> * updated review comments.
> 
> Changes in v9:
> * Reverted the 100us delay and used msecs to jiffies inline call.
> * Disabling the flow control and enabling it back while setting the firmware.
> * Added spinlock while clearing the IBS state machine.
> 
> Changes in v8:
> * dropped inject the command complete event.
> * added one second time for the power pules instead of the indefinite time.
> 
> Changes in v7:
> * dropped frame reassmebly error patch.
> * dropped baudrate change wait time patch.
> * increased a wait to 5 ms for power pulses.
> 
> Changes in v6:
> * added serdev_device_write_flush in qca_send_power_pulse().
> * added new patch to update the baudrate change wait time.
> 
> Changes in V5:
> * added serdev_device_write_flush before sending the power off pulse
>   during shutdown.
> 
> Changes in v4:
> * used serdev_device_write_buf() instead of serdev_device_write().
> * added new patch to stop logging of 0xfc00 timeout on console.
> 
> Changes in v3:
> * moved IBS & qca_flush to different patch
> * updated comments in code fo Deassert RTS patch
> Balakrishna Godavarthi (3):
>  Bluetooth: hci_qca: use wait_until_sent() for power pulses
>  Bluetooth: hci_qca: Deassert RTS while baudrate change command
>  Bluetooth: hci_qca: Disable IBS state machine and flush Tx buffer
> 
> drivers/bluetooth/hci_qca.c | 82 ++++++++++++++++++++-----------------
> 1 file changed, 44 insertions(+), 38 deletions(-)

all 3 patches have been applied to bluetooth-next tree.

Regards

Marcel


      parent reply index

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-04 15:06 Balakrishna Godavarthi
2019-02-04 15:06 ` [PATCH v11 1/3] Bluetooth: hci_qca: use wait_until_sent() for power pulses Balakrishna Godavarthi
2019-02-04 15:06 ` [PATCH v11 2/3] Bluetooth: hci_qca: Deassert RTS while baudrate change command Balakrishna Godavarthi
2019-02-04 15:06 ` [PATCH v11 3/3] Bluetooth: hci_qca: Disable IBS state machine and flush Tx buffer Balakrishna Godavarthi
2019-02-04 17:31   ` Matthias Kaehlcke
2019-02-18 10:50 ` Marcel Holtmann [this message]

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CB022FBC-122B-41D8-A7C1-DD29276C3A3A@holtmann.org \
    --to=marcel@holtmann.org \
    --cc=bgodavar@codeaurora.org \
    --cc=hemantg@codeaurora.org \
    --cc=johan.hedberg@gmail.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mka@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Bluetooth Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-bluetooth/0 linux-bluetooth/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-bluetooth linux-bluetooth/ https://lore.kernel.org/linux-bluetooth \
		linux-bluetooth@vger.kernel.org linux-bluetooth@archiver.kernel.org
	public-inbox-index linux-bluetooth


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-bluetooth


AGPL code for this site: git clone https://public-inbox.org/ public-inbox