Re: [PATCH] Fast advertising interval

From: Marcel Holtmann <marcel@holtmann.org>
To: SpoorthiX K <spoorthix.k@intel.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] Fast advertising interval
Date: Sat, 6 Jul 2019 12:42:18 +0200	[thread overview]
Message-ID: <CCA3FD03-9EA3-43B7-B2E8-310316BCA6AA@holtmann.org> (raw)
In-Reply-To: <1561108931-9568-1-git-send-email-spoorthix.k@intel.com>

Hi Spoorthi,

> Implemented as per Core Spec 5.0
> 
> Signed-off-by: Spoorthi Ravishankar Koppad <spoorthix.k@intel.com>
> ---
> include/net/bluetooth/hci_core.h |  2 ++
> net/bluetooth/hci_request.c      | 33 ++++++++++++++++++++++++---------
> 2 files changed, 26 insertions(+), 9 deletions(-)
> 
> diff --git a/include/net/bluetooth/hci_core.h b/include/net/bluetooth/hci_core.h
> index aed17df..9b19992 100644
> --- a/include/net/bluetooth/hci_core.h
> +++ b/include/net/bluetooth/hci_core.h
> @@ -1510,6 +1510,8 @@ struct hci_mgmt_chan {
> #define DISCOV_INTERLEAVED_INQUIRY_LEN	0x04
> #define DISCOV_BREDR_INQUIRY_LEN	0x08
> #define DISCOV_LE_RESTART_DELAY		msecs_to_jiffies(200)	/* msec */
> +#define DISCOV_LE_FAST_ADV_INT_MIN     100     /* msec */
> +#define DISCOV_LE_FAST_ADV_INT_MAX     150     /* msec */
> 
> void mgmt_fill_version_info(void *ver);
> int mgmt_new_settings(struct hci_dev *hdev);
> diff --git a/net/bluetooth/hci_request.c b/net/bluetooth/hci_request.c
> index d4f5bfa..c077b06 100644
> --- a/net/bluetooth/hci_request.c
> +++ b/net/bluetooth/hci_request.c
> @@ -1177,8 +1177,10 @@ void __hci_req_enable_advertising(struct hci_request *req)
> 	bool connectable;
> 	u32 flags;
> 
> +       	BT_INFO("Entered __hci_req_enable_advertising");
> 	flags = get_adv_instance_flags(hdev, hdev->cur_adv_instance);
> 
> +

these two don’t belong in this patch.

> 	/* If the "connectable" instance flag was not set, then choose between
> 	 * ADV_IND and ADV_NONCONN_IND based on the global connectable setting.
> 	 */
> @@ -1208,15 +1210,28 @@ void __hci_req_enable_advertising(struct hci_request *req)
> 		return;
> 
> 	memset(&cp, 0, sizeof(cp));
> -	cp.min_interval = cpu_to_le16(hdev->le_adv_min_interval);
> -	cp.max_interval = cpu_to_le16(hdev->le_adv_max_interval);
> -
> -	if (connectable)
> -		cp.type = LE_ADV_IND;
> -	else if (get_cur_adv_instance_scan_rsp_len(hdev))
> -		cp.type = LE_ADV_SCAN_IND;
> -	else
> -		cp.type = LE_ADV_NONCONN_IND;
> +       BT_INFO("__hci_req_enable_advertising”);

This is debug code. Please remove it.

> +
> +       if (connectable) {
> +               BT_INFO("set adv min and max");
> +                cp.type = LE_ADV_IND;

The indentation is borked here and the BT_INFO also doesn’t belong here.

> +               cp.min_interval = cpu_to_le16(hdev->le_adv_min_interval);
> +               cp.max_interval = cpu_to_le16(hdev->le_adv_max_interval);
> +       } else {
> +               if (get_cur_adv_instance_scan_rsp_len(hdev))
> +                       cp.type = LE_ADV_SCAN_IND;
> +               else
> +                       cp.type = LE_ADV_NONCONN_IND;
> +
> +              if (!hci_dev_test_flag(hdev, HCI_DISCOVERABLE) ||
> +                       hci_dev_test_flag(hdev, HCI_LIMITED_DISCOVERABLE)) {
> +                       BT_INFO("Check  HCI_DISCOVERABLE or HCI_LIMITED_DISCOVERABLE”);

Same as above. No BT_INFO here please.

> +                       cp.min_interval =
> +                              cpu_to_le16(DISCOV_LE_FAST_ADV_INT_MIN);
> +                       cp.max_interval =
> +                               cpu_to_le16(DISCOV_LE_FAST_ADV_INT_MAX);
> +               }
> +       }
> 
> 	cp.own_address_type = own_addr_type;
> 	cp.channel_map = hdev->le_adv_channel_map;

Regards

Marcel