From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3F53C32771 for ; Wed, 15 Jan 2020 21:37:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C40BB222C3 for ; Wed, 15 Jan 2020 21:37:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729077AbgAOVhL (ORCPT ); Wed, 15 Jan 2020 16:37:11 -0500 Received: from coyote.holtmann.net ([212.227.132.17]:46233 "EHLO mail.holtmann.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726018AbgAOVhK (ORCPT ); Wed, 15 Jan 2020 16:37:10 -0500 Received: from marcel-macbook.fritz.box (p4FEFC5A7.dip0.t-ipconnect.de [79.239.197.167]) by mail.holtmann.org (Postfix) with ESMTPSA id 23D2DCECF2; Wed, 15 Jan 2020 22:46:27 +0100 (CET) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 13.0 \(3608.40.2.2.4\)) Subject: Re: [PATCH v4 1/3] Bluetooth: hci_qca: Add QCA Rome power off support to the qca_power_shutdown() From: Marcel Holtmann In-Reply-To: <20200115085552.11483-1-rjliao@codeaurora.org> Date: Wed, 15 Jan 2020 22:37:08 +0100 Cc: Johan Hedberg , Matthias Kaehlcke , Linux Kernel Mailing List , Bluez mailing list , MSM , Balakrishna Godavarthi , hemantg@codeaurora.org Content-Transfer-Encoding: 7bit Message-Id: References: <20191225060317.5258-1-rjliao@codeaurora.org> <20200115085552.11483-1-rjliao@codeaurora.org> To: Rocky Liao X-Mailer: Apple Mail (2.3608.40.2.2.4) Sender: linux-bluetooth-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org Hi Rocky, > Current qca_power_shutdown() only supports wcn399x, this patch adds Rome > power off support to it. For Rome it just needs to pull down the bt_en > GPIO to power off it. This patch also replaces all the power off operation > in qca_close() with the unified qca_power_shutdown() call. > > Signed-off-by: Rocky Liao > --- > > Changes in v2: None > Changes in v3: None > Changes in v4: > -rebased the patch with latest code base > -moved the change from qca_power_off() to qca_power_shutdown() > -replaced all the power off operation in qca_close() with > qca_power_shutdown() > -updated commit message > > drivers/bluetooth/hci_qca.c | 28 ++++++++++++++++------------ > 1 file changed, 16 insertions(+), 12 deletions(-) patch has been applied to bluetooth-next tree. Regards Marcel