Linux-Bluetooth Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH -next] Bluetooth: hci_qca: Remove set but not used variable 'opcode'
@ 2020-01-08  1:54 YueHaibing
  2020-01-08 20:48 ` Marcel Holtmann
  0 siblings, 1 reply; 2+ messages in thread
From: YueHaibing @ 2020-01-08  1:54 UTC (permalink / raw)
  To: Marcel Holtmann, Johan Hedberg
  Cc: YueHaibing, linux-bluetooth, kernel-janitors, Hulk Robot

Fixes gcc '-Wunused-but-set-variable' warning:

drivers/bluetooth/hci_qca.c: In function 'qca_controller_memdump':
drivers/bluetooth/hci_qca.c:980:6: warning:
 variable 'opcode' set but not used [-Wunused-but-set-variable]

It is never used since commit d841502c79e3 ("Bluetooth: hci_qca: Collect
controller memory dump during SSR"), so remove it.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 drivers/bluetooth/hci_qca.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c
index 9392cc7f9908..c9a0c55ef832 100644
--- a/drivers/bluetooth/hci_qca.c
+++ b/drivers/bluetooth/hci_qca.c
@@ -977,7 +977,7 @@ static void qca_controller_memdump(struct work_struct *work)
 	struct qca_dump_size *dump;
 	char *memdump_buf;
 	char nullBuff[QCA_DUMP_PACKET_SIZE] = { 0 };
-	u16 opcode, seq_no;
+	u16 seq_no;
 	u32 dump_size;
 
 	while ((skb = skb_dequeue(&qca->rx_memdump_q))) {
@@ -993,7 +993,6 @@ static void qca_controller_memdump(struct work_struct *work)
 
 		qca->memdump_state = QCA_MEMDUMP_COLLECTING;
 		cmd_hdr = (void *) skb->data;
-		opcode = __le16_to_cpu(cmd_hdr->opcode);
 		seq_no = __le16_to_cpu(cmd_hdr->seq_no);
 		skb_pull(skb, sizeof(struct qca_memdump_event_hdr));




^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH -next] Bluetooth: hci_qca: Remove set but not used variable 'opcode'
  2020-01-08  1:54 [PATCH -next] Bluetooth: hci_qca: Remove set but not used variable 'opcode' YueHaibing
@ 2020-01-08 20:48 ` Marcel Holtmann
  0 siblings, 0 replies; 2+ messages in thread
From: Marcel Holtmann @ 2020-01-08 20:48 UTC (permalink / raw)
  To: YueHaibing; +Cc: Johan Hedberg, BlueZ devel list, kernel-janitors, Hulk Robot

Hi Yue,

> Fixes gcc '-Wunused-but-set-variable' warning:
> 
> drivers/bluetooth/hci_qca.c: In function 'qca_controller_memdump':
> drivers/bluetooth/hci_qca.c:980:6: warning:
> variable 'opcode' set but not used [-Wunused-but-set-variable]
> 
> It is never used since commit d841502c79e3 ("Bluetooth: hci_qca: Collect
> controller memory dump during SSR"), so remove it.
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/bluetooth/hci_qca.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)

patch has been applied to bluetooth-next tree.

Regards

Marcel


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-08  1:54 [PATCH -next] Bluetooth: hci_qca: Remove set but not used variable 'opcode' YueHaibing
2020-01-08 20:48 ` Marcel Holtmann

Linux-Bluetooth Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-bluetooth/0 linux-bluetooth/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-bluetooth linux-bluetooth/ https://lore.kernel.org/linux-bluetooth \
		linux-bluetooth@vger.kernel.org
	public-inbox-index linux-bluetooth

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-bluetooth


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git