From: Marcel Holtmann <marcel@holtmann.org>
To: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 08/10] Bluetooth: hci_h4: Add support for ISO packets
Date: Wed, 8 Jan 2020 22:23:25 +0100 [thread overview]
Message-ID: <F1F4DBA5-9A69-4C09-9359-02DAE70C7403@holtmann.org> (raw)
In-Reply-To: <20200107074056.25453-9-luiz.dentz@gmail.com>
Hi Luiz,
> This enabled H4 driver to properly handle ISO packets.
>
> Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
> ---
> drivers/bluetooth/hci_h4.c | 1 +
> drivers/bluetooth/hci_uart.h | 7 +++++++
> 2 files changed, 8 insertions(+)
>
> diff --git a/drivers/bluetooth/hci_h4.c b/drivers/bluetooth/hci_h4.c
> index 19ba52005009..6dc1fbeb564b 100644
> --- a/drivers/bluetooth/hci_h4.c
> +++ b/drivers/bluetooth/hci_h4.c
> @@ -103,6 +103,7 @@ static const struct h4_recv_pkt h4_recv_pkts[] = {
> { H4_RECV_ACL, .recv = hci_recv_frame },
> { H4_RECV_SCO, .recv = hci_recv_frame },
> { H4_RECV_EVENT, .recv = hci_recv_frame },
> + { H4_RECV_ISO, .recv = hci_recv_frame },
> };
>
> /* Recv data */
> diff --git a/drivers/bluetooth/hci_uart.h b/drivers/bluetooth/hci_uart.h
> index 6ab631101019..4e039d7a16f8 100644
> --- a/drivers/bluetooth/hci_uart.h
> +++ b/drivers/bluetooth/hci_uart.h
> @@ -143,6 +143,13 @@ struct h4_recv_pkt {
> .lsize = 1, \
> .maxlen = HCI_MAX_EVENT_SIZE
>
> +#define H4_RECV_ISO \
> + .type = HCI_ISODATA_PKT, \
> + .hlen = HCI_ISO_HDR_SIZE, \
> + .loff = 2, \
> + .lsize = 2, \
> + .maxlen = HCI_MAX_FRAME_SIZE \
> +
> struct sk_buff *h4_recv_buf(struct hci_dev *hdev, struct sk_buff *skb,
> const unsigned char *buffer, int count,
> const struct h4_recv_pkt *pkts, int pkts_count);
there are a bunch of drivers that should be able to handle packet type 5. We should fix them all.
Regards
Marcel
next prev parent reply other threads:[~2020-01-08 21:23 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-07 7:40 [PATCH 00/10] Bluetooth 5.2 initial support Luiz Augusto von Dentz
2020-01-07 7:40 ` [PATCH 01/10] Bluetooth: Add definitions for CIS connections Luiz Augusto von Dentz
2020-01-07 7:40 ` [PATCH 02/10] Bluetooth: Add initial implementation of " Luiz Augusto von Dentz
2020-01-07 20:22 ` kbuild test robot
2020-01-07 21:25 ` kbuild test robot
2020-01-07 7:40 ` [PATCH 03/10] Bluetooth: L2CAP: Add definitions for Enhanced Credit Based Mode Luiz Augusto von Dentz
2020-01-08 21:28 ` Marcel Holtmann
2020-01-07 7:40 ` [PATCH 04/10] Bluetooth: L2CAP: Add initial code " Luiz Augusto von Dentz
2020-01-07 7:40 ` [PATCH 05/10] Bluetooth: hci_vhci: Add support for ISO packets Luiz Augusto von Dentz
2020-01-07 7:40 ` [PATCH 06/10] Bluetooth: monitor: " Luiz Augusto von Dentz
2020-01-07 7:40 ` [PATCH 07/10] Bluetooth: Make use of __check_timeout on hci_sched_le Luiz Augusto von Dentz
2020-01-07 7:40 ` [PATCH 08/10] Bluetooth: hci_h4: Add support for ISO packets Luiz Augusto von Dentz
2020-01-08 21:23 ` Marcel Holtmann [this message]
2020-01-08 21:47 ` Luiz Augusto von Dentz
2020-01-07 7:40 ` [PATCH 09/10] Bluetooth: btusb: " Luiz Augusto von Dentz
2020-01-08 21:22 ` Marcel Holtmann
2020-01-08 21:57 ` Luiz Augusto von Dentz
2020-01-07 7:40 ` [PATCH 10/10] Bluetooth: btusb: Detect if an ACL packet is in fact an ISO packet Luiz Augusto von Dentz
2020-01-08 21:25 ` Marcel Holtmann
2020-01-08 21:45 ` Luiz Augusto von Dentz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F1F4DBA5-9A69-4C09-9359-02DAE70C7403@holtmann.org \
--to=marcel@holtmann.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).