archive mirror
 help / color / mirror / Atom feed
From: Dan Carpenter <>
To: "Marcel Holtmann" <>,
	"Frédéric Dalleau" <>
Cc: Johan Hedberg <>,
	Luiz Augusto von Dentz <>,
	Gustavo Padovan <>,,
Subject: [PATCH] Bluetooth: sco: prevent information leak in sco_conn_defer_accept()
Date: Fri, 25 Jun 2021 18:00:09 +0300	[thread overview]
Message-ID: <YNXveZZwzS3crmHH@mwanda> (raw)

Smatch complains that some of these struct members are not initialized
leading to a stack information disclosure:

    net/bluetooth/sco.c:778 sco_conn_defer_accept() warn:
    check that 'cp.retrans_effort' doesn't leak information

This seems like a valid warning.  I've added a default case to fix
this issue.  It's sort of unusual to have case SCO_AIRMODE_CVSD,
followed by a default case but I think it's nicely readable.  :)

Fixes: 2f69a82acf6f ("Bluetooth: Use voice setting in deferred SCO connection request")
Signed-off-by: Dan Carpenter <>
 net/bluetooth/sco.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/bluetooth/sco.c b/net/bluetooth/sco.c
index d9a4e88dacbb..e2ee00fea64b 100644
--- a/net/bluetooth/sco.c
+++ b/net/bluetooth/sco.c
@@ -770,6 +770,7 @@ static void sco_conn_defer_accept(struct hci_conn *conn, u16 setting)
 			cp.retrans_effort = 0x02;
+		default:
 			cp.max_latency = cpu_to_le16(0xffff);
 			cp.retrans_effort = 0xff;

             reply	other threads:[~2021-06-25 15:00 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-25 15:00 Dan Carpenter [this message]
2021-06-25 16:17 ` Bluetooth: sco: prevent information leak in sco_conn_defer_accept()
2021-06-25 19:59   ` Dan Carpenter
2021-06-25 20:33     ` Luiz Augusto von Dentz
2021-07-08  7:11 `
2021-07-22 14:14 ` [PATCH] " Marcel Holtmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YNXveZZwzS3crmHH@mwanda \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).