From: "Michał Kępień" <kernel@kempniu.pl>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: Pauli Virtanen <pav@iki.fi>,
linux-bluetooth <linux-bluetooth@vger.kernel.org>,
Joseph Hwang <josephsih@google.com>,
Hilda Wu <hildawu@realtek.com>,
Johan Hedberg <johan.hedberg@gmail.com>,
Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Subject: Re: [PATCH v2] Bluetooth: btusb: check conditions before enabling USB ALT 3 for WBS
Date: Sun, 25 Jul 2021 07:47:14 +0200 [thread overview]
Message-ID: <YPz64lj6xXyXzGOB@larwa.hq.kempniu.pl> (raw)
In-Reply-To: <872F0B33-594E-4BD7-8B75-EA96DE8DBA8F@holtmann.org>
> > Some USB BT adapters don't satisfy the MTU requirement mentioned in
> > commit e848dbd364ac ("Bluetooth: btusb: Add support USB ALT 3 for WBS")
> > and have ALT 3 setting that produces no/garbled audio. Some adapters
> > with larger MTU were also reported to have problems with ALT 3.
> >
> > Add a flag and check it and MTU before selecting ALT 3, falling back to
> > ALT 1. Enable the flag for Realtek, restoring the previous behavior for
> > non-Realtek devices.
> >
> > Tested with USB adapters (mtu<72, no/garbled sound with ALT3, ALT1
> > works) BCM20702A1 0b05:17cb, CSR8510A10 0a12:0001, and (mtu>=72, ALT3
> > works) RTL8761BU 0bda:8771, Intel AX200 8087:0029 (after disabling
> > ALT6). Also got reports for (mtu>=72, ALT 3 reported to produce bad
> > audio) Intel 8087:0a2b.
> >
> > Signed-off-by: Pauli Virtanen <pav@iki.fi>
> > Fixes: e848dbd364ac ("Bluetooth: btusb: Add support USB ALT 3 for WBS")
>
> before I will apply this, I need Tested-by or Ack-by people that confirm that this fixes their issues now.
For 8087:0a2b (with broken mSBC audio since e848dbd364ac):
Tested-by: Michał Kępień <kernel@kempniu.pl>
It would be nice to get this into the stable tree as e848dbd364ac got
there in v5.13.3 (as 15407b14e27b) and v5.10.51 (as 05298f1733c6).
Thanks!
--
Best regards,
Michał Kępień
next prev parent reply other threads:[~2021-07-25 5:47 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-16 17:58 [PATCH] Bluetooth: btusb: check SCO MTU before enabling USB ALT 3 for WBS Pauli Virtanen
2021-07-16 19:16 ` bluez.test.bot
2021-07-17 13:34 ` [PATCH] " Joseph Hwang
2021-07-21 15:40 ` Pauli Virtanen
2021-07-22 10:28 ` Hilda Wu
2021-07-20 9:15 ` Pasi Kärkkäinen
2021-07-22 13:29 ` Michał Kępień
2021-07-22 14:26 ` Pauli Virtanen
2021-07-22 14:42 ` Michał Kępień
2021-07-23 10:07 ` [PATCH v2] Bluetooth: btusb: check conditions " Pauli Virtanen
2021-07-23 12:19 ` Marcel Holtmann
2021-07-25 5:47 ` Michał Kępień [this message]
2021-08-10 16:48 ` Pasi Kärkkäinen
2021-08-10 18:37 ` Luiz Augusto von Dentz
2021-07-26 18:02 ` [PATCH v3] " Pauli Virtanen
2021-07-27 2:11 ` [v3] " bluez.test.bot
2021-07-30 12:35 ` [PATCH v3] " Pasi Kärkkäinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YPz64lj6xXyXzGOB@larwa.hq.kempniu.pl \
--to=kernel@kempniu.pl \
--cc=hildawu@realtek.com \
--cc=johan.hedberg@gmail.com \
--cc=josephsih@google.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
--cc=pav@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).