From: Lee Jones <lee.jones@linaro.org>
To: linux-kernel@vger.kernel.org, stable@kernel.org,
Marcel Holtmann <marcel@holtmann.org>,
Johan Hedberg <johan.hedberg@gmail.com>,
Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH 1/1] Bluetooth: Use chan_list_lock to protect the whole put/destroy invokation
Date: Tue, 21 Jun 2022 15:38:46 +0100 [thread overview]
Message-ID: <YrHX9pj/f0tkqJis@google.com> (raw)
In-Reply-To: <20220607134709.373344-1-lee.jones@linaro.org>
On Tue, 07 Jun 2022, Lee Jones wrote:
> This change prevents a use-after-free caused by one of the worker
> threads starting up (see below) *after* the final channel reference
> has been put() during sock_close() but *before* the references to the
> channel have been destroyed.
>
> refcount_t: increment on 0; use-after-free.
> BUG: KASAN: use-after-free in refcount_dec_and_test+0x20/0xd0
> Read of size 4 at addr ffffffc114f5bf18 by task kworker/u17:14/705
>
> CPU: 4 PID: 705 Comm: kworker/u17:14 Tainted: G S W 4.14.234-00003-g1fb6d0bd49a4-dirty #28
> Hardware name: Qualcomm Technologies, Inc. SM8150 V2 PM8150 Google Inc. MSM sm8150 Flame DVT (DT)
> Workqueue: hci0 hci_rx_work
> Call trace:
> dump_backtrace+0x0/0x378
> show_stack+0x20/0x2c
> dump_stack+0x124/0x148
> print_address_description+0x80/0x2e8
> __kasan_report+0x168/0x188
> kasan_report+0x10/0x18
> __asan_load4+0x84/0x8c
> refcount_dec_and_test+0x20/0xd0
> l2cap_chan_put+0x48/0x12c
> l2cap_recv_frame+0x4770/0x6550
> l2cap_recv_acldata+0x44c/0x7a4
> hci_acldata_packet+0x100/0x188
> hci_rx_work+0x178/0x23c
> process_one_work+0x35c/0x95c
> worker_thread+0x4cc/0x960
> kthread+0x1a8/0x1c4
> ret_from_fork+0x10/0x18
>
> Cc: stable@kernel.org
> Cc: Marcel Holtmann <marcel@holtmann.org>
> Cc: Johan Hedberg <johan.hedberg@gmail.com>
> Cc: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Eric Dumazet <edumazet@google.com>
> Cc: Jakub Kicinski <kuba@kernel.org>
> Cc: Paolo Abeni <pabeni@redhat.com>
> Cc: linux-bluetooth@vger.kernel.org
> Cc: netdev@vger.kernel.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
> net/bluetooth/l2cap_core.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
No reply for 2 weeks.
Is this patch being considered at all?
Can I help in any way?
> diff --git a/net/bluetooth/l2cap_core.c b/net/bluetooth/l2cap_core.c
> index ae78490ecd3d4..82279c5919fd8 100644
> --- a/net/bluetooth/l2cap_core.c
> +++ b/net/bluetooth/l2cap_core.c
> @@ -483,9 +483,7 @@ static void l2cap_chan_destroy(struct kref *kref)
>
> BT_DBG("chan %p", chan);
>
> - write_lock(&chan_list_lock);
> list_del(&chan->global_l);
> - write_unlock(&chan_list_lock);
>
> kfree(chan);
> }
> @@ -501,7 +499,9 @@ void l2cap_chan_put(struct l2cap_chan *c)
> {
> BT_DBG("chan %p orig refcnt %u", c, kref_read(&c->kref));
>
> + write_lock(&chan_list_lock);
> kref_put(&c->kref, l2cap_chan_destroy);
> + write_unlock(&chan_list_lock);
> }
> EXPORT_SYMBOL_GPL(l2cap_chan_put);
>
--
Lee Jones [李琼斯]
Principal Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2022-06-21 14:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-07 13:47 [PATCH 1/1] Bluetooth: Use chan_list_lock to protect the whole put/destroy invokation Lee Jones
2022-06-21 14:38 ` Lee Jones [this message]
2022-06-21 18:35 ` Luiz Augusto von Dentz
2022-06-21 18:49 ` Luiz Augusto von Dentz
2022-06-21 19:21 ` Lee Jones
2022-06-21 19:24 ` Luiz Augusto von Dentz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YrHX9pj/f0tkqJis@google.com \
--to=lee.jones@linaro.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=johan.hedberg@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).