From: "Gix, Brian" <brian.gix@intel.com>
To: "michal.lowas-rzechonek@silvair.com"
<michal.lowas-rzechonek@silvair.com>,
"linux-bluetooth@vger.kernel.org"
<linux-bluetooth@vger.kernel.org>
Subject: Re: [PATCH BlueZ] mesh: Fix model publication status after set
Date: Thu, 26 Mar 2020 17:01:46 +0000 [thread overview]
Message-ID: <a4c9a24aec16adda445cde4ecd25d7681b662444.camel@intel.com> (raw)
In-Reply-To: <20200325214847.67394-1-michal.lowas-rzechonek@silvair.com>
Applied
On Wed, 2020-03-25 at 22:48 +0100, Michał Lowas-Rzechonek wrote:
> This patch fixes usage of send_pub_status() when handling publication
> set message - mod_id was swapped with pub_addr, resulting in malformed
> message being sent back to the Config Client.
> ---
> mesh/cfgmod-server.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/mesh/cfgmod-server.c b/mesh/cfgmod-server.c
> index c5c756a33..856eb6b27 100644
> --- a/mesh/cfgmod-server.c
> +++ b/mesh/cfgmod-server.c
> @@ -185,8 +185,8 @@ static void config_pub_set(struct mesh_node *node, uint16_t net_idx,
> }
>
> if (!unreliable)
> - send_pub_status(node, net_idx, src, dst, status, ele_addr, ota,
> - mod_id, idx, cred_flag, ttl, period, retransmit);
> + send_pub_status(node, net_idx, src, dst, status, ele_addr,
> + mod_id, ota, idx, cred_flag, ttl, period, retransmit);
> }
>
> static void send_sub_status(struct mesh_node *node, uint16_t net_idx,
prev parent reply other threads:[~2020-03-26 17:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-25 21:48 [PATCH BlueZ] mesh: Fix model publication status after set Michał Lowas-Rzechonek
2020-03-26 17:01 ` Gix, Brian [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a4c9a24aec16adda445cde4ecd25d7681b662444.camel@intel.com \
--to=brian.gix@intel.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=michal.lowas-rzechonek@silvair.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).