From: Balakrishna Godavarthi <bgodavar@codeaurora.org>
To: Matthias Kaehlcke <mka@chromium.org>
Cc: marcel@holtmann.org, johan.hedberg@gmail.com,
linux-kernel@vger.kernel.org, linux-bluetooth@vger.kernel.org,
hemantg@codeaurora.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v2 2/3] Bluetooth: hci_qca: Deassert RTS while baudrate change command
Date: Tue, 27 Nov 2018 12:11:08 +0530 [thread overview]
Message-ID: <ad8de20da986b530dd53d83c96da7b7b@codeaurora.org> (raw)
In-Reply-To: <20181126194210.GW22824@google.com>
Hi Matthias,
On 2018-11-27 01:12, Matthias Kaehlcke wrote:
> On Thu, Nov 22, 2018 at 05:45:11PM +0530, Balakrishna Godavarthi wrote:
>> This patch will help to stop frame reassembly errors while changing
>> the baudrate. This is because host send a change baudrate request
>> command to the chip with 115200 bps, Whereas chip will change their
>> UART clocks to the enable for new baudrate and sends the response
>> for the change request command with newer baudrate, On host side
>> we are still operating in 115200 bps which results of reading garbage
>> data. Here we are pulling RTS line, so that chip we will wait to send
>> data
>> to host until host change its baudrate.
>
> Thanks for updating the commit message and provide more details!
>
>> Signed-off-by: Balakrishna Godavarthi <bgodavar@codeaurora.org>
>> Tested-by: Matthias Kaehlcke <mka@chromium.org>
>> ---
>> v2:
>> * updated commit text and comments.
>> v1:
>> * initial patch
>> ---
>> drivers/bluetooth/hci_qca.c | 23 ++++++++++++-----------
>> 1 file changed, 12 insertions(+), 11 deletions(-)
>>
>> diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c
>> index f5dd323c1967..ed905ea1c58a 100644
>> --- a/drivers/bluetooth/hci_qca.c
>> +++ b/drivers/bluetooth/hci_qca.c
>> @@ -963,7 +963,6 @@ static int qca_set_baudrate(struct hci_dev *hdev,
>> uint8_t baudrate)
>> struct hci_uart *hu = hci_get_drvdata(hdev);
>> struct qca_data *qca = hu->priv;
>> struct sk_buff *skb;
>> - struct qca_serdev *qcadev;
>> u8 cmd[] = { 0x01, 0x48, 0xFC, 0x01, 0x00 };
>>
>> if (baudrate > QCA_BAUDRATE_3200000)
>> @@ -977,13 +976,6 @@ static int qca_set_baudrate(struct hci_dev *hdev,
>> uint8_t baudrate)
>> return -ENOMEM;
>> }
>>
>> - /* Disabling hardware flow control is mandatory while
>> - * sending change baudrate request to wcn3990 SoC.
>> - */
>> - qcadev = serdev_device_get_drvdata(hu->serdev);
>> - if (qcadev->btsoc_type == QCA_WCN3990)
>> - hci_uart_set_flow_control(hu, true);
>> -
>> /* Assign commands to change baudrate and packet type. */
>> skb_put_data(skb, cmd, sizeof(cmd));
>> hci_skb_pkt_type(skb) = HCI_COMMAND_PKT;
>> @@ -999,9 +991,6 @@ static int qca_set_baudrate(struct hci_dev *hdev,
>> uint8_t baudrate)
>> schedule_timeout(msecs_to_jiffies(BAUDRATE_SETTLE_TIMEOUT_MS));
>> set_current_state(TASK_RUNNING);
>>
>> - if (qcadev->btsoc_type == QCA_WCN3990)
>> - hci_uart_set_flow_control(hu, false);
>> -
>> return 0;
>> }
>>
>> @@ -1086,6 +1075,7 @@ static int qca_check_speeds(struct hci_uart *hu)
>> static int qca_set_speed(struct hci_uart *hu, enum qca_speed_type
>> speed_type)
>> {
>> unsigned int speed, qca_baudrate;
>> + struct qca_serdev *qcadev;
>> int ret;
>>
>> if (speed_type == QCA_INIT_SPEED) {
>> @@ -1097,6 +1087,14 @@ static int qca_set_speed(struct hci_uart *hu,
>> enum qca_speed_type speed_type)
>> if (!speed)
>> return 0;
>>
>> + /* Deassert RTS while changing the baudrate of chip and host.
>> + * This will stop chip to transmit it response with an newer
>> + * baudrate until we change the baudarte.
>
> nit: baudrate
>
> re-nit (to consider if you respin anyway): 'This prevents the chip
> from transmitting its response with the new baudrate while the host
> port is still operating at the old speed'?
> (I'm not a native English speaker, probably there is still room for
> improvement ;-)
[Bala]: will update.
>
> Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
--
Regards
Balakrishna.
next prev parent reply other threads:[~2018-11-27 6:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-22 12:15 [PATCH v2 0/3] Bug fixes for Qualcomm BT chip wcn3990 Balakrishna Godavarthi
2018-11-22 12:15 ` [PATCH v2 1/3] Bluetooth: hci_qca: use wait_until_sent() for power pulses Balakrishna Godavarthi
2018-11-26 19:05 ` Matthias Kaehlcke
2018-11-22 12:15 ` [PATCH v2 2/3] Bluetooth: hci_qca: Deassert RTS while baudrate change command Balakrishna Godavarthi
2018-11-26 19:42 ` Matthias Kaehlcke
2018-11-27 6:41 ` Balakrishna Godavarthi [this message]
2018-11-22 12:15 ` [PATCH v2 3/3] Bluetooth: hci_qca: Fix frame reassembly errors for wcn3990 Balakrishna Godavarthi
2018-11-27 0:09 ` Matthias Kaehlcke
2018-11-27 0:27 ` Matthias Kaehlcke
2018-11-27 7:01 ` Balakrishna Godavarthi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad8de20da986b530dd53d83c96da7b7b@codeaurora.org \
--to=bgodavar@codeaurora.org \
--cc=hemantg@codeaurora.org \
--cc=johan.hedberg@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=mka@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).