From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B0BBC28CC7 for ; Mon, 10 Jun 2019 13:31:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3B74A20862 for ; Mon, 10 Jun 2019 13:31:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390401AbfFJNb6 (ORCPT ); Mon, 10 Jun 2019 09:31:58 -0400 Received: from mail-ed1-f65.google.com ([209.85.208.65]:33764 "EHLO mail-ed1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390221AbfFJNb6 (ORCPT ); Mon, 10 Jun 2019 09:31:58 -0400 Received: by mail-ed1-f65.google.com with SMTP id h9so14591988edr.0 for ; Mon, 10 Jun 2019 06:31:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:from:cc:subject:message-id:date:user-agent :mime-version:content-language:content-transfer-encoding; bh=zHz2UJxUdh3rVwhA5EFSYkJKTVOd6ZuZb4Wud/lpDSg=; b=m79p4C71REXgTQ/JmqFdL8aiWQEWOl/W0l5uaxIGCt4a/Vbaj9EZxTUqzzV956UACS D9kugNbEbj4x+IKUHdxVghEzVodZEyK+6WkDyTGhrZ6K63OSCwkAIqqvNUpvpsfgFHTk WFarG24ltQwghylh4Ph9eWExu49sN3N15twFLJH4M77ZmIGwVqfToqmLQffcdV9jkvgq Ho5LJohKCQe/QIEQAKOm4XUHtWGMtgCHELPLSuyFtRZaqrQwnpjMHOQfYcrzrqnA19Lq Jw4PRsmEoUas/p/ACEH9SFMLvaikRCwcWPM9XW/Fnf1AdEFeRI0TXVMZS8+2Wm9Y8hsa j6/Q== X-Gm-Message-State: APjAAAWZLOuJE6lq4mokztm4/F8hos69d5tqgrGJndGrla22J8m9fher gXe7rEH+Rj8S0hzM8OMNoXhJrV1H6I0= X-Google-Smtp-Source: APXvYqy7j6yOiZLfwFmeashZGQlsG1+Ytyj3AZ7oYct+ix5JgEUtL2nkKriE4NohbcrK4qFIe941ww== X-Received: by 2002:a50:94a2:: with SMTP id s31mr33340960eda.290.1560173516809; Mon, 10 Jun 2019 06:31:56 -0700 (PDT) Received: from shalem.localdomain (84-106-84-65.cable.dynamic.v4.ziggo.nl. [84.106.84.65]) by smtp.gmail.com with ESMTPSA id f9sm1790236ejk.73.2019.06.10.06.31.55 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Mon, 10 Jun 2019 06:31:56 -0700 (PDT) To: Greg Kroah-Hartman , Marcel Holtmann From: Hans de Goede Cc: linux-bluetooth@vger.kernel.org, Jeremy Cline , Linux Kernel Mailing List Subject: Bluetooth regression breaking BT connection for all 2.0 and older devices in 5.0.15+, 5.1.x and master Message-ID: Date: Mon, 10 Jun 2019 15:31:55 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-bluetooth-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org Hi All, First of all this is a known issue and it seems a fix is in the works, but what I do not understand is why the commit causing this has not simply been reverted until the fix is done, esp. for the 5.0.x stable series where this was introduced in 5.0.15. The problem I'm talking about is commit d5bb334a8e17 ("Bluetooth: Align minimum encryption key size for LE and BR/EDR connections"): https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=d5bb334a8e171b262e48f378bd2096c0ea458265 basically completely breaking all somewhat older (and some current cheap no-name) bluetooth devices: A revert of this was first proposed on May 22nd: https://lore.kernel.org/netdev/CA+E=qVfopSA90vG2Kkh+XzdYdNn=M-hJN_AptW=R+B5v3HB9eA@mail.gmail.com/T/ We are 18 days further now and this problem still exists, including in the 5.0.15+ and 5.1.x stable kernels. A solution has been suggested: https://lore.kernel.org/linux-bluetooth/20190522070540.48895-1-marcel@holtmann.org/T/#u and at least the Fedora 5.1.4+ kernels now carry this as a temporary fix, but as of today I do not see a fix nor a revert in Torvald's tree yet and neither does there seem to be any fix in the 5.0.x and 5.1.x stable series. In the mean time we are getting a lot of bug reports about this: https://bugzilla.kernel.org/show_bug.cgi?id=203643 https://bugzilla.redhat.com/show_bug.cgi?id=1711468 https://bugzilla.redhat.com/show_bug.cgi?id=1713871 https://bugzilla.redhat.com/show_bug.cgi?id=1713980 And some reporters: https://bugzilla.redhat.com/show_bug.cgi?id=1713871#c4 Are indicating that the Fedora kernels with the workaround included still do not work... As such I would like to suggest that we just revert the troublesome commit for now and re-add it when we have a proper fix. Regards, Hans