From: shuah <shuah@kernel.org>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: marcel@holtmann.org, johan.hedberg@gmail.com,
viro@zeniv.linux.org.uk, linux-bluetooth@vger.kernel.org,
linux-kernel@vger.kernel.org, shuah <shuah@kernel.org>
Subject: Re: [PATCH v2] tty: Fix WARNING in tty_set_termios()
Date: Fri, 1 Feb 2019 16:21:11 -0700 [thread overview]
Message-ID: <bd8194d1-facd-eed0-4a4c-6404626ccc27@kernel.org> (raw)
In-Reply-To: <20190201001414.GB4886@kroah.com>
On 1/31/19 5:14 PM, Greg KH wrote:
> On Thu, Jan 31, 2019 at 04:23:59PM -0700, Shuah Khan wrote:
>> tty_set_termios() has the following WARN_ON which can be triggered with a
>> syscall to invoke TIOCSETD __NR_ioctl.
>>
>> WARN_ON(tty->driver->type == TTY_DRIVER_TYPE_PTY &&
>> tty->driver->subtype == PTY_TYPE_MASTER);
>> Reference: https://syzkaller.appspot.com/bug?id=2410d22f1d8e5984217329dd0884b01d99e3e48d
>>
>> The problem started with commit 7721383f4199 ("Bluetooth: hci_uart: Support
>> operational speed during setup") which introduced a new way for how
>> tty_set_termios() could end up being called for a master pty.
>>
>> Fix the problem by preventing setting the HCI line discipline for PTYs
>> from hci_uart_setup() and hci_uart_set_flow_control().
>>
>> The reproducer is used to reproduce the problem and verify the fix.
>>
>> Reported-by: syzbot+a950165cbb86bdd023a4@syzkaller.appspotmail.com
>> Signed-off-by: Shuah Khan <shuah@kernel.org>
>> ---
>> drivers/bluetooth/hci_ldisc.c | 11 +++++++++++
>> 1 file changed, 11 insertions(+)
>
> I think the subject should be something like:
> "bluetooth: hci: Fix warning in tty_set_termios()"
> it isn't a tty core problem :)
>
Yes. Sorry about that. Will get it right in my v3.
thanks,
-- Shuah
next prev parent reply other threads:[~2019-02-01 23:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-31 23:23 [PATCH v2] tty: Fix WARNING in tty_set_termios() Shuah Khan
2019-02-01 0:14 ` Greg KH
2019-02-01 23:21 ` shuah [this message]
2019-02-01 9:28 ` Johan Hovold
2019-02-01 9:36 ` Johan Hovold
2019-02-01 23:20 ` shuah
2019-02-01 10:00 ` Marcel Holtmann
2019-02-01 23:18 ` shuah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd8194d1-facd-eed0-4a4c-6404626ccc27@kernel.org \
--to=shuah@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).