From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 786E5C433DB for ; Wed, 27 Jan 2021 11:25:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3645A20781 for ; Wed, 27 Jan 2021 11:25:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S313694AbhAZW6D convert rfc822-to-8bit (ORCPT ); Tue, 26 Jan 2021 17:58:03 -0500 Received: from mail.kernel.org ([198.145.29.99]:58552 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389181AbhAZQ7G (ORCPT ); Tue, 26 Jan 2021 11:59:06 -0500 Received: by mail.kernel.org (Postfix) with ESMTPS id 3C26122EBD for ; Tue, 26 Jan 2021 16:52:15 +0000 (UTC) From: bugzilla-daemon@bugzilla.kernel.org To: linux-bluetooth@vger.kernel.org Subject: [Bug 210681] kernel: Bluetooth: hci0: don't support firmware rome 0x31010000 Date: Tue, 26 Jan 2021 16:52:13 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Drivers X-Bugzilla-Component: Bluetooth X-Bugzilla-Version: 2.5 X-Bugzilla-Keywords: X-Bugzilla-Severity: high X-Bugzilla-Who: moreno.giussani@protonmail.com X-Bugzilla-Status: NEW X-Bugzilla-Resolution: X-Bugzilla-Priority: P1 X-Bugzilla-Assigned-To: linux-bluetooth@vger.kernel.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc attachments.created Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT X-Bugzilla-URL: https://bugzilla.kernel.org/ Auto-Submitted: auto-generated MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org https://bugzilla.kernel.org/show_bug.cgi?id=210681 Moreno G (moreno.giussani@protonmail.com) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |moreno.giussani@protonmail. | |com --- Comment #22 from Moreno G (moreno.giussani@protonmail.com) --- Created attachment 294865 --> https://bugzilla.kernel.org/attachment.cgi?id=294865&action=edit fix hci0: warn only if high rome (In reply to Bradley Jarvis from comment #10) > Created attachment 294393 [details] > fix hci0: don't support firmware rome error > > Avoid returning error code when bluetooth version match is not made from > qca_devices_table and version high is set. > > This reverts an error check that was removed to support WCN6855 which does > have the high version set. The fix is to move the check after the table is > scanned and no version match is made. > > This fix will still produce the error message for example (for ATK3K > 13d3:3402 IMC Networks Bluetooth USB Host Controller) > > Bluetooth: hci0: don't support firmware rome 0x1020200 > > But the bluetooth hardware still works as it used to Like Bradley Jarvis' fix, but it won't produce an error message but a warning message for a possible incompatibility. Reverted the "don't care" comments for other high ROM versions. Just my 2 cents -- You may reply to this email to add a comment. You are receiving this mail because: You are the assignee for the bug.