linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: bugzilla-daemon@bugzilla.kernel.org
To: linux-bluetooth@vger.kernel.org
Subject: [Bug 213829] Intel AX210 Bluetooth controller doesn't start from warm boot
Date: Sun, 17 Oct 2021 18:05:04 +0000	[thread overview]
Message-ID: <bug-213829-62941-EqhONenYdh@https.bugzilla.kernel.org/> (raw)
In-Reply-To: <bug-213829-62941@https.bugzilla.kernel.org/>

https://bugzilla.kernel.org/show_bug.cgi?id=213829

--- Comment #13 from Guillaume Binet (gbin@gootz.net) ---
I continued to investigate. The major difference between a cold boot and a warm
boot is the driver trying to load a firmware.

For the science, I just disabled this behavior and it looks like the device and
driver recover on a warm boot. Consider this a workaround and not a fix but at
least it works for me, bluetooth is available on a warm boot.

```
pal ➜  linux-5.14.12  diff -u drivers/bluetooth/btintel.c.old
drivers/bluetooth/btintel.c 
--- drivers/bluetooth/btintel.c.old     2021-10-17 13:56:23.583338189 -0400
+++ drivers/bluetooth/btintel.c 2021-10-17 14:01:16.113344330 -0400
@@ -1034,17 +1034,6 @@
                /* Skip reading firmware file version in bootloader mode */
                if (ver->fw_variant == 0x06)
                        break;
-
-               /* Skip download if firmware has the same version */
-               if (btintel_firmware_version(hdev, ver->fw_build_num,
-                                            ver->fw_build_ww,
ver->fw_build_yy,
-                                            fw, boot_param)) {
-                       bt_dev_info(hdev, "Firmware already loaded");
-                       /* Return -EALREADY to indicate that the firmware has
-                        * already been loaded.
-                        */
-                       return -EALREADY;
-               }
        }

        /* The firmware variant determines if the device is in bootloader
@@ -1074,21 +1063,6 @@
        int err;
        u32 css_header_ver;

-       /* Skip reading firmware file version in bootloader mode */
-       if (ver->img_type != 0x01) {
-               /* Skip download if firmware has the same version */
-               if (btintel_firmware_version(hdev, ver->min_fw_build_nn,
-                                            ver->min_fw_build_cw,
-                                            ver->min_fw_build_yy,
-                                            fw, boot_param)) {
-                       bt_dev_info(hdev, "Firmware already loaded");
-                       /* Return -EALREADY to indicate that firmware has
-                        * already been loaded.
-                        */
-                       return -EALREADY;
-               }
-       }
-
        /* The firmware variant determines if the device is in bootloader
         * mode or is running operational firmware. The value 0x01 identifies
         * the bootloader and the value 0x03 identifies the operational
```

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are the assignee for the bug.

  parent reply	other threads:[~2021-10-17 18:05 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <bug-213829-62941@https.bugzilla.kernel.org/>
2021-09-10  4:41 ` [Bug 213829] Intel AX210 Bluetooth controller doesn't start from warm boot bugzilla-daemon
2021-10-17 18:05 ` bugzilla-daemon [this message]
2021-11-02 13:57 ` bugzilla-daemon
2021-11-02 20:02 ` bugzilla-daemon
2021-11-11  1:11 ` bugzilla-daemon
2021-11-11  3:12 ` bugzilla-daemon
2021-11-13  3:43 ` bugzilla-daemon
2021-11-13  9:19 ` bugzilla-daemon
2021-11-13 17:55 ` bugzilla-daemon
2021-11-14  8:07 ` bugzilla-daemon
2021-11-14 14:36 ` bugzilla-daemon
2021-11-25 12:19 ` bugzilla-daemon
2021-11-26 14:49 ` bugzilla-daemon
2022-01-02 20:37 ` bugzilla-daemon
2022-01-02 21:07 ` bugzilla-daemon
2022-01-06 12:58 ` bugzilla-daemon
2022-01-06 13:03 ` bugzilla-daemon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-213829-62941-EqhONenYdh@https.bugzilla.kernel.org/ \
    --to=bugzilla-daemon@bugzilla.kernel.org \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).