* [PATCH BlueZ] mesh: Allow apps to receive DevKey messages from external nodes
@ 2020-01-09 10:32 Michał Lowas-Rzechonek
2020-01-14 14:39 ` Gix, Brian
0 siblings, 1 reply; 2+ messages in thread
From: Michał Lowas-Rzechonek @ 2020-01-09 10:32 UTC (permalink / raw)
To: linux-bluetooth
After introducing "remote" flag for DevKeyMessageReceived in
c8cd5b04ccd865deeb90b70ea649c0b6cc0385e6, we can now allow applications
to received DevKey messages from external addresses as well as from
local ones.
This enables applications to properly implement models using DevKey
security, by accepting only requests with "remote" flag set to false.
---
mesh/model.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/mesh/model.c b/mesh/model.c
index acdd94f7b..6d7674ee5 100644
--- a/mesh/model.c
+++ b/mesh/model.c
@@ -1066,8 +1066,7 @@ bool mesh_model_rx(struct mesh_node *node, bool szmict, uint32_t seq0,
forward.app_idx, forward.size,
forward.data);
else if (decrypt_idx == APP_IDX_DEV_REMOTE ||
- (decrypt_idx == APP_IDX_DEV_LOCAL &&
- mesh_net_is_local_address(net, src, 1)))
+ decrypt_idx == APP_IDX_DEV_LOCAL)
send_dev_key_msg_rcvd(node, i, src, decrypt_idx,
0, forward.size, forward.data);
}
--
2.19.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH BlueZ] mesh: Allow apps to receive DevKey messages from external nodes
2020-01-09 10:32 [PATCH BlueZ] mesh: Allow apps to receive DevKey messages from external nodes Michał Lowas-Rzechonek
@ 2020-01-14 14:39 ` Gix, Brian
0 siblings, 0 replies; 2+ messages in thread
From: Gix, Brian @ 2020-01-14 14:39 UTC (permalink / raw)
To: michal.lowas-rzechonek, linux-bluetooth
Applied
On Thu, 2020-01-09 at 11:32 +0100, Michał Lowas-Rzechonek wrote:
> After introducing "remote" flag for DevKeyMessageReceived in
> c8cd5b04ccd865deeb90b70ea649c0b6cc0385e6, we can now allow applications
> to received DevKey messages from external addresses as well as from
> local ones.
>
> This enables applications to properly implement models using DevKey
> security, by accepting only requests with "remote" flag set to false.
> ---
> mesh/model.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/mesh/model.c b/mesh/model.c
> index acdd94f7b..6d7674ee5 100644
> --- a/mesh/model.c
> +++ b/mesh/model.c
> @@ -1066,8 +1066,7 @@ bool mesh_model_rx(struct mesh_node *node, bool szmict, uint32_t seq0,
> forward.app_idx, forward.size,
> forward.data);
> else if (decrypt_idx == APP_IDX_DEV_REMOTE ||
> - (decrypt_idx == APP_IDX_DEV_LOCAL &&
> - mesh_net_is_local_address(net, src, 1)))
> + decrypt_idx == APP_IDX_DEV_LOCAL)
> send_dev_key_msg_rcvd(node, i, src, decrypt_idx,
> 0, forward.size, forward.data);
> }
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-01-14 14:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-09 10:32 [PATCH BlueZ] mesh: Allow apps to receive DevKey messages from external nodes Michał Lowas-Rzechonek
2020-01-14 14:39 ` Gix, Brian
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).