linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Stotland, Inga" <inga.stotland@intel.com>
To: "michal.lowas-rzechonek@silvair.com" 
	<michal.lowas-rzechonek@silvair.com>
Cc: "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
Subject: Re: [PATCH RESEND BlueZ 1/1] mesh: Add --io option
Date: Tue, 14 Jan 2020 22:25:27 +0000	[thread overview]
Message-ID: <d84d8e72b13cc720b6605a9d26d1d7d5c0a6c257.camel@intel.com> (raw)
In-Reply-To: <20200114200948.xgy2idbjcmhqybdm@kynes>

Hi Michal,

On Tue, 2020-01-14 at 21:09 +0100, michal.lowas-rzechonek@silvair.com
wrote:
> Hi Inga,
> 
> On 01/14, Stotland, Inga wrote:
> > I wonder if it would be better to re-use "-i" option by changing it's
> > meaning form "index" to "i/o".
> > 
> > So that " -i hci<#>" will map to generic i/o on a specified controller
> > and no "-i" option means any controller.
> >  
> > Yes, we will loose some uniformity across all of the bluez in a sense
> > that "-i <#>" won't work, but imo it's preferable to having two options
> > with inter-dependecies.
> 
> Hm, might be... The reason I added the "--io=<type>:<options>" was the
> "<options>" part.
> 
> For example, we have a non-HCI radio adapter that uses
> "--io=uart:/dev/tty<n>" syntax, or remote radio using
> "--io=tcp:<host>:<port>" syntax.
> 
> So maybe I could parse  "-i <n>" and  "-i hci<n>" (where <n> is a
> number) as a shortcut for "-i generic:hci<n>"?
> 
> That would allow us to merge both options and rename "--index" to
> "--io".
> 

Yes, I'd be fine with this kind of change. Depending on the type,
we would know how to parse the options. With the fallback to legacy
cases:
	* no option given: generic, any controller
	* "-i <hci#>" or -i <#> : generic with the specified controller

Thank you,

Inga

      reply	other threads:[~2020-01-14 22:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-13 12:27 [PATCH RESEND BlueZ 0/1] Select mesh-io from command line Michał Lowas-Rzechonek
2020-01-13 12:27 ` [PATCH RESEND BlueZ 1/1] mesh: Add --io option Michał Lowas-Rzechonek
2020-01-14 19:38   ` Stotland, Inga
2020-01-14 20:09     ` michal.lowas-rzechonek
2020-01-14 22:25       ` Stotland, Inga [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d84d8e72b13cc720b6605a9d26d1d7d5c0a6c257.camel@intel.com \
    --to=inga.stotland@intel.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=michal.lowas-rzechonek@silvair.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).