From: quic_zijuhu <quic_zijuhu@quicinc.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
<luiz.dentz@gmail.com>, <luiz.von.dentz@intel.com>,
<marcel@holtmann.org>
Cc: <linux-bluetooth@vger.kernel.org>,
<bartosz.golaszewski@linaro.org>, <wt@penguintechs.org>,
<regressions@lists.linux.dev>, <kernel@quicinc.com>
Subject: Re: [PATCH v6 1/2] Bluetooth: qca: Fix BT enable failure for QCA6390
Date: Wed, 24 Apr 2024 12:07:24 +0800 [thread overview]
Message-ID: <e8cd122d-e342-45c2-b078-a4ca2d8dcfff@quicinc.com> (raw)
In-Reply-To: <349b27a5-d2d3-46f1-b002-44f81e0cedef@linaro.org>
On 4/24/2024 12:06 PM, Krzysztof Kozlowski wrote:
> On 24/04/2024 02:46, Zijun Hu wrote:
>> Commit 56d074d26c58 ("Bluetooth: hci_qca: don't use IS_ERR_OR_NULL()
>> with gpiod_get_optional()") will cause below serious regression issue:
>>
>> BT can't be enabled any more after below steps:
>> cold boot -> enable BT -> disable BT -> BT enable failure
>> if property enable-gpios is not configured within DT|ACPI for QCA6390.
>>
>> The commit wrongly changes flag @power_ctrl_enabled set logic for this
>> case as shown by its below code applet and causes this serious issue.
>> qcadev->bt_en = devm_gpiod_get_optional(&serdev->dev, "enable",
>> GPIOD_OUT_LOW);
>> - if (IS_ERR_OR_NULL(qcadev->bt_en)) {
>> + if (IS_ERR(qcadev->bt_en)) {
>> dev_warn(&serdev->dev, "failed to acquire enable gpio\n");
>> power_ctrl_enabled = false;
>> }
>>
>> Fixed by reverting the mentioned commit for QCA6390.
>>
>> Fixes: 56d074d26c58 ("Bluetooth: hci_qca: don't use IS_ERR_OR_NULL() with gpiod_get_optional()")
>> Reported-by: Wren Turkal <wt@penguintechs.org>
>> Link: https://bugzilla.kernel.org/show_bug.cgi?id=218726
>> Link: https://lore.kernel.org/linux-bluetooth/ea20bb9b-6b60-47fc-ae42-5eed918ad7b4@quicinc.com/T/#m73d6a71d2f454bb03588c66f3ef7912274d37c6f
>> Signed-off-by: Zijun Hu <quic_zijuhu@quicinc.com>
>> Tested-by: Wren Turkal <wt@penguintechs.org>
>
> No, Bartosz' patch should go.
>
what is Bartosz' patch.
> Best regards,
> Krzysztof
>
next prev parent reply other threads:[~2024-04-24 4:07 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-24 0:46 [PATCH v6 0/2] Fix two BT regression issues for QCA6390 Zijun Hu
2024-04-24 0:46 ` [PATCH v6 1/2] Bluetooth: qca: Fix BT enable failure " Zijun Hu
2024-04-24 2:40 ` Fix two BT regression issues " bluez.test.bot
2024-04-24 3:21 ` [PATCH v6 1/2] Bluetooth: qca: Fix BT enable failure " Greg KH
2024-04-24 4:06 ` Krzysztof Kozlowski
2024-04-24 4:07 ` quic_zijuhu [this message]
2024-04-24 4:10 ` Krzysztof Kozlowski
2024-04-24 4:18 ` quic_zijuhu
2024-04-24 4:31 ` Krzysztof Kozlowski
2024-04-24 4:33 ` quic_zijuhu
2024-04-24 5:04 ` Wren Turkal
2024-04-24 5:33 ` quic_zijuhu
2024-04-24 13:56 ` Luiz Augusto von Dentz
2024-04-24 14:01 ` quic_zijuhu
2024-04-25 17:37 ` Elliot Berman
2024-04-26 2:45 ` quic_zijuhu
2024-04-24 13:49 ` Luiz Augusto von Dentz
2024-04-24 13:51 ` quic_zijuhu
2024-04-24 13:52 ` Bartosz Golaszewski
2024-04-24 13:53 ` quic_zijuhu
2024-04-24 14:00 ` Bartosz Golaszewski
2024-04-24 14:08 ` quic_zijuhu
2024-04-24 14:08 ` Luiz Augusto von Dentz
2024-04-24 14:12 ` quic_zijuhu
2024-04-24 14:19 ` Bartosz Golaszewski
2024-04-24 14:25 ` quic_zijuhu
2024-04-24 14:41 ` Bartosz Golaszewski
2024-04-24 14:44 ` Krzysztof Kozlowski
2024-04-24 14:46 ` quic_zijuhu
2024-04-24 15:31 ` Luiz Augusto von Dentz
2024-04-24 15:42 ` quic_zijuhu
2024-04-24 14:02 ` Luiz Augusto von Dentz
2024-04-24 0:46 ` [PATCH v6 2/2] Bluetooth: qca: Fix BT enable failure for QCA6390 after disable then warm reboot Zijun Hu
2024-04-24 3:22 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e8cd122d-e342-45c2-b078-a4ca2d8dcfff@quicinc.com \
--to=quic_zijuhu@quicinc.com \
--cc=bartosz.golaszewski@linaro.org \
--cc=kernel@quicinc.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=luiz.von.dentz@intel.com \
--cc=marcel@holtmann.org \
--cc=regressions@lists.linux.dev \
--cc=wt@penguintechs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).