From: "Przemysław Fierek" <przemyslaw.fierek@silvair.com>
To: Brian Gix <brian.gix@intel.com>, linux-bluetooth@vger.kernel.org
Cc: michal.lowas-rzechonek@silvair.com
Subject: Re: [PATCH BlueZ] mesh: Fix node composition change detection
Date: Thu, 16 Jul 2020 11:42:37 +0200 [thread overview]
Message-ID: <fed43837-fd44-c5ac-6d89-f2d167936a47@silvair.com> (raw)
In-Reply-To: <20200715153343.2115695-1-brian.gix@intel.com>
LGTM and solves problem. Please merge it.
/PF
On 15.07.2020 17:33, Brian Gix wrote:
> This fixes a bug that caused disallowed composition changes from being
> detected and rejected. The only fields that are allowed to freely change
> are CID, PID, VID and CRPL.
> ---
> mesh/node.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mesh/node.c b/mesh/node.c
> index c61167bda..9b97aa927 100644
> --- a/mesh/node.c
> +++ b/mesh/node.c
> @@ -1579,7 +1579,7 @@ static bool check_req_node(struct managed_obj_request *req)
> node = req->node;
>
> node_comp = node_get_comp(node, 0, &node_len);
> - len = node_generate_comp(node, comp, sizeof(comp));
> + len = node_generate_comp(req->node, comp, sizeof(comp));
>
> /* If no page 0 exists, save it and return */
> if (req->type != REQUEST_TYPE_ATTACH || !node_len || !node_comp)
next prev parent reply other threads:[~2020-07-16 9:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-15 15:33 [PATCH BlueZ] mesh: Fix node composition change detection Brian Gix
2020-07-16 9:42 ` Przemysław Fierek [this message]
2020-07-16 17:05 ` Gix, Brian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fed43837-fd44-c5ac-6d89-f2d167936a47@silvair.com \
--to=przemyslaw.fierek@silvair.com \
--cc=brian.gix@intel.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=michal.lowas-rzechonek@silvair.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).