From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECC4CC43331 for ; Fri, 6 Sep 2019 11:31:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BD21720842 for ; Fri, 6 Sep 2019 11:31:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567769490; bh=iogpGBQG7jXWKjVA6uZiFSlDPTuY7gAzoeRO+2zCtHs=; h=Date:From:To:cc:Subject:In-Reply-To:References:List-ID:From; b=ZYBH6IqpXaO4zna08G06UxfAnC7QdLjlDtMeZKv38VQZqGviOIxaIh7+BnBne/xfH SjK51YUumh+QLjtS8jhVla3rkGWhjhrMhh2XbiKuN9pppIm0i+cc8sYzbacnIFT39K kTSV7ILJ1m1+CYS4uPKLmqgTtVuaHsqXqxeUAn/E= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388752AbfIFLb0 (ORCPT ); Fri, 6 Sep 2019 07:31:26 -0400 Received: from mail.kernel.org ([198.145.29.99]:34946 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732984AbfIFLb0 (ORCPT ); Fri, 6 Sep 2019 07:31:26 -0400 Received: from pobox.suse.cz (prg-ext-pat.suse.com [213.151.95.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B45BF2070C; Fri, 6 Sep 2019 11:31:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567769485; bh=iogpGBQG7jXWKjVA6uZiFSlDPTuY7gAzoeRO+2zCtHs=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=yd935ui4dpymxpEuwbJ9LbamdQt/qCxtr11s6AswOEey2QNt0zao+eKe1PGz31BI9 qaxLcPg2RwxbttqksqxBVWxamHtR6qlHLzyA6E84hTviaChQOWijY1jvQWb62xfDQE RXUaBanQkhqp0kgzGLXNcniuXFSNNufTqL3iRwQM= Date: Fri, 6 Sep 2019 13:31:06 +0200 (CEST) From: Jiri Kosina To: Dan Elkouby cc: Dan Carpenter , Benjamin Tissoires , Marcel Holtmann , Johan Hedberg , "David S. Miller" , Brian Norris , Fabian Henneke , Al Viro , Andrea Parri , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH] Bluetooth: hidp: Fix assumptions on the return value of hidp_send_message In-Reply-To: <20190906110645.27601-1-streetwalkermc@gmail.com> Message-ID: References: <20190906101306.GA12017@kadam> <20190906110645.27601-1-streetwalkermc@gmail.com> User-Agent: Alpine 2.21 (LSU 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-bluetooth-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org On Fri, 6 Sep 2019, Dan Elkouby wrote: > hidp_send_message was changed to return non-zero values on success, > which some other bits did not expect. This caused spurious errors to be > propagated through the stack, breaking some drivers, such as hid-sony > for the Dualshock 4 in Bluetooth mode. > > As pointed out by Dan Carpenter, hid-microsoft directly relied on that > assumption as well. > > Fixes: 48d9cc9d85dd ("Bluetooth: hidp: Let hidp_send_message return number of queued bytes") > > Signed-off-by: Dan Elkouby Reviewed-by: Jiri Kosina Marcel, are you taking this through your tree? Thanks, -- Jiri Kosina SUSE Labs