From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3AFCC432C0 for ; Mon, 25 Nov 2019 19:47:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 937C22071E for ; Mon, 25 Nov 2019 19:47:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574711255; bh=+eM5mPZ+ZRH1qTFqS68sUyGXgTyEcEiIux4n3xdq7Sc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:In-Reply-To: References:List-ID:From; b=Eyv9MheLuCm+6SqPoqH5lspvyMAn/YCNlmP/WzBgPQH5O2VGanH3c7kuPnlAj61bQ LYMXdOrCXorJdPpRPcuRoiGFMAcFwAtBEzxH9L20lcUjEqWaCt+ha7iGzLyVMEvVmf 7SgnaVrRtjrmW5FjOcua7t8vKavmyjfcvcjc3eIU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727205AbfKYTre (ORCPT ); Mon, 25 Nov 2019 14:47:34 -0500 Received: from mail-qv1-f67.google.com ([209.85.219.67]:39883 "EHLO mail-qv1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727197AbfKYTrd (ORCPT ); Mon, 25 Nov 2019 14:47:33 -0500 Received: by mail-qv1-f67.google.com with SMTP id v16so6272345qvq.6 for ; Mon, 25 Nov 2019 11:47:32 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=bWkEItJsrciCUsqYOdkuyqGCVe7sz9XQCB/6ACz1IpE=; b=PEJiShX9CiHL8LcMjKdX8ICWwBV5K3UqumL22B4FibO04/DBbFi+IJGLGaLuWyeATv P6ftZYR5JUkDP6BQtqg2WRrq2T3Xoe7jliNsHD859/ZCXh2cGVi6dsMHlxSUXVg+FscO lBd/og4Mcs5NV3xGNPNDp9FZjD035TfPEm1Egxzl4nREpvZPrzq4vTPH1O61CJ05dhnC bEJFlnF2Pr3FLqOZ8xyM4isaDxGWk7nFkKUXo49QfV405dlO2UOYmIddn68Cgpjtq9RU g2n/VHo6a6weQdwlEPz47KpSNl8YReGJSI3RTfAXQmAuMk18/+Y6Z0ZGYokc06DvBoL4 NYog== X-Gm-Message-State: APjAAAWzvZPCahLQLJQpKwrvONCRDW/q2MelnyxIXtuVbkKMvFRcW1ej pQZqTqm5ihmxnQ20MyVhyiA= X-Google-Smtp-Source: APXvYqw7Lygdp+cR3wdX1ku3Yjk85gBii3Ov/hPddgXuVUty47Z/ntOod3Pb5Xajht5cGcCP2edn+A== X-Received: by 2002:ad4:4391:: with SMTP id s17mr14806489qvr.232.1574711251669; Mon, 25 Nov 2019 11:47:31 -0800 (PST) Received: from dennisz-mbp.thefacebook.com ([163.114.130.128]) by smtp.gmail.com with ESMTPSA id o13sm4481033qto.96.2019.11.25.11.47.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 25 Nov 2019 11:47:31 -0800 (PST) From: Dennis Zhou To: David Sterba , Chris Mason , Josef Bacik , Omar Sandoval Cc: kernel-team@fb.com, linux-btrfs@vger.kernel.org, Dennis Zhou Subject: [PATCH 22/22] btrfs: make smaller extents more likely to go into bitmaps Date: Mon, 25 Nov 2019 14:47:02 -0500 Message-Id: <048ac58fcc4d6147a0025b4a6021f773d736adb5.1574709825.git.dennis@kernel.org> X-Mailer: git-send-email 2.13.5 In-Reply-To: References: In-Reply-To: References: Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org Archived-At: List-Archive: List-Post: It's less than ideal for small extents to eat into our extent budget, so force extents <= 32KB into the bitmaps save for the first handful. Signed-off-by: Dennis Zhou Reviewed-by: Josef Bacik --- fs/btrfs/free-space-cache.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/btrfs/free-space-cache.c b/fs/btrfs/free-space-cache.c index 15667095c50d..9167be1e27bf 100644 --- a/fs/btrfs/free-space-cache.c +++ b/fs/btrfs/free-space-cache.c @@ -2108,8 +2108,8 @@ static bool use_bitmap(struct btrfs_free_space_ctl *ctl, * of cache left then go ahead an dadd them, no sense in adding * the overhead of a bitmap if we don't have to. */ - if (info->bytes <= fs_info->sectorsize * 4) { - if (ctl->free_extents * 2 <= ctl->extents_thresh) + if (info->bytes <= fs_info->sectorsize * 8) { + if (ctl->free_extents * 3 <= ctl->extents_thresh) return false; } else { return false; -- 2.17.1