linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Holger Hoffstätte" <holger@applied-asynchrony.com>
To: Pete <pete@petezilla.co.uk>,
	Linux BTRFS Mailinglist <linux-btrfs@vger.kernel.org>
Subject: Re: Balance conversion to metadata RAID1, data RAID1 leaves some metadata as DUP
Date: Sun, 8 Sep 2019 11:48:07 +0200	[thread overview]
Message-ID: <05971f6b-4b4f-c20b-2a1d-fb61a200a16b@applied-asynchrony.com> (raw)
In-Reply-To: <c00a206b-ac20-9312-498f-6fbf1ffd1295@petezilla.co.uk>

On 9/8/19 11:18 AM, Pete wrote:
> On 9/8/19 8:57 AM, Holger Hoffstätte wrote:
>> On 9/8/19 9:09 AM, Pete wrote:
>> (snip)
>>> I presume running another balance will fix this, but surely all metadata
>>> should have been converted?  Is there a way to only balance the DUP
>>> metadata?
>>
>> Adding "soft" to -mconvert should do exactly that; it will then skip
>> any chunks that are already in the target profile.
>>
>> -h
> 
> Appreciated.  Fixed it, very rapidly, with:
> 
> btrfs bal start -mconvert=raid1,soft  /home_data
> 
> I think a few examples on the wiki page would be helpful.  As I don't do
> this sort of maintenance every day I looked at the filter section on the
> wiki / man pages online following your prompting and was adding
> 'type=soft' in various places with no success and it was about the 3rd
> reading of the relevant area where I cam up with the above which worked.

IMHO 'soft' should just be the implicit default behaviour for convert,
since it almost always does what one would expect when converting.
I can't think of a good reason why it shouldn't be, but maybe there is
one - Dave?

-h

  reply	other threads:[~2019-09-08  9:48 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-08  7:09 Balance conversion to metadata RAID1, data RAID1 leaves some metadata as DUP Pete
2019-09-08  7:57 ` Holger Hoffstätte
2019-09-08  9:18   ` Pete
2019-09-08  9:48     ` Holger Hoffstätte [this message]
2019-09-09  8:28 ` Andrei Borzenkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=05971f6b-4b4f-c20b-2a1d-fb61a200a16b@applied-asynchrony.com \
    --to=holger@applied-asynchrony.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=pete@petezilla.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).