From: Nikolay Borisov <nborisov@suse.com>
To: Qu Wenruo <wqu@suse.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs: Make btrfs_finish_extent_commit() return void
Date: Tue, 16 Apr 2019 08:19:40 +0300 [thread overview]
Message-ID: <06a0ea0b-dfbf-67ea-3d7a-e3943e786c06@suse.com> (raw)
In-Reply-To: <20190416051637.18548-1-wqu@suse.com>
On 16.04.19 г. 8:16 ч., Qu Wenruo wrote:
> This function always return 0, and the only use case of @ret is to
> output warning message for discard failure, which doesn't cause anything
> wrong to the fs even discarding failed.
>
> There is no need to make it return int.
>
> Signed-off-by: Qu Wenruo <wqu@suse.com>
Reviewed-by: Nikolay Borisov <nborisov@suse.com>
> ---
> fs/btrfs/ctree.h | 2 +-
> fs/btrfs/extent-tree.c | 4 +---
> 2 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/fs/btrfs/ctree.h b/fs/btrfs/ctree.h
> index b3642367a595..129f7520dc5f 100644
> --- a/fs/btrfs/ctree.h
> +++ b/fs/btrfs/ctree.h
> @@ -2758,7 +2758,7 @@ int btrfs_free_reserved_extent(struct btrfs_fs_info *fs_info,
> int btrfs_free_and_pin_reserved_extent(struct btrfs_fs_info *fs_info,
> u64 start, u64 len);
> void btrfs_prepare_extent_commit(struct btrfs_fs_info *fs_info);
> -int btrfs_finish_extent_commit(struct btrfs_trans_handle *trans);
> +void btrfs_finish_extent_commit(struct btrfs_trans_handle *trans);
> int btrfs_inc_extent_ref(struct btrfs_trans_handle *trans,
> struct btrfs_root *root,
> u64 bytenr, u64 num_bytes, u64 parent,
> diff --git a/fs/btrfs/extent-tree.c b/fs/btrfs/extent-tree.c
> index c5880329ae37..87a963d819c3 100644
> --- a/fs/btrfs/extent-tree.c
> +++ b/fs/btrfs/extent-tree.c
> @@ -6907,7 +6907,7 @@ static int unpin_extent_range(struct btrfs_fs_info *fs_info,
> return 0;
> }
>
> -int btrfs_finish_extent_commit(struct btrfs_trans_handle *trans)
> +void btrfs_finish_extent_commit(struct btrfs_trans_handle *trans)
> {
> struct btrfs_fs_info *fs_info = trans->fs_info;
> struct btrfs_block_group_cache *block_group, *tmp;
> @@ -6971,8 +6971,6 @@ int btrfs_finish_extent_commit(struct btrfs_trans_handle *trans)
> ret, errstr);
> }
> }
> -
> - return 0;
> }
>
> static int __btrfs_free_extent(struct btrfs_trans_handle *trans,
>
next prev parent reply other threads:[~2019-04-16 5:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-16 5:16 [PATCH] btrfs: Make btrfs_finish_extent_commit() return void Qu Wenruo
2019-04-16 5:19 ` Nikolay Borisov [this message]
2019-04-24 16:34 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=06a0ea0b-dfbf-67ea-3d7a-e3943e786c06@suse.com \
--to=nborisov@suse.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).