From: Anand Jain <anand.jain@oracle.com>
To: Qu Wenruo <wqu@suse.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v2.1 08/10] btrfs-progs: image: Introduce -d option to dump data
Date: Mon, 15 Jul 2019 12:09:05 +0800 [thread overview]
Message-ID: <0909bbd0-5e22-8826-e067-8d38cffa91c7@oracle.com> (raw)
In-Reply-To: <20190704061103.20096-9-wqu@suse.com>
On 4/7/19 2:11 PM, Qu Wenruo wrote:
> static int copy_from_extent_tree(struct metadump_struct *metadump,
> - struct btrfs_path *path)
> + struct btrfs_path *path, bool dump_data)
> {
> struct btrfs_root *extent_root;
> struct extent_buffer *leaf;
> @@ -948,9 +960,15 @@ static int copy_from_extent_tree(struct metadump_struct *metadump,
> ei = btrfs_item_ptr(leaf, path->slots[0],
> struct btrfs_extent_item);
> if (btrfs_extent_flags(leaf, ei) &
> - BTRFS_EXTENT_FLAG_TREE_BLOCK) {
> + BTRFS_EXTENT_FLAG_TREE_BLOCK ||
> + btrfs_extent_flags(leaf, ei) &
> + BTRFS_EXTENT_FLAG_DATA) {
> + bool is_data;
> +
> + is_data = btrfs_extent_flags(leaf, ei) &
> + BTRFS_EXTENT_FLAG_DATA;
> ret = add_extent(bytenr, num_bytes, metadump,
> - 0);
> + is_data);
Both with and without -d option copies the data.
Should check dump_data.
Thanks, Anand
next prev parent reply other threads:[~2019-07-15 4:10 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-04 6:10 [PATCH v2.1 00/10] btrfs-progs: image: Enhancement with new data dump feature Qu Wenruo
2019-07-04 6:10 ` [PATCH v2.1 01/10] btrfs-progs: image: Output error message for chunk tree build error Qu Wenruo
2019-07-04 6:10 ` [PATCH v2.1 02/10] btrfs-progs: image: Fix error output to show correct return value Qu Wenruo
2019-07-04 6:10 ` [PATCH v2.1 03/10] btrfs-progs: image: Don't waste memory when we're just extracting super block Qu Wenruo
2019-07-04 6:10 ` [PATCH v2.1 04/10] btrfs-progs: image: Allow restore to record system chunk ranges for later usage Qu Wenruo
2019-07-04 6:10 ` [PATCH v2.1 05/10] btrfs-progs: image: Introduce helper to determine if a tree block is in the range of system chunks Qu Wenruo
2019-07-04 6:10 ` [PATCH v2.1 06/10] btrfs-progs: image: Rework how we search chunk tree blocks Qu Wenruo
2019-07-04 6:11 ` [PATCH v2.1 07/10] btrfs-progs: image: Introduce framework for more dump versions Qu Wenruo
2019-07-04 6:11 ` [PATCH v2.1 08/10] btrfs-progs: image: Introduce -d option to dump data Qu Wenruo
2019-07-15 3:57 ` Anand Jain
2019-07-15 4:09 ` Anand Jain [this message]
2019-07-04 6:11 ` [PATCH v2.1 09/10] btrfs-progs: image: Reduce memory requirement for decompression Qu Wenruo
2019-07-04 6:11 ` [PATCH v2.1 10/10] btrfs-progs: image: Reduce memory usage for chunk tree search Qu Wenruo
2019-09-19 7:19 ` [PATCH v2.1 00/10] btrfs-progs: image: Enhancement with new data dump feature WenRuo Qu
2019-09-24 11:31 ` Anand Jain
2019-09-24 11:40 ` Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0909bbd0-5e22-8826-e067-8d38cffa91c7@oracle.com \
--to=anand.jain@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).