From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Mason Subject: Re: Btrfs for mainline Date: Sat, 03 Jan 2009 15:17:36 -0500 Message-ID: <1231013856.7538.89.camel@think.oraclecorp.com> References: <1230722935.4680.5.camel@think.oraclecorp.com> <20081231104533.abfb1cf9.akpm@linux-foundation.org> <1230765549.7538.8.camel@think.oraclecorp.com> <87r63ljzox.fsf@basil.nowhere.org> <20090103191706.GA2002@parisc-linux.org> <20090103195034.GA27541@infradead.org> Mime-Version: 1.0 Content-Type: text/plain Cc: Matthew Wilcox , Andi Kleen , Andrew Morton , linux-kernel@vger.kernel.org, linux-fsdevel , linux-btrfs To: Christoph Hellwig Return-path: In-Reply-To: <20090103195034.GA27541@infradead.org> List-ID: On Sat, 2009-01-03 at 14:50 -0500, Christoph Hellwig wrote: > On Sat, Jan 03, 2009 at 12:17:06PM -0700, Matthew Wilcox wrote: > > > > - compat.h needs to go > > > > Later. It's still there for XFS. > > ? > > > - there should be manpages for all the ioctls and other interfaces. > > > > I wonder if Michael Kerrisk has time to help with that. Cc'd. > > Actually a lot of the ioctl API don't just need documentation but > a complete redo. That's true at least for the physical device > management and subvolume / snaphot ones. > The ioctl interface is definitely not finalized. Adding more vs replacing the existing ones is an open question. > > > - various checkpath.pl level problems I think (e.g. printk levels) > > > > Can be fixed up later. > > > > > - the printks should all include which file system they refer to > > > > Ditto. > > >From painfull experience with a lot of things, including a filesystem > you keep on mentioning it's clear that once stuff is upstream there > is very little to no incentive to fix these things up. > I'd disagree here. Cleanup incentive is a mixture of the people involved and the attention the project has. -chris