From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from userp1040.oracle.com ([156.151.31.81]:48112 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751993AbaEVKi1 (ORCPT ); Thu, 22 May 2014 06:38:27 -0400 From: Anand Jain To: linux-btrfs@vger.kernel.org Cc: dsterba@suse.cz, sandeen@redhat.com, rm@romanrm.net Subject: [PATCH 2/2 v3] btrfs: usage error should not be logged into system log Date: Thu, 22 May 2014 18:41:12 +0800 Message-Id: <1400755272-22590-2-git-send-email-anand.jain@oracle.com> In-Reply-To: <1400755272-22590-1-git-send-email-anand.jain@oracle.com> References: <1400519071-5580-1-git-send-email-anand.jain@oracle.com> <1400755272-22590-1-git-send-email-anand.jain@oracle.com> Sender: linux-btrfs-owner@vger.kernel.org List-ID: From: Anand Jain I have an opinion that system logs /var/log/messages are valuable info to investigate the real system issues at the data center. People handling data center issues do spend a lot time and efforts analyzing messages files. Having usage error logged into /var/log/messages is something we should avoid. Signed-off-by: Anand Jain Reviewed-by: David Sterba --- v3: rebase again v2: rebase fs/btrfs/sysfs.c | 5 +---- 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/fs/btrfs/sysfs.c b/fs/btrfs/sysfs.c index 159df4f..c81b499 100644 --- a/fs/btrfs/sysfs.c +++ b/fs/btrfs/sysfs.c @@ -381,11 +381,8 @@ static ssize_t btrfs_label_store(struct kobject *kobj, */ p_len = strcspn(buf, "\n"); - if (p_len >= BTRFS_LABEL_SIZE) { - pr_err("BTRFS: unable to set label with more than %d bytes\n", - BTRFS_LABEL_SIZE - 1); + if (p_len >= BTRFS_LABEL_SIZE) return -EINVAL; - } trans = btrfs_start_transaction(root, 0); if (IS_ERR(trans)) -- 1.7.1