linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Anand Jain <anand.jain@oracle.com>
To: linux-btrfs@vger.kernel.org
Subject: [PATCH RFC 0/5] readmirror feature
Date: Tue, 19 Mar 2019 18:00:19 +0800	[thread overview]
Message-ID: <1552989624-29577-1-git-send-email-anand.jain@oracle.com> (raw)

RFC patch as of now, appreciate your comments. This patch set has
been tested.

Function call chain  __btrfs_map_block()->find_live_mirror() uses
thread pid to determine the %mirror_num when the mirror_num=0.
    
The pid based mirror_num extrapolation has following disadvantages
 . A large single-process read IO will read only from one disk.
 . In a worst scenario all processes read accessing the FS could have
       either odd or even pid, the read IO gets skewed.
 . There is no deterministic way of knowing/controlling which copy will
       be used for reading.
 . May see performance variations for a given set of multi process
       workload ran at different times.
    
So we need other types of readmirror policies.
    
This patch introduces a framework so that we can add more policies, and
converts the existing %pid into as a configurable parameter using the
property. And also provides a transient readmirror mount option, so that
this property can be applied for the read io during mount and for
readonly FS.

 For example:
   btrfs property set <mnt> readmirror pid
   btrfs property set <mnt> readmirror ""
   btrfs property set <mnt> readmirror devid<n>

   mount -o readmirror=pid <mnt>
   mount -o readmirror=devid<n> <mnt>

Please note:
 The property storage is an extented attributes of root inode
 (BTRFS_FS_TREE_OBJECTID), the other choice is a new ondisk KEY,
 which is open for comments.

 This patch uses the unused btrfs_device::type, and does not use the
 bitwise ops because as type is u64 and bitwise ops need u32, so we
 need 32bits of the btrfs_device::type. Which is a kind of messy.
 Its open for suggestion for any better way.

Anand Jain (5):
  btrfs: add inode pointer to prop_handler::validate()
  btrfs: add readmirror pid property
  btrfs: add readmirror devid property
  btrfs: add readmirror pid mount option
  btrfs: add readmirror devid mount option

 fs/btrfs/props.c   | 99 +++++++++++++++++++++++++++++++++++++++++++++++++++---
 fs/btrfs/super.c   | 29 ++++++++++++++++
 fs/btrfs/volumes.c | 29 +++++++++++++++-
 fs/btrfs/volumes.h | 11 ++++++
 4 files changed, 163 insertions(+), 5 deletions(-)

Anand Jain (2):
  btrfs-progs: add helper to create xattr name
  btrfs-progs: add readmirror policy

 props.c | 75 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++------
 1 file changed, 68 insertions(+), 7 deletions(-)
-- 
1.8.3.1

             reply	other threads:[~2019-03-19 10:00 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-19 10:00 Anand Jain [this message]
2019-03-19 10:00 ` [PATCH RFC 1/5] btrfs: add inode pointer to prop_handler::validate() Anand Jain
2019-03-19 10:00 ` [PATCH RFC 2/5] btrfs: add readmirror pid property Anand Jain
2019-03-19 10:00 ` [PATCH RFC 3/5] btrfs: add readmirror devid property Anand Jain
2019-03-19 10:00 ` [PATCH RFC 4/5] btrfs: add readmirror pid mount option Anand Jain
2019-03-19 10:00 ` [PATCH RFC 5/5] btrfs: add readmirror devid " Anand Jain
2019-03-19 10:02 ` [PATCH RFC 1/2] btrfs-progs: add helper to create xattr name Anand Jain
2019-03-19 10:02   ` [PATCH RFC 2/2] btrfs-progs: add readmirror policy Anand Jain
2019-03-21 16:26 ` [PATCH RFC 0/5] readmirror feature Steven Davies
2019-03-21 18:26   ` waxhead
2019-03-22  6:08   ` Anand Jain
2019-04-09 15:48 ` David Sterba
2019-04-12  9:02   ` Anand Jain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1552989624-29577-1-git-send-email-anand.jain@oracle.com \
    --to=anand.jain@oracle.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).