From: Qu Wenruo <wqu@suse.com>
To: linux-btrfs@vger.kernel.org
Subject: [PATCH 1/3] Revert "btrfs-progs: convert: add raid-stripe-tree to allowed features"
Date: Tue, 7 May 2024 12:52:53 +0930 [thread overview]
Message-ID: <1557b1ea70084d913d33daa883325cce5b45172b.1715051693.git.wqu@suse.com> (raw)
In-Reply-To: <cover.1715051693.git.wqu@suse.com>
This reverts commit 346a3819237b319985ad6042d6302f67b040a803.
The RST feature (at least for now) is mostly for zoned devices to
support extra data profiles.
Thus btrfs-convert is never designed to handle RST, because there is no
way an ext4/reiserfs can even be created on a zoned device, or it would
create the correct RST tree root at all
Revert this unsupported feature to prevent false alerts.
Signed-off-by: Qu Wenruo <wqu@suse.com>
---
common/fsfeatures.h | 3 +-
tests/common.convert | 44 ++++---------------
tests/convert-tests/001-ext2-basic/test.sh | 2 +-
tests/convert-tests/003-ext4-basic/test.sh | 2 +-
.../005-delete-all-rollback/test.sh | 6 +--
.../convert-tests/010-reiserfs-basic/test.sh | 2 +-
.../011-reiserfs-delete-all-rollback/test.sh | 6 +--
tests/convert-tests/024-ntfs-basic/test.sh | 2 +-
8 files changed, 15 insertions(+), 52 deletions(-)
diff --git a/common/fsfeatures.h b/common/fsfeatures.h
index 5b241bdf9122..f636171f6bd9 100644
--- a/common/fsfeatures.h
+++ b/common/fsfeatures.h
@@ -68,8 +68,7 @@ static const struct btrfs_mkfs_features btrfs_convert_allowed_features = {
BTRFS_FEATURE_INCOMPAT_BIG_METADATA |
BTRFS_FEATURE_INCOMPAT_EXTENDED_IREF |
BTRFS_FEATURE_INCOMPAT_SKINNY_METADATA |
- BTRFS_FEATURE_INCOMPAT_NO_HOLES |
- BTRFS_FEATURE_INCOMPAT_RAID_STRIPE_TREE,
+ BTRFS_FEATURE_INCOMPAT_NO_HOLES,
.runtime_flags = BTRFS_FEATURE_RUNTIME_QUOTA,
};
diff --git a/tests/common.convert b/tests/common.convert
index 06eec9b2a853..50d49a0d32da 100644
--- a/tests/common.convert
+++ b/tests/common.convert
@@ -214,47 +214,19 @@ convert_test_post_check_checksums() {
grep -q 'FAILED' && _fail "file validation failed"
}
-# Check if convert can mount the image based on features
-# $1: name of the feature
-convert_can_mount() {
- local features="$1"
-
- if [ "$features" = 'block-group-tree' ]; then
- if ! [ -f "/sys/fs/btrfs/features/block_group_tree" ]; then
- _log "Skip mount checks due to missing support of block-group-tree"
- return 1
- fi
- fi
- if [ "$features" = 'raid-stripe-tree' ]; then
- if ! [ -f "/sys/fs/btrfs/features/raid_stripe_tree" ]; then
- _log "Skip mount checks due to missing support of raid-stripe-tree"
- return 1
- fi
- fi
-
- return 0
-}
-
# post conversion checks, all three in one call, on an unmounted image
-# $1: features for mount compatibility checks
-# $2: file with checksums
-# $3: file with permissions.
-# $4: file with acl entries.
+# $1: file with checksums
+# $2: file with permissions.
+# $3: file with acl entries.
convert_test_post_checks_all() {
- local features="$1"
-
+ _assert_path "$1"
_assert_path "$2"
_assert_path "$3"
- _assert_path "$4"
-
- if ! convert_can_mount "$features"; then
- return 0
- fi
run_check_mount_test_dev
- convert_test_post_check_checksums "$2"
- convert_test_post_check_permissions "$3"
- convert_test_post_check_acl "$4"
+ convert_test_post_check_checksums "$1"
+ convert_test_post_check_permissions "$2"
+ convert_test_post_check_acl "$3"
# Create a large file to trigger data chunk allocation
generate_dataset "large"
@@ -313,7 +285,7 @@ convert_test() {
run_check_umount_test_dev
convert_test_do_convert "$features" "$nodesize" "$fstype"
- convert_test_post_checks_all "$features" "$CHECKSUMTMP" "$EXT_PERMTMP" "$EXT_ACLTMP"
+ convert_test_post_checks_all "$CHECKSUMTMP" "$EXT_PERMTMP" "$EXT_ACLTMP"
rm -- "$CHECKSUMTMP"
rm -- "$EXT_PERMTMP"
rm -- "$EXT_ACLTMP"
diff --git a/tests/convert-tests/001-ext2-basic/test.sh b/tests/convert-tests/001-ext2-basic/test.sh
index 461ff4a5f1a9..6dc105b55e27 100755
--- a/tests/convert-tests/001-ext2-basic/test.sh
+++ b/tests/convert-tests/001-ext2-basic/test.sh
@@ -12,7 +12,7 @@ check_kernel_support_acl
# Iterate over defaults and options that are not tied to hardware capabilities
# or number of devices
-for feature in '' 'block-group-tree' 'raid-stripe-tree'; do
+for feature in '' 'block-group-tree' ; do
convert_test ext2 "$feature" "ext2 4k nodesize" 4096 mke2fs -b 4096
convert_test ext2 "$feature" "ext2 16k nodesize" 16384 mke2fs -b 4096
convert_test ext2 "$feature" "ext2 64k nodesize" 65536 mke2fs -b 4096
diff --git a/tests/convert-tests/003-ext4-basic/test.sh b/tests/convert-tests/003-ext4-basic/test.sh
index 14637fc852db..8ae5264cb340 100755
--- a/tests/convert-tests/003-ext4-basic/test.sh
+++ b/tests/convert-tests/003-ext4-basic/test.sh
@@ -12,7 +12,7 @@ check_kernel_support_acl
# Iterate over defaults and options that are not tied to hardware capabilities
# or number of devices
-for feature in '' 'block-group-tree' 'raid-stripe-tree' ; do
+for feature in '' 'block-group-tree' ; do
convert_test ext4 "$feature" "ext4 4k nodesize" 4096 mke2fs -t ext4 -b 4096
convert_test ext4 "$feature" "ext4 16k nodesize" 16384 mke2fs -t ext4 -b 4096
convert_test ext4 "$feature" "ext4 64k nodesize" 65536 mke2fs -t ext4 -b 4096
diff --git a/tests/convert-tests/005-delete-all-rollback/test.sh b/tests/convert-tests/005-delete-all-rollback/test.sh
index 5603d3078bc8..fa56ca292bfc 100755
--- a/tests/convert-tests/005-delete-all-rollback/test.sh
+++ b/tests/convert-tests/005-delete-all-rollback/test.sh
@@ -38,10 +38,6 @@ do_test() {
convert_test_do_convert "$features" "$nodesize"
- if ! convert_can_mount "$features"; then
- return 0
- fi
-
run_check_mount_test_dev
convert_test_post_check_checksums "$CHECKSUMTMP"
@@ -68,7 +64,7 @@ do_test() {
# Iterate over defaults and options that are not tied to hardware capabilities
# or number of devices
-for feature in '' 'block-group-tree' 'raid-stripe-tree' ; do
+for feature in '' 'block-group-tree' ; do
do_test "$feature" "ext4 4k nodesize" 4096 mke2fs -t ext4 -b 4096
do_test "$feature" "ext4 16k nodesize" 16384 mke2fs -t ext4 -b 4096
do_test "$feature" "ext4 64k nodesize" 65536 mke2fs -t ext4 -b 4096
diff --git a/tests/convert-tests/010-reiserfs-basic/test.sh b/tests/convert-tests/010-reiserfs-basic/test.sh
index 6ab02b31d176..86b1826783b3 100755
--- a/tests/convert-tests/010-reiserfs-basic/test.sh
+++ b/tests/convert-tests/010-reiserfs-basic/test.sh
@@ -15,7 +15,7 @@ prepare_test_dev
# Iterate over defaults and options that are not tied to hardware capabilities
# or number of devices
-for feature in '' 'block-group-tree' 'raid-stripe-tree'; do
+for feature in '' 'block-group-tree' ; do
convert_test reiserfs "$feature" "reiserfs 4k nodesize" 4096 mkreiserfs -b 4096
convert_test reiserfs "$feature" "reiserfs 16k nodesize" 16384 mkreiserfs -b 4096
convert_test reiserfs "$feature" "reiserfs 64k nodesize" 65536 mkreiserfs -b 4096
diff --git a/tests/convert-tests/011-reiserfs-delete-all-rollback/test.sh b/tests/convert-tests/011-reiserfs-delete-all-rollback/test.sh
index 688613c2c6ad..e1c3e02eb7a0 100755
--- a/tests/convert-tests/011-reiserfs-delete-all-rollback/test.sh
+++ b/tests/convert-tests/011-reiserfs-delete-all-rollback/test.sh
@@ -40,10 +40,6 @@ do_test() {
convert_test_do_convert "$features" "$nodesize"
- if ! convert_can_mount "$features"; then
- return 0
- fi
-
run_check_mount_test_dev
convert_test_post_check_checksums "$CHECKSUMTMP"
@@ -70,7 +66,7 @@ do_test() {
# Iterate over defaults and options that are not tied to hardware capabilities
# or number of devices
-for feature in '' 'block-group-tree' 'raid-stripe-tree'; do
+for feature in '' 'block-group-tree' ; do
do_test "$feature" "reiserfs 4k nodesize" 4096 mkreiserfs -b 4096
do_test "$feature" "reiserfs 16k nodesize" 16384 mkreiserfs -b 4096
do_test "$feature" "reiserfs 64k nodesize" 65536 mkreiserfs -b 4096
diff --git a/tests/convert-tests/024-ntfs-basic/test.sh b/tests/convert-tests/024-ntfs-basic/test.sh
index a93f60070674..d2e1be79ef6b 100755
--- a/tests/convert-tests/024-ntfs-basic/test.sh
+++ b/tests/convert-tests/024-ntfs-basic/test.sh
@@ -17,6 +17,6 @@ prepare_test_dev
# Iterate over defaults and options that are not tied to hardware capabilities
# or number of devices. Test only 4K block size as minimum.
-for feature in '' 'block-group-tree' 'raid-stripe-tree'; do
+for feature in '' 'block-group-tree' ; do
convert_test ntfs "$feature" "ntfs 4k nodesize" 4096 mkfs.ntfs -s 4096
done
--
2.45.0
next prev parent reply other threads:[~2024-05-07 3:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-07 3:22 [PATCH 0/3] btrfs-progs: convert: proper ext4 unwritten extents handling Qu Wenruo
2024-05-07 3:22 ` Qu Wenruo [this message]
2024-05-07 3:22 ` [PATCH 2/3] btrfs-progs: convert: rework file extent iteration to handle unwritten extents Qu Wenruo
2024-05-07 7:48 ` Yordan
2024-05-07 3:22 ` [PATCH 3/3] btrfs-progs: tests/convert: add test case for ext4 " Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1557b1ea70084d913d33daa883325cce5b45172b.1715051693.git.wqu@suse.com \
--to=wqu@suse.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).